gsadmin/rustfs
1
0
Fork 0
mirror of https://github.com/rustfs/rustfs.git synced 2026-08-30 08:49:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(io-metrics): avoid get handoff label allocations (#6160)

Browse Source 
Co-authored-by: heihutu <heihutu@gmail.com>
This commit is contained in:
houseme
2026-08-17 08:26:23 +08:00
committed by GitHub
parent 3377688dab
commit 01e0af6312
1 changed files with 33 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/io-metrics/src/lib.rs
+33 -30
View File
@@ -487,22 +487,21 @@ pub fn record_get_object_completion(total_duration_secs: f64, response_size_byte
/// Record the streaming strategy chosen for a GetObject response body. /// Record the streaming strategy chosen for a GetObject response body.
#[inline(always)] #[inline(always)]
pub fn record_get_object_stream_strategy(strategy: &str, buffer_size_bytes: usize, response_size_bytes: i64) { pub fn record_get_object_stream_strategy(strategy: &'static str, buffer_size_bytes: usize, response_size_bytes: i64) {
if !get_stage_metrics_enabled() { if !get_stage_metrics_enabled() {
return; return;
} }
counter!("rustfs_io_get_object_stream_strategy_total", "strategy" => strategy.to_string()).increment(1); counter!("rustfs_io_get_object_stream_strategy_total", "strategy" => strategy).increment(1);
histogram!("rustfs_io_get_object_stream_buffer_size_bytes", "strategy" => strategy.to_string()) histogram!("rustfs_io_get_object_stream_buffer_size_bytes", "strategy" => strategy).record(usize_to_f64(buffer_size_bytes));
.record(usize_to_f64(buffer_size_bytes)); histogram!("rustfs_io_get_object_stream_response_size_bytes", "strategy" => strategy)
histogram!("rustfs_io_get_object_stream_response_size_bytes", "strategy" => strategy.to_string())
.record(i64_non_negative_to_f64(response_size_bytes)); .record(i64_non_negative_to_f64(response_size_bytes));
} }
/// Record the response-body handoff shape from a GetObject reader into the S3 streaming body. /// Record the response-body handoff shape from a GetObject reader into the S3 streaming body.
#[inline(always)] #[inline(always)]
pub fn record_get_object_response_handoff( pub fn record_get_object_response_handoff(
strategy: &str, strategy: &'static str,
buffer_source: &str, buffer_source: &'static str,
buffer_size_bytes: usize, buffer_size_bytes: usize,
response_size_bytes: i64, response_size_bytes: i64,
duration_secs: f64, duration_secs: f64,
@@ -512,26 +511,26 @@ pub fn record_get_object_response_handoff(
} }
counter!( counter!(
"rustfs_io_get_object_response_handoff_total", "rustfs_io_get_object_response_handoff_total",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string() "buffer_source" => buffer_source
) )
.increment(1); .increment(1);
histogram!( histogram!(
"rustfs_io_get_object_response_handoff_buffer_size_bytes", "rustfs_io_get_object_response_handoff_buffer_size_bytes",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string() "buffer_source" => buffer_source
) )
.record(usize_to_f64(buffer_size_bytes)); .record(usize_to_f64(buffer_size_bytes));
histogram!( histogram!(
"rustfs_io_get_object_response_handoff_response_size_bytes", "rustfs_io_get_object_response_handoff_response_size_bytes",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string() "buffer_source" => buffer_source
) )
.record(i64_non_negative_to_f64(response_size_bytes)); .record(i64_non_negative_to_f64(response_size_bytes));
histogram!( histogram!(
"rustfs_io_get_object_response_handoff_duration_seconds", "rustfs_io_get_object_response_handoff_duration_seconds",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string() "buffer_source" => buffer_source
) )
.record(duration_secs); .record(duration_secs);
record_get_object_response_handoff_duration("s3_handler", duration_secs); record_get_object_response_handoff_duration("s3_handler", duration_secs);
@@ -539,14 +538,18 @@ pub fn record_get_object_response_handoff(
/// Record ReaderStream capacity chosen for GetObject handoff. /// Record ReaderStream capacity chosen for GetObject handoff.
#[inline(always)] #[inline(always)]
pub fn record_get_object_reader_stream_buffer_size(strategy: &str, buffer_source: &str, buffer_size_bytes: usize) { pub fn record_get_object_reader_stream_buffer_size(
strategy: &'static str,
buffer_source: &'static str,
buffer_size_bytes: usize,
) {
if !get_stage_metrics_enabled() { if !get_stage_metrics_enabled() {
return; return;
} }
histogram!( histogram!(
"rustfs_io_get_object_reader_stream_buffer_size_bytes", "rustfs_io_get_object_reader_stream_buffer_size_bytes",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string() "buffer_source" => buffer_source
) )
.record(usize_to_f64(buffer_size_bytes)); .record(usize_to_f64(buffer_size_bytes));
} }
@@ -554,8 +557,8 @@ pub fn record_get_object_reader_stream_buffer_size(strategy: &str, buffer_source
/// Record ReaderStream poll outcomes for GetObject handoff attribution. /// Record ReaderStream poll outcomes for GetObject handoff attribution.
#[inline(always)] #[inline(always)]
pub fn record_get_object_reader_stream_poll( pub fn record_get_object_reader_stream_poll(
strategy: &str, strategy: &'static str,
buffer_source: &str, buffer_source: &'static str,
outcome: &'static str, outcome: &'static str,
remaining_before: usize, remaining_before: usize,
bytes: usize, bytes: usize,
@@ -567,36 +570,36 @@ pub fn record_get_object_reader_stream_poll(
let bytes = u64::try_from(bytes).unwrap_or(u64::MAX); let bytes = u64::try_from(bytes).unwrap_or(u64::MAX);
counter!( counter!(
"rustfs_io_get_object_reader_stream_poll_total", "rustfs_io_get_object_reader_stream_poll_total",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string(), "buffer_source" => buffer_source,
"outcome" => outcome "outcome" => outcome
) )
.increment(1); .increment(1);
counter!( counter!(
"rustfs_io_get_object_reader_stream_poll_bytes_total", "rustfs_io_get_object_reader_stream_poll_bytes_total",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string(), "buffer_source" => buffer_source,
"outcome" => outcome "outcome" => outcome
) )
.increment(bytes); .increment(bytes);
histogram!( histogram!(
"rustfs_io_get_object_reader_stream_poll_remaining_bytes", "rustfs_io_get_object_reader_stream_poll_remaining_bytes",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string(), "buffer_source" => buffer_source,
"outcome" => outcome "outcome" => outcome
) )
.record(usize_to_f64(remaining_before)); .record(usize_to_f64(remaining_before));
histogram!( histogram!(
"rustfs_io_get_object_reader_stream_poll_bytes", "rustfs_io_get_object_reader_stream_poll_bytes",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string(), "buffer_source" => buffer_source,
"outcome" => outcome "outcome" => outcome
) )
.record(usize_to_f64(bytes as usize)); .record(usize_to_f64(bytes as usize));
histogram!( histogram!(
"rustfs_io_get_object_reader_stream_poll_duration_seconds", "rustfs_io_get_object_reader_stream_poll_duration_seconds",
"strategy" => strategy.to_string(), "strategy" => strategy,
"buffer_source" => buffer_source.to_string(), "buffer_source" => buffer_source,
"outcome" => outcome "outcome" => outcome
) )
.record(duration_secs); .record(duration_secs);