Files
renovate/lib/modules/datasource/python-version/index.ts
T
Sebastian Poxhofer 97327c3d28 refactor(linters): add prefer-coerce-array rule (#45492)
* refactor(linters): add prefer-coerce-array rule

Refs #45217

`x ?? []` and `coerceArray(x)` say the same thing, but only the second
one is searchable and consistent. The rule flags a `??` whose default is
a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])`
still passes.

Applying it across `lib/` surfaced three spots the helper cannot cover,
which keep `?? []` with a disable comment or a narrower fix:

- `package-files.ts` destructures a tuple, which `coerceArray()` widens
- `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array
- `mise/upgradeable-tooling.ts` declares a `Record` return, so its
  `?? []` fallback was wrong to begin with and becomes `coerceObject()`

* refactor(platform/github): hoist the GHE version header lookup

`Object.entries(...).find()` returns a tuple, and defaulting it with
`?? []` only to destructure the second element reads as an array
default when it is not one. Name the found entry instead, which drops
the `?? []` rather than routing a tuple through `coerceArray()`.
2026-08-28 09:27:58 +00:00

111 lines
3.7 KiB
TypeScript

import { logger } from '../../../logger/index.ts';
import { coerceArray } from '../../../util/array.ts';
import { withCache } from '../../../util/cache/package/with-cache.ts';
import { HttpError } from '../../../util/http/index.ts';
import { id as versioning } from '../../versioning/python/index.ts';
import { Datasource } from '../datasource.ts';
import { registryUrl as eolRegistryUrl } from '../endoflife-date/common.ts';
import { EndoflifeDateDatasource } from '../endoflife-date/index.ts';
import { GithubReleasesDatasource } from '../github-releases/index.ts';
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
import { datasource, defaultRegistryUrl, githubBaseUrl } from './common.ts';
import { PythonRelease } from './schema.ts';
export class PythonVersionDatasource extends Datasource {
static readonly id = datasource;
pythonPrebuildDatasource: GithubReleasesDatasource;
pythonEolDatasource: EndoflifeDateDatasource;
constructor() {
super(datasource);
this.pythonPrebuildDatasource = new GithubReleasesDatasource();
this.pythonEolDatasource = new EndoflifeDateDatasource();
}
override readonly customRegistrySupport = false;
override readonly defaultRegistryUrls = [defaultRegistryUrl];
override readonly defaultVersioning = versioning;
override readonly caching = true;
async getPrebuildReleases(): Promise<ReleaseResult | null> {
return await this.pythonPrebuildDatasource.getReleases({
registryUrl: githubBaseUrl,
packageName: 'containerbase/python-prebuild',
});
}
async getEolReleases(): Promise<ReleaseResult | null> {
return await this.pythonEolDatasource.getReleases({
registryUrl: eolRegistryUrl,
packageName: 'python',
});
}
private async _getReleases({
registryUrl,
}: GetReleasesConfig): Promise<ReleaseResult | null> {
/* v8 ignore next -- should never happen */
if (!registryUrl) {
return null;
}
const pythonPrebuildReleases = await this.getPrebuildReleases();
const pythonPrebuildVersions = new Set<string>(
pythonPrebuildReleases?.releases.map((release) => release.version),
);
const pythonEolReleases = await this.getEolReleases();
const pythonEolVersions = new Map(
pythonEolReleases?.releases
.filter((release) => release.isDeprecated !== undefined)
.map((release) => [
release.version.split('.').slice(0, 2).join('.'),
release.isDeprecated,
]),
);
const result: ReleaseResult = {
homepage: 'https://python.org',
sourceUrl: 'https://github.com/python/cpython',
registryUrl,
releases: [],
};
try {
const response = await this.http.getJson(registryUrl, PythonRelease);
result.releases.push(
...response.body
.filter((release) => release.isStable)
.filter((release) => pythonPrebuildVersions.has(release.version)),
);
} catch (err) {
if (err instanceof HttpError && err.response?.statusCode === 429) {
logger.debug(
{ err },
'Rate limited by python.org, using prebuild releases',
);
result.releases.push(...coerceArray(pythonPrebuildReleases?.releases));
} else {
this.handleGenericErrors(err);
}
}
for (const release of result.releases) {
release.isDeprecated = pythonEolVersions.get(
release.version.split('.').slice(0, 2).join('.'),
);
}
return result.releases.length ? result : null;
}
getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null> {
return withCache(
{
namespace: `datasource-${datasource}`,
key: `${config.registryUrl}`,
fallback: true,
},
() => this._getReleases(config),
);
}
}