renovate

mirror of https://github.com/renovatebot/renovate.git synced 2026-10-26 07:20:39 +00:00

Files

T

Sebastian Poxhofer 716baf630b fix(linters): add rules for filesystem helpers and Date (#44685 )

* feat(lint): add renovate/prefer-fs-util and renovate/prefer-luxon rules

Two shared-util substitution rules, both at warn level:

- renovate/prefer-fs-util flags value imports of fs, node:fs,
  fs/promises, node:fs/promises, fs-extra and fs-extra/esm in lib/
  source files outside lib/util/fs/, pointing to the scoped helpers
  from lib/util/fs. Spec files and type-only imports are exempt.
  A config-only change via no-restricted-imports was considered but
  rejected: that rule is at error severity globally and per-path warn
  severity is not expressible, so the 13 existing call sites would
  break the baseline.

- renovate/prefer-luxon flags new Date(...) and Date.now() in lib/
  source files, pointing to Luxon per best-practices. Date/time
  utility modules (lib/util/date, lib/util/pretty-time,
  lib/util/timestamp) and spec files (vi.setSystemTime etc.) are
  exempt.

Baseline: 13 prefer-fs-util and 45 prefer-luxon warnings, zero errors.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: use Luxon instead of new Date() at remaining call sites

Fixes all renovate/prefer-luxon violations for `new Date(...)`:

- `new Date().toISOString()` -> `DateTime.utc().toISO()` (byte-identical
  output) in the http cache provider, schedule logging and PR cache.
- `new Date()` -> `DateTime.now().toJSDate()` for the git commit-date
  fallback and the rubygems `syncedAt` markers (same `Date` values).
- rust-release-channel now computes the Rust 1.0 release date and nightly
  version dates via `DateTime.utc(...)`; previously `new Date(y, m, d)`
  used the local timezone while the epoch used UTC, so the comparison was
  timezone-dependent at the boundary date. Tests run with TZ=UTC, where
  behavior is unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: use lib/util/fs helpers in repository worker

Fixes renovate/prefer-fs-util violations outside bootstrap code:

- `fs.ensureDir()` -> `ensureDir()` from lib/util/fs (same fs-extra call
  underneath; it no-ops on an empty dir name, so the repository worker
  spec now simulates the init failure via a rejected `initRepo` instead
  of relying on `fs.ensureDir('')` throwing).
- `fs.remove(privateCacheDir())` -> `cachePathExists()` + `rmCache()`,
  keeping the remove-if-present semantics while asserting cacheDir
  containment.

Two call sites keep raw imports with reasoned disable comments:

- lib/util/modules.ts synchronously enumerates Renovate's own installed
  module directories at import time.
- lib/util/cache/package/impl/sqlite.ts receives cacheDir as an explicit
  argument during global initialization, before GlobalConfig (which the
  scoped cache helpers resolve against) contains cacheDir.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(lint): promote prefer-fs-util and prefer-luxon to error

Both rules are narrowed to what is actually accepted practice before
being promoted:

prefer-luxon no longer flags `Date.now()`: it returns UTC-based epoch
milliseconds used for elapsed-time measurement and TTL arithmetic, which
is timezone-independent by construction. The mined reviewer feedback
behind this rule ("use Luxon for date arithmetic outside util") targets
timezone-dependent date construction/formatting, which cannot occur with
a raw millis number; the rule keeps flagging `new Date(...)`.

prefer-fs-util exempts code that legitimately needs raw fs access
because the scoped lib/util/fs helpers resolve against GlobalConfig
localDir/cacheDir, which does not exist yet or does not apply there:

- lib/logger/: log-file streams at user-configured system paths during
  bootstrap; lib/util/fs also depends on the logger (import cycle).
- lib/workers/global/: creates baseDir/cacheDir themselves and
  reads/writes user-supplied paths before GlobalConfig is seeded.
- lib/config-validator.ts: standalone CLI without GlobalConfig.
- lib/util/git/: owns the localDir lifecycle (clone, emptyDir, symlinks)
  and private-key files with sync cleanup on process exit.

Also fixes a pre-existing tsc error in prefer-fs-util.js: `importKind`
is a TypeScript-ESTree extension missing from eslint's base AST types.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(fs): make rmCache ignore missing paths

All rmCache callers use it for cleanup, where a missing path is a
no-op, so bake force: true in instead of guarding call sites with
an existence check.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(linters): exempt lib/instrumentation from prefer-fs-util

`lib/instrumentation/file-exporter.ts` landed on main while this branch
was open and imports `node:fs/promises` directly.

The exporter writes to a user-configured system path
(`RENOVATE_TRACING_FILE_EXPORTER_PATH`) outside `localDir`/`cacheDir`,
so the scoped helpers do not apply. `lib/instrumentation` is also
deliberately kept out of the module graph of instrumented libraries
(see the `⚠️` note in `lib/renovate.ts`), so it must not pull in
`lib/util/fs` and its config/logger dependencies. Exempt the directory,
as is already done for `lib/logger`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs: shorten doc

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2026-07-25 16:00:44 +00:00

index.spec.ts

test(oxlint): enable vitest/consistent-test-it (#44554 )

2026-07-14 12:28:52 +00:00

index.ts

fix(linters): add rules for filesystem helpers and Date (#44685 )

2026-07-25 16:00:44 +00:00

parse.spec.ts

refactor: Rewrite imports with .ts extensions (#40700 )

2026-01-26 22:48:17 +00:00

parse.ts

chore(deps): update linters (main) (#41417 )

2026-02-28 11:23:25 +00:00

readme.md

…

types.ts

…

util.ts

refactor(oxlint): enable no-else-return and unicorn/no-lonely-if (#44553 )

2026-07-14 12:11:21 +00:00

readme.md

This versioning scheme handles Rust release channel identifiers as used by rustup and other Rust-related tools.

Supported Formats

Channel Names (Ranges)

stable - matches any stable release (e.g., 1.82.0)
beta - matches any beta release (e.g., 1.83.0-beta.5)
nightly - matches any dated nightly (requires date, e.g., nightly-2025-11-24)

Versioned Releases

Full versions: 1.82.0, 1.83.0-beta.5
Version ranges: 1.82 (1.82.0 <= version < 1.83.0)
Beta ranges: 1.83.0-beta (matches all beta versions for 1.83.0)

Dated Nightlies

nightly-2025-11-24 - specific nightly release from a date
nightly-2015-05-15 - historical nightlies (pre-Rust 1.0)

Compatibility Groups

Nightly versions are only compatible with other nightlies
Stable and beta versions are compatible with each other

This affects which updates Renovate will offer.

Stability

Only final releases without prerelease suffixes are considered "stable":

1.82.0 → stable
1.83.0-beta.5 → not stable
nightly-2025-11-24 → not stable

Range Strategies

`pin`

Always pins to the exact new version:

stable → 1.83.0
nightly → nightly-2025-11-24

`replace`

Maintains the format style of the current value:

stable → stable
beta → beta
nightly → nightly
nightly-2025-11-23 → nightly-2025-11-24
1.82 → 1.83
1.82.0 → 1.83.0
1.83.0-beta → 1.84.0-beta
1.83.0-beta.1 → 1.83.0-beta.5

Major/Minor/Patch Extraction

For versioned releases:

Extract directly from semver (e.g., 1.82.0 → major=1, minor=82, patch=0)
Ignore prerelease part (e.g., 1.83.0-beta.5 → major=1, minor=83, patch=0)

For nightlies:

Before 2015-05-15 (Rust 1.0 release): major=0, minor=null, patch=null
After 2015-05-15: major=1, minor=null, patch=null

readme.md

Supported Formats

Channel Names (Ranges)

Versioned Releases

Dated Nightlies

Compatibility Groups

Stability

Range Strategies

pin

replace

Major/Minor/Patch Extraction

Resources

`pin`

`replace`