mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-26 07:20:39 +00:00
Sebastian Poxhofer
58771bb183
* refactor(oxlint): enable func-style Enable the built-in func-style rule as ["warn", "declaration"] so that named functions are written as function declarations instead of arrow or function expressions assigned to variables, matching the convention in docs/development/best-practices.md (Functions section). Inline arrow callbacks are unaffected; prefer-arrow-callback continues to cover the callback direction. Severity is "warn" instead of "error" as a fallback: a repo-wide run found 196 pre-existing violations (70 in spec files, 126 in production code), exceeding the 80-violation fix threshold for this change, so no violations were fixed here. Follow-up work can convert the offenders (largest clusters: lib/modules/versioning/ruby, lib/util/cache/package, lib/modules/versioning/maven, lib/modules/versioning/gradle) and then raise the rule to "error". Note oxlint 1.72 also supports an allowTypeAnnotation option if typed consts should remain arrows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci(linter): enforce func-style at error * refactor(func-style): convert const-arrow functions to declarations in with-cache spec and ruby versioning * refactor(func-style): convert const-arrow functions to declarations in maven/gradle modules * refactor(func-style): convert const-arrow functions to declarations in remaining versioning modules * refactor(func-style): convert const-arrow functions to declarations in platform modules Discriminated-union closures (ensureCommentRemoval byTopic/byContent helpers in github, gitlab, bitbucket, bitbucket-server) needed the narrowed field passed explicitly as a parameter, since function declarations are hoisted and lose the outer if-narrowing that inline arrow-function closures previously relied on. * refactor(func-style): convert const-arrow functions to declarations across util/manager/datasource modules One case (logger/renovate-logger.ts logOnceFn) is kept as an arrow function with a documented oxlint-disable: it is stored on this.logger.once[level] and relies on lexically-bound this, which a hoisted function declaration would not preserve. * refactor(func-style): convert remaining const-arrow test helpers to declarations get-updated.spec.ts: hoisted expectPipCompilePackageAndLockFile to module scope (it only closes over the module-level pipCompile mock) and added a documented oxlint-disable for vitest/expect-expect on its caller test, since oxlint's expect-expect check does not trace assertions through an externally-defined helper function. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
40 lines
1.0 KiB
TypeScript
40 lines
1.0 KiB
TypeScript
import versionings from './api.ts';
|
|
import { Versioning } from './schema.ts';
|
|
import * as semverCoerced from './semver-coerced/index.ts';
|
|
import type { VersioningApi, VersioningApiConstructor } from './types.ts';
|
|
|
|
export * from './types.ts';
|
|
|
|
export const defaultVersioning = semverCoerced;
|
|
|
|
export function getVersioningList(): string[] {
|
|
return Array.from(versionings.keys());
|
|
}
|
|
|
|
/**
|
|
* Get versioning map. Can be used to dynamically add new versioning type
|
|
*/
|
|
export function getVersionings(): Map<
|
|
string,
|
|
VersioningApi | VersioningApiConstructor
|
|
> {
|
|
return versionings;
|
|
}
|
|
|
|
export function get(versioning: string | null | undefined): VersioningApi {
|
|
const res = Versioning.safeParse(versioning ?? defaultVersioning.id);
|
|
|
|
if (!res.success) {
|
|
const [issue] = res.error.issues;
|
|
// oxlint-disable-next-line typescript/prefer-optional-chain
|
|
if (issue && issue.code === 'custom' && issue.params?.error) {
|
|
throw issue.params.error;
|
|
}
|
|
|
|
// istanbul ignore next: should never happen
|
|
throw res.error;
|
|
}
|
|
|
|
return res.data;
|
|
}
|