Files
renovate/lib/modules/versioning/bazel-module/index.ts
T
Sebastian Poxhofer a1971afa78 fix(linters): add linting rule to enforce usage of our regEx utility (#44690)
* ci(linter): add renovate/require-regex-util rule

Adds a custom oxlint rule that flags raw RegExp usage in lib/
production code: any `new RegExp(...)` call and any regex literal
that is not the direct first argument of `regEx(...)`. The regEx()
helper from lib/util/regex.ts uses the RE2 engine for ReDoS-safe
matching and caches compiled patterns. lib/util/regex.ts itself is
exempt.

The rule is disabled for **/*.spec.ts, test/**, and tools/** via
config overrides, because vitest APIs such as expect.stringMatching
need bare RegExp instances (a past commit reverted regEx() there).

Severity is set to "warn" instead of "error": the repo currently has
197 pre-existing violations (above the agreed mechanical-fix
threshold of 80), and a number of them are deliberately
RE2-incompatible patterns (lookahead/lookbehind/named backreferences,
see TODO #12872/#12875 markers in e.g. lib/modules/versioning/rez/
pattern.ts and lib/modules/manager/dockerfile/extract.ts) that need
per-site judgment before they can be wrapped in regEx() or suppressed
with a justified disable comment. No violation fixes are included in
this commit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci(linter): enforce renovate/require-regex-util at error

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: use regEx() for regex literals and RegExp construction in lib

Burn down all renovate/require-regex-util violations (197):

- wrap RE2-compatible regex literals and RegExp constructions in regEx()
- rewrite lookaround patterns where behavior is provably preserved:
  goproxy separator split, sbt-package link extraction, leiningen
  comment stripping and keyword search, npm GitHub owner validation
  (unit-count bound replaced by an explicit length check)
- keep native RegExp with disable comments where RE2 cannot be used:
  moo / good-enough-parser lexer patterns (moo rejects RE2 instances),
  MigrationsService propertyName (matched via isRegExp, which RE2
  instances fail), rez named backreferences and lookaheads, GitHub
  markdown link negative lookbehind, emoji astral-plane matching
- drop stale TODO #12875 comments for patterns current re2 handles

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: reduce require-regex-util disable comments

Rewrite the github massage-markdown-links URL regex to capture an
optional `api.` prefix in a named group (skipped in code) instead of
relying on a negative lookbehind, so both the base and global variants
can use regEx()/RE2 and their two disable comments are removed. Add
spec cases for api-prefixed URLs that match the URL shape.

Consolidate the four related line disables in rez/pattern.ts (bound and
range patterns emulating Python conditional patterns via named
backreferences and lookaheads, which RE2 cannot express) into a single
block disable/enable pair, matching the treatment of the lexer files.

Disable comment count drops from 13 to 8.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(datasource/sbt-package): use named capture group in link regex

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(manager/cake): restore original multiLineComment regex spelling

The [^] -> [\\s\\S] rewrite was only needed for an RE2 wrap that was
later reverted; keep the diff minimal.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(datasource/go): skip empty GOPROXY segments

The switch from a lookahead split to a capture-group split (needed because
RE2 has no lookahead support) changed how empty GOPROXY segments parse:
`a|,b` yielded `{ url: ',', fallback: '|' }` before and
`{ url: '', fallback: ',' }` after. The comma fallback only continues on
404/410, so a failing proxy ahead of an empty segment silently stopped the
lookup instead of falling through to the remaining proxies.

Empty segments carry no url to query, so drop them.

* refactor(datasource/go): use isTruthy for empty segment filter

* fix(datasource/go): filter empty segments before mapping

Filtering after the map broke the contextual typing from the
GoproxyItem[] annotation, widening fallback to string.

* refactor(platform/github): use regEx() for merge queue query stripping

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-14 14:30:46 +00:00

184 lines
4.6 KiB
TypeScript

import { isNullOrUndefined } from '@sindresorhus/is';
import { regEx } from '../../../util/regex.ts';
import type { NewValueConfig, VersioningApi } from '../types.ts';
import { BzlmodVersion } from './bzlmod-version.ts';
export const id = 'bazel-module';
export const displayName = 'Bazel Module';
export const urls = ['[Bazel modules](https://bazel.build/external/module)'];
export const supportsRanges = false;
function getBzlmodVersion(version: string): BzlmodVersion {
return new BzlmodVersion(version);
}
function getMajor(version: string): null | number {
return getBzlmodVersion(version).release.major;
}
function getMinor(version: string): null | number {
return getBzlmodVersion(version).release.minor;
}
function getPatch(version: string): null | number {
return getBzlmodVersion(version).release.patch;
}
/**
* Check whether `version` and `other` are logically equivalent, even if
* they're not the exact same string.
*
* For example, with Semver the build metadata should be ignored when comparing.
*/
function equals(version: string, other: string): boolean {
const abv = new BzlmodVersion(version);
const bbv = new BzlmodVersion(other);
return abv.equals(bbv);
}
/**
* Check whether `version` is "greater" than the `other` version.
*/
function isGreaterThan(version: string, other: string): boolean {
const abv = new BzlmodVersion(version);
const bbv = new BzlmodVersion(other);
return abv.isGreaterThan(bbv);
}
/**
* Check whether the `version` is "less" than all the versions possible in
* the `range`.
*/
function isLessThanRange(version: string, range: string): boolean {
const abv = new BzlmodVersion(version);
const bbv = new BzlmodVersion(range);
return abv.isLessThan(bbv);
}
/**
* Select the highest version from `versions` that is within the given
* `range` constraint, or return `null` if there is no matching version.
*/
function getSatisfyingVersion(
versions: string[],
range: string,
): string | null {
const target = new BzlmodVersion(range);
const result = versions.find((ver) => {
const bv = new BzlmodVersion(ver);
return target.equals(bv);
});
return result ? range : null;
}
/**
* Select the lowest version from `versions` that is within the given
* `range` constraint, or return `null` if there is no matching version.
*/
function minSatisfyingVersion(
versions: string[],
range: string,
): string | null {
return getSatisfyingVersion(versions, range);
}
/**
* Calculate a new version constraint based on the current constraint, the
* `rangeStrategy` option, and the current and new version.
*/
function getNewValue({
currentValue,
currentVersion,
newVersion,
}: NewValueConfig): string {
if (currentVersion === `v${currentValue}`) {
return newVersion.replace(regEx(/^v/), '');
}
return newVersion;
}
/**
* Compare two versions. Return `0` if `v1 == v2`, or `1` if `v1` is
* greater, or `-1` if `v2` is greater.
*/
function sortVersions(version: string, other: string): number {
const abv = new BzlmodVersion(version);
const bbv = new BzlmodVersion(other);
return BzlmodVersion.defaultCompare(abv, bbv);
}
/**
* Check whether the `version` satisfies the `range` constraint.
*/
function matches(version: string, range: string): boolean {
return equals(version, range);
}
/**
* Check whether the `version` is compatible with the `current` value
* constraint.
*/
function isCompatible(version: string, _current?: string): boolean {
return isValid(version);
}
/**
* Check whether the `version` constraint is not a range, i.e. it only allows a
* single specific version.
*/
function isSingleVersion(version: string): boolean {
return isValid(version);
}
/**
* Check whether the `version` is considered to be "stable".
*
* Example: in SemVer the version must not have a pre-release marker.
*/
function isStable(version: string): boolean {
const abv = new BzlmodVersion(version);
return !abv.isPrerelease;
}
/**
* Check whether the `input` is a valid version or a valid version range constraint.
*/
function isValid(input: string): boolean {
try {
new BzlmodVersion(input);
} catch {
return false;
}
return true;
}
/**
* Check whether the `input` is a valid version string.
*/
function isVersion(input: string | undefined | null): boolean {
if (isNullOrUndefined(input)) {
return false;
}
return isValid(input);
}
export const api: VersioningApi = {
equals,
getMajor,
getMinor,
getPatch,
isCompatible,
isGreaterThan,
isLessThanRange,
isSingleVersion,
isStable,
isValid,
isVersion,
matches,
getSatisfyingVersion,
minSatisfyingVersion,
getNewValue,
sortVersions,
};
export default api;