mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-25 23:11:31 +00:00
Sebastian Poxhofer
e0cec3dc95
feat(lint): add `types-location` rule and enable it for `lib/modules`
Reviewers consistently ask for exported types to be moved into a
colocated `types.ts`. Add a `renovate/types-location` oxlint rule that
reports `export interface` / `export type` declarations outside such a
file, and turn it on across `lib/modules`.
Re-exports (`export type { X }`, `export type *`), file-local types, and
values (enums, classes, functions) are left alone. `schema.ts` files and
`schema/` directories are excluded via config, matching how
`zod-schema-location` is configured — inferred types belong next to the
schema they are derived from.
Relocating the 87 existing violations means:
- new `types.ts` files for the modules that had none
- `terragrunt/common.ts` folded into its `types.ts`, as it held nothing
else
- `RangeBound` in `versioning/gradle/compare.ts` un-exported, since only
a file-local interface referenced it
- `bazel-module/parser/fragments.ts` split from its inferred types, which
now live in `parser/types.ts` and infer through a namespace import so
each schema keeps its merged name
33 lines
1.3 KiB
TypeScript
33 lines
1.3 KiB
TypeScript
import { getSourceUrl as githubSourceUrl } from '../../../util/github/url.ts';
|
|
import { BitbucketTagsDatasource } from '../bitbucket-tags/index.ts';
|
|
import { ForgejoTagsDatasource } from '../forgejo-tags/index.ts';
|
|
import { GiteaTagsDatasource } from '../gitea-tags/index.ts';
|
|
import { GithubTagsDatasource } from '../github-tags/index.ts';
|
|
import { GitlabTagsDatasource } from '../gitlab-tags/index.ts';
|
|
import { getSourceUrl as gitlabSourceUrl } from '../gitlab-tags/util.ts';
|
|
|
|
import type { DataSource } from './types.ts';
|
|
|
|
export function getSourceUrl(
|
|
dataSource?: DataSource | null,
|
|
): string | undefined {
|
|
if (dataSource) {
|
|
const { datasource, registryUrl, packageName } = dataSource;
|
|
|
|
switch (datasource) {
|
|
case ForgejoTagsDatasource.id:
|
|
return ForgejoTagsDatasource.getSourceUrl(packageName, registryUrl);
|
|
case GiteaTagsDatasource.id:
|
|
return GiteaTagsDatasource.getSourceUrl(packageName, registryUrl);
|
|
case GithubTagsDatasource.id:
|
|
return githubSourceUrl(packageName, registryUrl);
|
|
case GitlabTagsDatasource.id:
|
|
return gitlabSourceUrl(packageName, registryUrl);
|
|
case BitbucketTagsDatasource.id:
|
|
return BitbucketTagsDatasource.getSourceUrl(packageName, registryUrl);
|
|
}
|
|
}
|
|
|
|
return undefined;
|
|
}
|