Files
renovate/tools/mkdocs.ts
T
Sebastian Poxhofer 58771bb183 refactor(linters): enabled oxlints func-style (#44691)
* refactor(oxlint): enable func-style

Enable the built-in func-style rule as ["warn", "declaration"] so that
named functions are written as function declarations instead of arrow or
function expressions assigned to variables, matching the convention in
docs/development/best-practices.md (Functions section). Inline arrow
callbacks are unaffected; prefer-arrow-callback continues to cover the
callback direction.

Severity is "warn" instead of "error" as a fallback: a repo-wide run
found 196 pre-existing violations (70 in spec files, 126 in production
code), exceeding the 80-violation fix threshold for this change, so no
violations were fixed here. Follow-up work can convert the offenders
(largest clusters: lib/modules/versioning/ruby, lib/util/cache/package,
lib/modules/versioning/maven, lib/modules/versioning/gradle) and then
raise the rule to "error". Note oxlint 1.72 also supports an
allowTypeAnnotation option if typed consts should remain arrows.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci(linter): enforce func-style at error

* refactor(func-style): convert const-arrow functions to declarations in with-cache spec and ruby versioning

* refactor(func-style): convert const-arrow functions to declarations in maven/gradle modules

* refactor(func-style): convert const-arrow functions to declarations in remaining versioning modules

* refactor(func-style): convert const-arrow functions to declarations in platform modules

Discriminated-union closures (ensureCommentRemoval byTopic/byContent
helpers in github, gitlab, bitbucket, bitbucket-server) needed the
narrowed field passed explicitly as a parameter, since function
declarations are hoisted and lose the outer if-narrowing that inline
arrow-function closures previously relied on.

* refactor(func-style): convert const-arrow functions to declarations across util/manager/datasource modules

One case (logger/renovate-logger.ts logOnceFn) is kept as an arrow
function with a documented oxlint-disable: it is stored on
this.logger.once[level] and relies on lexically-bound this, which a
hoisted function declaration would not preserve.

* refactor(func-style): convert remaining const-arrow test helpers to declarations

get-updated.spec.ts: hoisted expectPipCompilePackageAndLockFile to
module scope (it only closes over the module-level pipCompile mock)
and added a documented oxlint-disable for vitest/expect-expect on its
caller test, since oxlint's expect-expect check does not trace
assertions through an externally-defined helper function.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-19 11:14:22 +00:00

136 lines
3.9 KiB
TypeScript

import { Command } from 'commander';
import type { ExecaChildProcess, ExecaReturnValue } from 'execa';
import { execa } from 'execa';
import fs from 'fs-extra';
import { init, logger } from '../lib/logger/index.ts';
import { generateDocs } from './docs/index.ts';
import { exec } from './utils/exec.ts';
await init();
process.on('unhandledRejection', (err) => {
// Will print "unhandledRejection err is not defined"
logger.error({ err }, 'unhandledRejection');
process.exit(-1);
});
const program = new Command('pnpm mkdocs').description('Run mkdocs');
program
.command('build', { isDefault: true })
.description('Build mkdocs')
.option('--version <version>', 'the current version of the Renovate CLI')
.option('--no-build', 'do not build docs from source')
.option('--no-strict', 'do not build in strict mode')
.option('--no-announcement', 'do not include the announcement bar')
.action(async (opts) => {
await prepareDocs(opts);
if (opts.announcement) {
logger.info('* running mkdocs build');
} else {
logger.info('* running mkdocs build (without announcement bar)');
}
const args = ['run', 'mkdocs', 'build'];
if (opts.strict) {
args.push('--strict');
}
const res = await exec('uv', args, {
cwd: 'tools/mkdocs',
stdio: 'inherit',
env: {
...process.env,
RENOVATE_VERSION: opts.version ?? '',
MKDOCS_INCLUDE_ANNOUNCEMENT: opts.announcement ? 'true' : '',
},
reject: false,
});
checkResult(res);
});
program
.command('serve')
.description('serve mkdocs')
.option('--no-build', 'do not build docs from source')
.option('--no-strict', 'do not build in strict mode')
.action(async (opts) => {
logger.info('serving docs');
const mkdocsArgs = ['run', 'mkdocs', 'serve'];
if (opts.strict) {
mkdocsArgs.push('--strict');
}
function spawnServe(): ExecaChildProcess {
return execa('uv', mkdocsArgs, {
cwd: 'tools/mkdocs',
stdio: 'inherit',
reject: false,
maxBuffer: 20 * 1024 * 1024,
encoding: 'utf8',
});
}
if (!opts.build) {
await prepareDocs(opts);
checkResult(await spawnServe());
return;
}
let activeChild: ExecaChildProcess | null = null;
let shouldRestart = false;
let debounceTimer: ReturnType<typeof setTimeout> | undefined;
fs.watch('docs', { recursive: true }, () => {
clearTimeout(debounceTimer);
debounceTimer = setTimeout(() => {
logger.info('docs changed, restarting mkdocs...');
shouldRestart = true;
activeChild?.kill();
}, 300);
});
while (true) {
shouldRestart = false;
await prepareDocs(opts);
logger.info('* running mkdocs serve');
activeChild = spawnServe();
const res = await activeChild;
if (!shouldRestart) {
checkResult(res);
break;
}
}
});
async function prepareDocs(opts: any): Promise<void> {
logger.info('Building docs');
if (opts.build) {
logger.info('* generate docs');
await generateDocs('tools/mkdocs', false, opts.version);
} else {
logger.info('* using prebuild docs from build step');
await fs.copy('tmp/docs', 'tools/mkdocs/docs');
}
}
function checkResult(res: ExecaReturnValue): void {
if (res.signal) {
logger.error(`Signal received: ${res.signal}`);
process.exit(-1);
} else if (res.exitCode) {
logger.error(`Error occured:\n${res.stderr || res.stdout}`);
process.exit(res.exitCode);
} else if (res.timedOut) {
logger.error({ res }, 'Process timed out');
process.exit(-1);
} else if (res.killed) {
logger.error({ res }, 'Process was killed');
process.exit(-1);
} else if (res.failed) {
logger.error({ res }, 'Process call failed');
process.exit(-1);
} else {
logger.debug(`Build completed:\n${res.stdout || res.stderr}`);
}
}
void program.parseAsync();