mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-25 23:11:31 +00:00
a1971afa78
* ci(linter): add renovate/require-regex-util rule Adds a custom oxlint rule that flags raw RegExp usage in lib/ production code: any `new RegExp(...)` call and any regex literal that is not the direct first argument of `regEx(...)`. The regEx() helper from lib/util/regex.ts uses the RE2 engine for ReDoS-safe matching and caches compiled patterns. lib/util/regex.ts itself is exempt. The rule is disabled for **/*.spec.ts, test/**, and tools/** via config overrides, because vitest APIs such as expect.stringMatching need bare RegExp instances (a past commit reverted regEx() there). Severity is set to "warn" instead of "error": the repo currently has 197 pre-existing violations (above the agreed mechanical-fix threshold of 80), and a number of them are deliberately RE2-incompatible patterns (lookahead/lookbehind/named backreferences, see TODO #12872/#12875 markers in e.g. lib/modules/versioning/rez/ pattern.ts and lib/modules/manager/dockerfile/extract.ts) that need per-site judgment before they can be wrapped in regEx() or suppressed with a justified disable comment. No violation fixes are included in this commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci(linter): enforce renovate/require-regex-util at error Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: use regEx() for regex literals and RegExp construction in lib Burn down all renovate/require-regex-util violations (197): - wrap RE2-compatible regex literals and RegExp constructions in regEx() - rewrite lookaround patterns where behavior is provably preserved: goproxy separator split, sbt-package link extraction, leiningen comment stripping and keyword search, npm GitHub owner validation (unit-count bound replaced by an explicit length check) - keep native RegExp with disable comments where RE2 cannot be used: moo / good-enough-parser lexer patterns (moo rejects RE2 instances), MigrationsService propertyName (matched via isRegExp, which RE2 instances fail), rez named backreferences and lookaheads, GitHub markdown link negative lookbehind, emoji astral-plane matching - drop stale TODO #12875 comments for patterns current re2 handles Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: reduce require-regex-util disable comments Rewrite the github massage-markdown-links URL regex to capture an optional `api.` prefix in a named group (skipped in code) instead of relying on a negative lookbehind, so both the base and global variants can use regEx()/RE2 and their two disable comments are removed. Add spec cases for api-prefixed URLs that match the URL shape. Consolidate the four related line disables in rez/pattern.ts (bound and range patterns emulating Python conditional patterns via named backreferences and lookaheads, which RE2 cannot express) into a single block disable/enable pair, matching the treatment of the lexer files. Disable comment count drops from 13 to 8. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(datasource/sbt-package): use named capture group in link regex Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(manager/cake): restore original multiLineComment regex spelling The [^] -> [\\s\\S] rewrite was only needed for an RE2 wrap that was later reverted; keep the diff minimal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(datasource/go): skip empty GOPROXY segments The switch from a lookahead split to a capture-group split (needed because RE2 has no lookahead support) changed how empty GOPROXY segments parse: `a|,b` yielded `{ url: ',', fallback: '|' }` before and `{ url: '', fallback: ',' }` after. The comma fallback only continues on 404/410, so a failing proxy ahead of an empty segment silently stopped the lookup instead of falling through to the remaining proxies. Empty segments carry no url to query, so drop them. * refactor(datasource/go): use isTruthy for empty segment filter * fix(datasource/go): filter empty segments before mapping Filtering after the map broke the contextual typing from the GoproxyItem[] annotation, widening fallback to string. * refactor(platform/github): use regEx() for merge queue query stripping --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
207 lines
5.3 KiB
TypeScript
207 lines
5.3 KiB
TypeScript
import {
|
|
eq,
|
|
gt,
|
|
maxSatisfying,
|
|
minSatisfying,
|
|
satisfies,
|
|
valid,
|
|
} from '@renovatebot/ruby-semver';
|
|
import { isString } from '@sindresorhus/is';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import type { RangeStrategy } from '../../../types/versioning.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import type { NewValueConfig, VersioningApi } from '../types.ts';
|
|
import { isSingleOperator, isValidOperator } from './operator.ts';
|
|
import { ltr, parse as parseRange } from './range.ts';
|
|
import { bump, replace, widen } from './strategies/index.ts';
|
|
import { parse as parseVersion } from './version.ts';
|
|
|
|
export const id = 'ruby';
|
|
export const displayName = 'Ruby';
|
|
export const urls = [
|
|
'[RubyGems patterns](https://guides.rubygems.org/patterns/)',
|
|
'[Bundler Gemfile guide](https://bundler.io/guides/gemfile.html)',
|
|
'[Understanding Gem versions](https://www.devalot.com/articles/2012/04/gem-versions.html)',
|
|
];
|
|
export const supportsRanges = true;
|
|
export const supportedRangeStrategies: RangeStrategy[] = [
|
|
'bump',
|
|
'widen',
|
|
'replace',
|
|
];
|
|
|
|
function vtrim<T = unknown>(version: T): string | T {
|
|
if (isString(version)) {
|
|
return version.replace(regEx(/^v/), '').replace(regEx(/('|")/g), '');
|
|
}
|
|
return version;
|
|
}
|
|
|
|
function equals(left: string, right: string): boolean {
|
|
return eq(vtrim(left), vtrim(right));
|
|
}
|
|
|
|
function getMajor(version: string): number {
|
|
return parseVersion(vtrim(version)).major;
|
|
}
|
|
function getMinor(version: string): number {
|
|
return parseVersion(vtrim(version)).minor;
|
|
}
|
|
function getPatch(version: string): number {
|
|
return parseVersion(vtrim(version)).patch;
|
|
}
|
|
|
|
export function isVersion(version: string): boolean {
|
|
return !!valid(vtrim(version));
|
|
}
|
|
function isGreaterThan(left: string, right: string): boolean {
|
|
return gt(vtrim(left), vtrim(right));
|
|
}
|
|
function isLessThanRange(version: string, range: string): boolean {
|
|
return !!ltr(vtrim(version), vtrim(range));
|
|
}
|
|
|
|
function isSingleVersion(range: string): boolean {
|
|
const { version, operator } = parseRange(vtrim(range));
|
|
|
|
return operator
|
|
? isVersion(version) && isSingleOperator(operator)
|
|
: isVersion(version);
|
|
}
|
|
|
|
function isStable(version: string): boolean {
|
|
const v = vtrim(version);
|
|
return parseVersion(v).prerelease ? false : isVersion(v);
|
|
}
|
|
|
|
export function isValid(input: string): boolean {
|
|
return input
|
|
.split(',')
|
|
.map((piece) => vtrim(piece.trim()))
|
|
.every((range) => {
|
|
const { version, operator } = parseRange(range);
|
|
|
|
return operator
|
|
? isVersion(version) && isValidOperator(operator)
|
|
: isVersion(version);
|
|
});
|
|
}
|
|
|
|
export function matches(version: string, range: string): boolean {
|
|
return satisfies(vtrim(version), vtrim(range));
|
|
}
|
|
|
|
function getSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
return maxSatisfying(versions.map(vtrim), vtrim(range));
|
|
}
|
|
|
|
function minSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
return minSatisfying(versions.map(vtrim), vtrim(range));
|
|
}
|
|
|
|
function getPinnedValue(value: string): string {
|
|
return vtrim(value);
|
|
}
|
|
|
|
function getNewValue({
|
|
currentValue,
|
|
rangeStrategy,
|
|
currentVersion,
|
|
newVersion,
|
|
}: NewValueConfig): string | null {
|
|
let newValue = null;
|
|
if (isVersion(currentValue)) {
|
|
newValue =
|
|
currentValue.startsWith('v') && !newVersion.startsWith('v')
|
|
? `v${newVersion}`
|
|
: newVersion;
|
|
} else if (currentValue.replace(regEx(/^=\s*/), '') === currentVersion) {
|
|
newValue = currentValue.replace(currentVersion, newVersion);
|
|
} else {
|
|
switch (rangeStrategy) {
|
|
case 'update-lockfile':
|
|
if (satisfies(newVersion, vtrim(currentValue))) {
|
|
newValue = vtrim(currentValue);
|
|
} else {
|
|
return getNewValue({
|
|
currentValue,
|
|
rangeStrategy: 'replace',
|
|
currentVersion,
|
|
newVersion,
|
|
});
|
|
}
|
|
break;
|
|
case 'bump':
|
|
newValue = bump({ range: vtrim(currentValue), to: vtrim(newVersion) });
|
|
break;
|
|
case 'auto':
|
|
case 'replace':
|
|
newValue = replace({
|
|
range: vtrim(currentValue),
|
|
to: vtrim(newVersion),
|
|
});
|
|
break;
|
|
case 'widen':
|
|
newValue = widen({
|
|
range: vtrim(currentValue),
|
|
to: vtrim(newVersion),
|
|
});
|
|
break;
|
|
// istanbul ignore next
|
|
default:
|
|
logger.warn({ rangeStrategy }, 'Unsupported range strategy');
|
|
}
|
|
}
|
|
if (newValue && regEx(/^('|")/).exec(currentValue)) {
|
|
const delimiter = currentValue[0];
|
|
return newValue
|
|
.split(',')
|
|
.map((element) =>
|
|
element.replace(
|
|
regEx(`^(?<whitespace>\\s*)`),
|
|
`$<whitespace>${delimiter}`,
|
|
),
|
|
)
|
|
.map(
|
|
(element) =>
|
|
element.replace(
|
|
regEx(/(?<whitespace>\s*)$/),
|
|
`${delimiter}$<whitespace>`,
|
|
), // TODO #12875 adds ' at front when re2 is used
|
|
)
|
|
.join(',');
|
|
}
|
|
return newValue;
|
|
}
|
|
|
|
export function sortVersions(left: string, right: string): number {
|
|
return gt(vtrim(left), vtrim(right)) ? 1 : -1;
|
|
}
|
|
|
|
export const api: VersioningApi = {
|
|
equals,
|
|
getMajor,
|
|
getMinor,
|
|
getPatch,
|
|
isCompatible: isVersion,
|
|
isGreaterThan,
|
|
isLessThanRange,
|
|
isSingleVersion,
|
|
isStable,
|
|
isValid,
|
|
isVersion,
|
|
matches,
|
|
getSatisfyingVersion,
|
|
minSatisfyingVersion,
|
|
getPinnedValue,
|
|
getNewValue,
|
|
sortVersions,
|
|
};
|
|
export default api;
|