mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-25 15:01:49 +00:00
Sebastian Poxhofer
e0cec3dc95
feat(lint): add `types-location` rule and enable it for `lib/modules`
Reviewers consistently ask for exported types to be moved into a
colocated `types.ts`. Add a `renovate/types-location` oxlint rule that
reports `export interface` / `export type` declarations outside such a
file, and turn it on across `lib/modules`.
Re-exports (`export type { X }`, `export type *`), file-local types, and
values (enums, classes, functions) are left alone. `schema.ts` files and
`schema/` directories are excluded via config, matching how
`zod-schema-location` is configured — inferred types belong next to the
schema they are derived from.
Relocating the 87 existing violations means:
- new `types.ts` files for the modules that had none
- `terragrunt/common.ts` folded into its `types.ts`, as it held nothing
else
- `RangeBound` in `versioning/gradle/compare.ts` un-exported, since only
a file-local interface referenced it
- `bazel-module/parser/fragments.ts` split from its inferred types, which
now live in `parser/types.ts` and infer through a namespace import so
each schema keeps its merged name
36 lines
979 B
TypeScript
36 lines
979 B
TypeScript
import _nodeSchedule from '../../../data/node-js-schedule.json' with { type: 'json' };
|
|
import type { Nullish } from '../../../types/index.ts';
|
|
import semver from '../semver/index.ts';
|
|
import type {
|
|
NodeJsData,
|
|
NodeJsSchedule,
|
|
NodeJsScheduleWithVersion,
|
|
} from './types.ts';
|
|
|
|
const nodeSchedule: NodeJsData = _nodeSchedule;
|
|
|
|
const nodeCodenames = new Map<string, NodeJsScheduleWithVersion>();
|
|
for (const version of Object.keys(nodeSchedule)) {
|
|
const schedule = nodeSchedule[version];
|
|
if (schedule.codename) {
|
|
nodeCodenames.set(schedule.codename.toUpperCase(), {
|
|
version,
|
|
...schedule,
|
|
});
|
|
}
|
|
}
|
|
|
|
export function findScheduleForCodename(
|
|
codename: string,
|
|
): Nullish<NodeJsScheduleWithVersion> {
|
|
return nodeCodenames.get(codename?.toUpperCase());
|
|
}
|
|
|
|
export function findScheduleForVersion(
|
|
version: string,
|
|
): Nullish<NodeJsSchedule> {
|
|
const major = semver.getMajor(version);
|
|
const schedule = nodeSchedule[`v${major!}`];
|
|
return schedule;
|
|
}
|