Files
renovate/lib/modules/datasource/python-version/index.ts
T
Sebastian Poxhofer a3d265d45d refactor(datasource): stop double-caching releases at the index level (#46103)
* refactor(datasource): stop double-caching releases at the index level

15 datasources set `caching = true`, which makes the registry wrapper in
`lib/modules/datasource/index.ts` store every `getReleases` result under
`datasource-releases-<id>` for 15 minutes, while their own `cached()`
wrapper already stores the same result under `datasource-<id>` with a
longer TTL and stale-fallback. Drop `caching` from those 15; the four
that rely on the index cache alone (dart-version, flutter-version,
maven, pypi) keep it.

`caching` is documented as requiring the datasource to return the
`isPrivate` flag, and none of these 15 ever set it, so the index layer
was caching private results unconditionally. The remaining `cached()`
layer honours `cachePrivatePackages` as before.

Also fix two cache-key/registry defects found alongside:

- `galaxy-collection` declares `registryStrategy = 'hunt'` but keyed its
  cache on the package name only, so a `null` from the first hunted
  registry was replayed for the second one. The registry URL is now part
  of the key, which invalidates existing entries once.
- `typst` ignores `config.registryUrl` and always reads its default
  registry, so it now sets `customRegistrySupport = false`. A configured
  `registryUrls` for typst is now warned about and ignored instead of
  being silently dropped.

* Merge branch 'main' into secustor/refactor/datasource-remove-index-caching
2026-09-24 21:07:52 +00:00

111 lines
3.6 KiB
TypeScript

import { logger } from '../../../logger/index.ts';
import { coerceArray } from '../../../util/array.ts';
import { HttpError } from '../../../util/http/index.ts';
import { id as versioning } from '../../versioning/python/index.ts';
import { Datasource } from '../datasource.ts';
import { registryUrl as eolRegistryUrl } from '../endoflife-date/common.ts';
import { EndoflifeDateDatasource } from '../endoflife-date/index.ts';
import { GithubReleasesDatasource } from '../github-releases/index.ts';
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
import { datasource, defaultRegistryUrl, githubBaseUrl } from './common.ts';
import { PythonRelease } from './schema.ts';
export class PythonVersionDatasource extends Datasource {
static readonly id = datasource;
pythonPrebuildDatasource: GithubReleasesDatasource;
pythonEolDatasource: EndoflifeDateDatasource;
constructor() {
super(datasource);
this.pythonPrebuildDatasource = new GithubReleasesDatasource();
this.pythonEolDatasource = new EndoflifeDateDatasource();
}
override supportsCustomRegistry(_packageName: string): boolean {
return false;
}
override getDefaultRegistryUrls(_packageName: string): string[] {
return [defaultRegistryUrl];
}
override readonly defaultVersioning = versioning;
async getPrebuildReleases(): Promise<ReleaseResult | null> {
return await this.pythonPrebuildDatasource.getReleases({
registryUrl: githubBaseUrl,
packageName: 'containerbase/python-prebuild',
});
}
async getEolReleases(): Promise<ReleaseResult | null> {
return await this.pythonEolDatasource.getReleases({
registryUrl: eolRegistryUrl,
packageName: 'python',
});
}
private async fetchReleases({
registryUrl,
}: GetReleasesConfig): Promise<ReleaseResult | null> {
/* v8 ignore next -- should never happen */
if (!registryUrl) {
return null;
}
const pythonPrebuildReleases = await this.getPrebuildReleases();
const pythonPrebuildVersions = new Set<string>(
pythonPrebuildReleases?.releases.map((release) => release.version),
);
const pythonEolReleases = await this.getEolReleases();
const pythonEolVersions = new Map(
pythonEolReleases?.releases
.filter((release) => release.isDeprecated !== undefined)
.map((release) => [
release.version.split('.').slice(0, 2).join('.'),
release.isDeprecated,
]),
);
const result: ReleaseResult = {
homepage: 'https://python.org',
sourceUrl: 'https://github.com/python/cpython',
registryUrl,
releases: [],
};
try {
const response = await this.http.getJson(registryUrl, PythonRelease);
result.releases.push(
...response.body
.filter((release) => release.isStable)
.filter((release) => pythonPrebuildVersions.has(release.version)),
);
} catch (err) {
if (err instanceof HttpError && err.response?.statusCode === 429) {
logger.debug(
{ err },
'Rate limited by python.org, using prebuild releases',
);
result.releases.push(...coerceArray(pythonPrebuildReleases?.releases));
} else {
this.handleGenericErrors(err);
}
}
for (const release of result.releases) {
release.isDeprecated = pythonEolVersions.get(
release.version.split('.').slice(0, 2).join('.'),
);
}
return result.releases.length ? result : null;
}
getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null> {
return this.cached(
{
key: `${config.registryUrl}`,
fallback: true,
},
() => this.fetchReleases(config),
);
}
}