Files
Sebastian Poxhofer 3412de84ce refactor(linters): enable oxlint rule prefer-named-capture-group (#44714)
* refactor(lint): enable oxlint prefer-named-capture-group at error

Numbered capture groups (m[1], $1) break silently when a regex is
edited and group order shifts. Named groups (?<name>...) make intent
explicit and accesses (m.groups.name) resilient to reordering.

This enables the built-in eslint rule prefer-named-capture-group,
surfacing 321 pre-existing unnamed-group violations across ~121
files to be burned down incrementally in follow-up commits.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(versioning): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations in
lib/modules/versioning/. Unused capture groups (only reachable via
.test() or whole-match) become non-capturing (?:...); groups whose
value is read become named (?<name>...), with accesses rewritten to
match.groups!.<name> (or destructured from .groups!) instead of
positional match[n]/$n so a future edit that reorders groups cannot
silently break the reader.

Two cases needed extra care to preserve behavior:
- semver/common.ts and poetry/patterns.ts split() on a regex whose
  capture group is relied upon by String.prototype.split to keep the
  separator in the output array; the group is kept capturing and
  named, not converted to non-capturing.
- hashicorp/convertor.ts's semverRegex is only ever embedded via
  .source into a named `(?<version>...)` group elsewhere and never
  matched directly, so its internal groups are safe to make
  non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(datasource): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/datasource/. Same treatment as the versioning module:
unused groups become non-capturing, used groups get names, and
positional match[n] reads move to match.groups!.<name>.

docker/ecr.ts and pypi/common.ts keep their positional destructuring
(`const [, region] = ...`, `!!m &&`) working unchanged since a named
capture group is still addressable by its numeric index in
JavaScript — only pypi/common.ts's access was rewritten to
m.groups!.owner for clarity since it read a single group directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(platform): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/platform/. Uses the repo's established idiom of
`match.groups?.<name>` after an optional-chained exec()/match() (see
bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts
extractSourceBranch) and `$<name>` in String.replace replacement
strings. Unused groups (markdown/HTML massaging regexes matched only
to be stripped) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group

Burns down prefer-named-capture-group violations in
lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx
dropped their unused outer wrapping group (only the inner key/value
groups were ever read) and named the key/value groups; nameMatchRegex's
remaining unused groups (protocol/user-info/port alternatives) become
non-capturing since only source/hostname/depName/version are read via
.groups. Accesses in collections.ts and roles.ts move from
lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 1)

Burns down prefer-named-capture-group violations across the first
alphabetical slice of lib/modules/manager/ (ansible through mix).
Used groups get names with accesses rewritten to match.groups!.<name>
(or $<name> in replacement strings); groups whose value is never read
become non-capturing (?:...). Two String.split() call sites
(git-submodules/extract.ts, meteor/extract.ts) keep the established
"named group still readable positionally from the split() result
array" idiom instead of restructuring the destructuring.

bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified
byte-for-byte equivalent before/after via a quick node script since
several nested groups collapsed to non-capturing at once.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 2)

Burns down prefer-named-capture-group violations across the remaining
alphabetical slice of lib/modules/manager/ (npm through terragrunt).
Same treatment as batch 1: used groups get names with accesses moved
to match.groups!.<name> or $<name> replacement strings; unused groups
(wrapping alternations, quantifier repetition groups only consumed via
.test(), or values never read from a match) become non-capturing.

terraform/extractors/others/modules.ts and terragrunt/modules.ts share
near-identical URL-parsing regexes (github/bitbucket/git/azure-devops
ref matchers) — the same set of always-unused `depth=`/`&depth=`
query-string groups is converted to non-capturing in both files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(config): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/config/.
Used groups get names with replacement strings switched from $1/$2 to
$<name>; the unused separator group in schedule-migration.ts's
afterBeforeRegex becomes non-capturing. presets/parse.ts keeps
assigning through the already-declared `repo` variable rather than
array-destructuring the exec() result, matching this file's existing
style for the other named-group regexes just above it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(util): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations across lib/util/ and
lib/logger/. Same treatment as previous batches: named groups for
values that are read (via $<name> replacement strings, .groups!.<name>,
or destructured from .groups), non-capturing groups where nothing reads
the captured value (e.g. semantic.ts's angular-commit .test()-only
regex). www-authenticate.ts's tokenizer entries each get their own
named group but keep accessing the match generically via match[1],
since a positionally-indexed named group is still readable by index.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(workers): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/workers/.
Used groups get names with $<name> replacement strings; unused
wrapper/alternation groups (e.g. semantic-commit-message.ts's optional
scope/issue wrappers, release-notes.ts's date-heading and
horizontal-rule matchers that are only probed with .search()/replaced
wholesale) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(test,tools): name capture groups for prefer-named-capture-group

Finishes the prefer-named-capture-group burndown: test/, tools/, and
vitest.config.mts. Groups whose value is read get names ($<name>
replacement strings or .groups.<name> access); groups only used via
.test()/.search() or that feed a .match(/…/g) call (whose return value
is the array of whole matches, not captured groups) become
non-capturing.

This is the last remaining slice of pre-existing violations, so the
rule (already enabled at error repo-wide) now passes with zero
findings across the whole codebase.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* fix prettier failure

* refactor(lint): use a named capture group in `v8-ignore-no-count`

New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-03 09:54:40 +00:00

236 lines
6.9 KiB
TypeScript

import { groups as presetGroups } from '../../lib/config/presets/internal/index.ts';
import { logger } from '../../lib/logger/index.ts';
import { updateFile } from '../utils/index.ts';
function jsUcfirst(string: string): string {
return string.charAt(0).toUpperCase() + string.slice(1);
}
function presetRefToLink(presetRef: string): string | null {
// Separate base name from arguments: ":followTag(typescript, next)" -> base=":followTag", argCount=2
let baseName = presetRef;
let argCount = 0;
const parenMatch = /^(?<base>[^(]+)\((?<args>.+)\)$/.exec(presetRef);
if (parenMatch) {
baseName = parenMatch.groups!.base;
argCount = parenMatch.groups!.args.split(/,\s*/).length;
}
let group: string;
const colonIdx = baseName.indexOf(':');
if (colonIdx === 0) {
group = 'default';
} else if (colonIdx > 0) {
group = baseName.slice(0, colonIdx);
} else {
return null;
}
// Reconstruct the heading text as it appears on the target page,
// where concrete args are replaced with <arg0>, <arg1>, etc.
let headingText = baseName;
if (argCount > 0) {
const argList = Array.from({ length: argCount }, (_, i) => `<arg${i}>`);
headingText += `(${argList.join(', ')})`;
}
// Slugify matching python-markdown's toc extension default behavior
const slug = headingText
.replace(/[^\w\s-]/g, '')
.trim()
.toLowerCase()
.replace(/[-\s]+/g, '-');
return `./presets-${group}.md#${slug}`;
}
function getPresetDescription(
presetRef: string,
descriptions: Map<string, string>,
): string | undefined {
// Try exact match first
let desc = descriptions.get(presetRef);
if (desc) {
return desc;
}
// Parameterized preset references like ":semanticCommitType(chore)" will be looked up as `:semanticCommitType` (which is the preset name)
const [prefix] = presetRef.split('(');
if (prefix) {
desc = descriptions.get(prefix);
if (desc) {
return desc;
}
}
return undefined;
}
function generateCodeBlock(
value: Record<string, unknown>,
descriptions: Map<string, string>,
): string {
const json = JSON.stringify(value, null, 2);
const lines = json.split('\n');
let inExtends = false;
let counter = 0;
const annotations: {
num: number;
ref: string;
link: string;
description: string | undefined;
}[] = [];
const annotatedLines = lines.map((line) => {
if (/^\s+"extends":\s*\[/.test(line)) {
inExtends = true;
return line;
}
if (inExtends) {
if (/^\s+\]/.test(line)) {
inExtends = false;
return line;
}
const match = /^(?<quoted>\s+"(?<ref>[^"]+)")(?<comma>,?)$/.exec(line);
if (match) {
const presetRef = match.groups!.ref;
const link = presetRefToLink(presetRef);
if (link) {
counter++;
const description = getPresetDescription(presetRef, descriptions);
annotations.push({ num: counter, ref: presetRef, link, description });
// note that we use a trailing `!` to strip the comment from the resulting code block
return `${match.groups!.quoted}${match.groups!.comma} // (${counter})!`;
}
}
}
return line;
});
if (annotations.length === 0) {
return `\n\`\`\`json\n${json}\n\`\`\`\n`;
}
let result = '\n``` { .json .annotate }\n';
result += annotatedLines.join('\n');
result += '\n```\n\n';
for (const ann of annotations) {
if (ann.description) {
result += `${ann.num}. [\`${ann.ref}\`](${ann.link}): ${ann.description}\n`;
} else {
result += `${ann.num}. [\`${ann.ref}\`](${ann.link})\n`;
}
}
return result;
}
function getEditUrl(name: string): string {
const url =
'https://github.com/renovatebot/renovate/edit/main/lib/config/presets/internal/';
const dataUrl = 'https://github.com/renovatebot/renovate/edit/main/lib/data/';
switch (name) {
case 'customManagers':
return `${url}custom-managers.ts`;
case 'mergeConfidence':
return `${url}merge-confidence.ts`;
case 'monorepo':
return `${dataUrl}${name}.json`;
case 'replacements':
return `${dataUrl}${name}.json`;
default:
return `${url}${name}.ts`;
}
}
/**
* @param {string} presetTitle
* @param {number} order
* @param {string} presetName
*/
function generateFrontMatter(
presetTitle: string,
order: number,
presetName: string,
): string {
return `---
date: 2017-12-07
title: ${presetTitle} Presets
categories:
- config-presets
type: Document
order: ${order}
edit_url: ${getEditUrl(presetName)}
---
`;
}
export async function generatePresets(dist: string): Promise<void> {
// Calculate the descriptions for each preset ahead-of-time, as we remove them during generation
const descriptions = new Map<string, string>();
for (const [groupName, presetConfig] of Object.entries(presetGroups)) {
for (const [presetName, value] of Object.entries(presetConfig)) {
const ref =
groupName === 'default'
? `:${presetName}`
: `${groupName}:${presetName}`;
const desc =
(value.description as string | undefined) ??
(value.overrideDescription as string | undefined) ??
(value.packageRules?.[0]?.description as string | undefined);
if (desc) {
descriptions.set(ref, desc);
}
}
}
let index = 0;
for (const [name, presetConfig] of Object.entries(presetGroups)) {
index += 1;
const formattedName = jsUcfirst(name)
.replace('Js', 'JS')
.replace(/s$/, '')
.replace(/^Config$/, 'Full Config');
const frontMatter = generateFrontMatter(formattedName, index, name);
let content = `\n`;
for (const [preset, value] of Object.entries(presetConfig)) {
let header = `\n### \`${name === 'default' ? '' : name}:${preset}\``;
let presetDescription = value.description as string;
delete value.description;
if (!presetDescription && value.overrideDescription) {
presetDescription = value.overrideDescription as string;
}
delete value.overrideDescription;
if (!presetDescription && value.packageRules?.[0].description) {
presetDescription = value.packageRules[0].description as string;
delete value.packageRules[0].description;
}
let body = '';
if (presetDescription) {
body += `\n\n${presetDescription}\n`;
} else {
logger.warn(
{ preset: `${name}:${preset}` },
'Preset has no description',
);
}
body += generateCodeBlock(value, descriptions);
body += '\n----\n';
if (body.includes('{{arg0}}')) {
header += '(`<arg0>`';
if (body.includes('{{arg1}}')) {
header += ', `<arg1>`';
if (body.includes('{{arg2}}')) {
header += ', `<arg2>`';
}
}
header += ')';
body = body.replace(/{{(?<arg>arg\d+)}}/g, '$<arg>');
}
content += header + body;
}
await updateFile(`${dist}/presets-${name}.md`, frontMatter + content);
}
}