mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-25 06:51:11 +00:00
3412de84ce
* refactor(lint): enable oxlint prefer-named-capture-group at error Numbered capture groups (m[1], $1) break silently when a regex is edited and group order shifts. Named groups (?<name>...) make intent explicit and accesses (m.groups.name) resilient to reordering. This enables the built-in eslint rule prefer-named-capture-group, surfacing 321 pre-existing unnamed-group violations across ~121 files to be burned down incrementally in follow-up commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(versioning): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations in lib/modules/versioning/. Unused capture groups (only reachable via .test() or whole-match) become non-capturing (?:...); groups whose value is read become named (?<name>...), with accesses rewritten to match.groups!.<name> (or destructured from .groups!) instead of positional match[n]/$n so a future edit that reorders groups cannot silently break the reader. Two cases needed extra care to preserve behavior: - semver/common.ts and poetry/patterns.ts split() on a regex whose capture group is relied upon by String.prototype.split to keep the separator in the output array; the group is kept capturing and named, not converted to non-capturing. - hashicorp/convertor.ts's semverRegex is only ever embedded via .source into a named `(?<version>...)` group elsewhere and never matched directly, so its internal groups are safe to make non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(datasource): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/datasource/. Same treatment as the versioning module: unused groups become non-capturing, used groups get names, and positional match[n] reads move to match.groups!.<name>. docker/ecr.ts and pypi/common.ts keep their positional destructuring (`const [, region] = ...`, `!!m &&`) working unchanged since a named capture group is still addressable by its numeric index in JavaScript — only pypi/common.ts's access was rewritten to m.groups!.owner for clarity since it read a single group directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(platform): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/platform/. Uses the repo's established idiom of `match.groups?.<name>` after an optional-chained exec()/match() (see bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts extractSourceBranch) and `$<name>` in String.replace replacement strings. Unused groups (markdown/HTML massaging regexes matched only to be stripped) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx dropped their unused outer wrapping group (only the inner key/value groups were ever read) and named the key/value groups; nameMatchRegex's remaining unused groups (protocol/user-info/port alternatives) become non-capturing since only source/hostname/depName/version are read via .groups. Accesses in collections.ts and roles.ts move from lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 1) Burns down prefer-named-capture-group violations across the first alphabetical slice of lib/modules/manager/ (ansible through mix). Used groups get names with accesses rewritten to match.groups!.<name> (or $<name> in replacement strings); groups whose value is never read become non-capturing (?:...). Two String.split() call sites (git-submodules/extract.ts, meteor/extract.ts) keep the established "named group still readable positionally from the split() result array" idiom instead of restructuring the destructuring. bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified byte-for-byte equivalent before/after via a quick node script since several nested groups collapsed to non-capturing at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 2) Burns down prefer-named-capture-group violations across the remaining alphabetical slice of lib/modules/manager/ (npm through terragrunt). Same treatment as batch 1: used groups get names with accesses moved to match.groups!.<name> or $<name> replacement strings; unused groups (wrapping alternations, quantifier repetition groups only consumed via .test(), or values never read from a match) become non-capturing. terraform/extractors/others/modules.ts and terragrunt/modules.ts share near-identical URL-parsing regexes (github/bitbucket/git/azure-devops ref matchers) — the same set of always-unused `depth=`/`&depth=` query-string groups is converted to non-capturing in both files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(config): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/config/. Used groups get names with replacement strings switched from $1/$2 to $<name>; the unused separator group in schedule-migration.ts's afterBeforeRegex becomes non-capturing. presets/parse.ts keeps assigning through the already-declared `repo` variable rather than array-destructuring the exec() result, matching this file's existing style for the other named-group regexes just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(util): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations across lib/util/ and lib/logger/. Same treatment as previous batches: named groups for values that are read (via $<name> replacement strings, .groups!.<name>, or destructured from .groups), non-capturing groups where nothing reads the captured value (e.g. semantic.ts's angular-commit .test()-only regex). www-authenticate.ts's tokenizer entries each get their own named group but keep accessing the match generically via match[1], since a positionally-indexed named group is still readable by index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(workers): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/workers/. Used groups get names with $<name> replacement strings; unused wrapper/alternation groups (e.g. semantic-commit-message.ts's optional scope/issue wrappers, release-notes.ts's date-heading and horizontal-rule matchers that are only probed with .search()/replaced wholesale) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(test,tools): name capture groups for prefer-named-capture-group Finishes the prefer-named-capture-group burndown: test/, tools/, and vitest.config.mts. Groups whose value is read get names ($<name> replacement strings or .groups.<name> access); groups only used via .test()/.search() or that feed a .match(/…/g) call (whose return value is the array of whole matches, not captured groups) become non-capturing. This is the last remaining slice of pre-existing violations, so the rule (already enabled at error repo-wide) now passes with zero findings across the whole codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * fix prettier failure * refactor(lint): use a named capture group in `v8-ignore-no-count` New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
152 lines
5.3 KiB
TypeScript
152 lines
5.3 KiB
TypeScript
import { Command } from 'commander';
|
|
import { getOptions } from '../../../../config/options/index.ts';
|
|
import type { AllConfig } from '../../../../config/types.ts';
|
|
import { pkg } from '../../../../expose.ts';
|
|
import { logger } from '../../../../logger/index.ts';
|
|
import { regEx } from '../../../../util/regex.ts';
|
|
import { coersions } from './coersions.ts';
|
|
import type { ParseConfigOptions } from './types.ts';
|
|
|
|
export function getCliName(option: ParseConfigOptions): string {
|
|
if (option.cli === false) {
|
|
return '';
|
|
}
|
|
const nameWithHyphens = option.name.replace(
|
|
regEx(/(?<upper>[A-Z])/g),
|
|
'-$<upper>',
|
|
);
|
|
return `--${nameWithHyphens.toLowerCase()}`;
|
|
}
|
|
|
|
function createProgram(): Command<[string[]]> {
|
|
const options = getOptions();
|
|
|
|
let program = new Command().arguments('[repositories...]');
|
|
|
|
options.forEach((option) => {
|
|
if (option.cli !== false) {
|
|
const param = `<${option.type}>`.replace('<boolean>', '[boolean]');
|
|
const optionString = `${getCliName(option)} ${param}`;
|
|
program = program.option(
|
|
optionString,
|
|
option.description,
|
|
coersions[option.type],
|
|
);
|
|
}
|
|
});
|
|
|
|
/* oxlint-disable no-console -- intentional: CLI help output */
|
|
/* istanbul ignore next */
|
|
function helpConsole(): void {
|
|
console.log(' Examples:');
|
|
console.log('');
|
|
console.log(' $ renovate --token 123test singapore/lint-condo');
|
|
console.log(
|
|
' $ LOG_LEVEL=debug renovate --labels=renovate,dependency --ignore-unstable=false singapore/lint-condo',
|
|
);
|
|
console.log(' $ renovate singapore/lint-condo singapore/package-test');
|
|
console.log(
|
|
` $ renovate singapore/lint-condo --onboarding-config='{"extends":["config:recommended"]}'`,
|
|
);
|
|
/* oxlint-enable no-console */
|
|
}
|
|
|
|
return program
|
|
.version(pkg.version, '-v, --version')
|
|
.on('--help', helpConsole);
|
|
}
|
|
|
|
/**
|
|
* Massage migrated configuration keys.
|
|
* This must run before any Commander parse call so that
|
|
* deprecated/bare flags like `--dry-run` (no value) are rewritten
|
|
* before Commander tries to consume them.
|
|
*/
|
|
function migrateArgs(input: string[]): string[] {
|
|
return input
|
|
.map((a) =>
|
|
a
|
|
.replace(
|
|
'--allow-post-upgrade-command-templating',
|
|
'--allow-command-templating',
|
|
)
|
|
.replace('--allowed-post-upgrade-commands', '--allowed-commands')
|
|
.replace('--endpoints=', '--host-rules=')
|
|
.replace('--expose-env=true', '--trust-level=high')
|
|
.replace('--expose-env', '--trust-level=high')
|
|
.replace('--renovate-fork', '--include-forks')
|
|
.replace('"platform":"', '"hostType":"')
|
|
.replace('"endpoint":"', '"matchHost":"')
|
|
.replace('"host":"', '"matchHost":"')
|
|
.replace('--azure-auto-complete', '--platform-automerge') // migrate: azureAutoComplete
|
|
.replace('--git-lab-automerge', '--platform-automerge') // migrate: gitLabAutomerge
|
|
.replace(regEx(/^--dry-run$/), '--dry-run=true')
|
|
.replace(regEx(/^--require-config$/), '--require-config=true')
|
|
.replace('--aliases', '--registry-aliases')
|
|
.replace('--include-forks=true', '--fork-processing=enabled')
|
|
.replace('--include-forks', '--fork-processing=enabled')
|
|
.replace('--recreate-closed=false', '--recreate-when=auto')
|
|
.replace('--recreate-closed=true', '--recreate-when=always')
|
|
.replace('--recreate-closed', '--recreate-when=always'),
|
|
)
|
|
.filter((a) => !a.startsWith('--git-fs'));
|
|
}
|
|
|
|
export function parseEarlyFlags(input: string[] = process.argv): void {
|
|
createProgram()
|
|
.allowUnknownOption()
|
|
.allowExcessArguments()
|
|
.parse(migrateArgs(input));
|
|
}
|
|
|
|
export function getConfig(input: string[]): AllConfig {
|
|
const argv = migrateArgs(input);
|
|
const options = getOptions();
|
|
|
|
const config: Record<string, any> = {};
|
|
|
|
createProgram()
|
|
.action((repositories: string[], opts: Record<string, unknown>) => {
|
|
if (repositories?.length) {
|
|
config.repositories = repositories;
|
|
}
|
|
|
|
for (const option of options) {
|
|
if (option.cli !== false && opts[option.name] !== undefined) {
|
|
config[option.name] = opts[option.name];
|
|
if (option.name === 'dryRun') {
|
|
if (config[option.name] === 'true') {
|
|
logger.warn(
|
|
'cli config dryRun property has been changed to full',
|
|
);
|
|
config[option.name] = 'full';
|
|
} else if (config[option.name] === 'false') {
|
|
logger.warn(
|
|
'cli config dryRun property has been changed to null',
|
|
);
|
|
config[option.name] = null;
|
|
} else if (config[option.name] === 'null') {
|
|
config[option.name] = null;
|
|
}
|
|
}
|
|
if (option.name === 'requireConfig') {
|
|
if (config[option.name] === 'true') {
|
|
logger.warn(
|
|
'cli config requireConfig property has been changed to required',
|
|
);
|
|
config[option.name] = 'required';
|
|
} else if (config[option.name] === 'false') {
|
|
logger.warn(
|
|
'cli config requireConfig property has been changed to optional',
|
|
);
|
|
config[option.name] = 'optional';
|
|
}
|
|
}
|
|
}
|
|
}
|
|
})
|
|
.parse(argv);
|
|
|
|
return config;
|
|
}
|