mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-24 14:34:21 +00:00
16ef1715e9
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules Flag ad-hoc type checks that have @sindresorhus/is equivalents: - .filter(Boolean) -> .filter(isTruthy) - typeof x === 'string' -> isString(x) - x === null || x === undefined -> isNullOrUndefined(x) (and negation) The typeof x === 'object' shape lives in a separate suggestion-only rule (renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject() are not drop-in equivalents: null, arrays and functions behave differently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: fix renovate/prefer-is-helpers violations Replace ad-hoc type checks with @sindresorhus/is helpers across lib/: - 13x .filter(Boolean) -> .filter(isTruthy) - 36x typeof x ==/!== 'string' -> isString(x) / !isString(x) - 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation) Promote renovate/prefer-is-helpers to error now that the codebase is clean. renovate/prefer-is-object stays at warn: its 15 remaining sites guard parsed YAML/JSON or unknown values where isObject()/isPlainObject() are not provably equivalent (null/array/function semantics). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: enforce renovate/prefer-is-object at error level Resolve the 15 remaining warnings and raise the rule from warn to error: - Migrate 10 sites to isObject() where the guarded value provably cannot be a function (parsed YAML/JSON, typed exec command arguments, or test-controlled fixtures): helm-values, woodpecker, bun, pre-commit managers, exec utils, file package cache, and the github http spec. In the bun manager this also fixes a latent crash where a null `workspaces` value would throw on the `in` operator. - Keep 5 sites as reasoned oxlint-disable comments where excluding functions is load-bearing: the byte-exact fingerprint canonicalizer (2), the circularity walker, the zod result guard, and the generic hasKey helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
37 lines
1000 B
TypeScript
37 lines
1000 B
TypeScript
import { isString } from '@sindresorhus/is';
|
|
import { DateTime } from 'luxon';
|
|
|
|
const ONE_MINUTE_MS = 60 * 1000;
|
|
|
|
export function getElapsedDays(timestamp: string, floor = true): number {
|
|
const currentVersionTimestampDate = DateTime.fromISO(timestamp);
|
|
const now = DateTime.now();
|
|
const diffInDays = now.diff(currentVersionTimestampDate, 'days').as('days');
|
|
if (floor) {
|
|
return Math.floor(diffInDays);
|
|
}
|
|
|
|
return diffInDays;
|
|
}
|
|
|
|
export function getElapsedMinutes(date: Date): number {
|
|
return Math.floor((new Date().getTime() - date.getTime()) / ONE_MINUTE_MS);
|
|
}
|
|
|
|
export function getElapsedHours(date: Date | string): number {
|
|
const pastDate = isString(date)
|
|
? DateTime.fromISO(date)
|
|
: DateTime.fromJSDate(date);
|
|
|
|
if (!pastDate.isValid) {
|
|
return 0;
|
|
}
|
|
|
|
const diff = DateTime.now().diff(pastDate, 'hours');
|
|
return Math.floor(diff.hours);
|
|
}
|
|
|
|
export function getElapsedMs(timestamp: string): number {
|
|
return new Date().getTime() - new Date(timestamp).getTime();
|
|
}
|