Files
Sebastian Poxhofer 4b4d14ec00 feat(manager): pass extracted constraints to updateArtifacts (#45826)
* feat(manager): pass extracted constraints to updateArtifacts

`extractedConstraints` were collected during extraction but only ever read
by `fetch.ts` for the lookup. At artifact time every manager had to derive
the same tool constraints a second time, and when the updated package file
no longer carried the constraint there was nothing to fall back to.

`generateBranchConfig()` now merges the `extractedConstraints` of all
upgrades of a branch onto the branch config, which reaches `updateArtifacts()`
through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares
the field and documents what it contains.

The new `resolveToolConstraint()` helper implements the ladder once:
user `constraints` > an optional artifact-time derivation > the extracted
value. The derivation is ranked above the extracted value on purpose: it
reads the package files as the branch changed them, so poetry (python is an
updatable dependency there), composer, pipenv (`pipenv` can be a dev
package) and pep621 (`requires-python` is an updatable dependency) would
otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and
composer are migrated to the helper and keep their derivation.

Behaviour change: these managers now use the extract-time constraint as a
last resort instead of running unconstrained, for example on lock file
maintenance where pipenv deletes `Pipfile.lock` before deriving.

`execute-post-upgrade-commands.ts` is unaffected: it reads
`upgrade.constraints` per upgrade, and the extracted values are kept in a
separate field rather than folded into `constraints`, so post-upgrade task
tool constraints still come from user config only.

Not migrated, because their constraints are never extracted, so the
fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`),
pep621 uv (`required-version`) and npm's node ladder, whose last step
already reads `package.json` engines.

* refactor(manager): resolve tool constraints through resolveToolConstraint()

Every manager now obtains the constraint of a tool it runs through
`resolveToolConstraint()` instead of reading `config.constraints` itself, so
the precedence "user config, then a value derived from the updated files, then
the constraints collected during extraction" applies everywhere. The helper
treats an empty string as not set at every step and accepts the
`PostUpdateConfig` shape, whose `constraints` may be `null`.

Behaviour changes that go beyond the new fallback to extracted constraints:

- `mix` applies its hardcoded erlang default only after the extracted
  constraint, so an erlang version collected at extraction can win over it.
- `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm
  constraint; `generateHelmEnvs()` takes that value instead of the config.
- `npm` (yarn): an upgrade of yarn without a new value now consults the user
  constraint before deriving one from package.json or the lock file.
- The "Using <tool> constraint from config" debug lines in bundler, composer,
  copier and pip-compile are gone, as the helper is the only reader of the
  config now.

Helpers that read the config synchronously became async: bundler
`getBundlerConstraint()`, copier `getPythonVersionConstraint()` and
`getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and
`getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and
`getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer
`getPhpConstraint()` is removed.

Each converted manager has a test showing the extracted constraint reaching
the executed tool, and, where a derive callback exists, that the derived value
still wins over it.

* refactor(linters): add prefer-resolve-tool-constraint rule

Reports member reads and destructuring of `constraints` and
`extractedConstraints` from a manager config in `lib/modules/manager/**`, so
that tool constraints are resolved through `resolveToolConstraint()` in
`lib/modules/manager/util.ts` only. Writes and the same properties on package
files, which extraction has to populate, are not reported. The helper itself
and spec files are exempt in `.oxlintrc.json`.

* refactor(manager): inline thin resolveToolConstraint wrappers

Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint /
getUvVersionConstraint helpers, which only forwarded to
resolveToolConstraint(). Callers now call it directly.

* docs(development): note lock file maintenance in tool constraints section

* refactor(manager): address review on tool constraint resolution

composer only runs extractConstraints() when a user constraint is missing,
via Lazy. UpdateArtifactsConfig no longer re-declares constraints and
extractedConstraints, which ToolConstraintsConfig already provides.
2026-09-14 11:09:07 +00:00

258 lines
7.5 KiB
TypeScript

import { lang, query as q } from '@renovatebot/good-enough-parser';
import { isTruthy } from '@sindresorhus/is';
import { quote } from 'shlex';
import upath from 'upath';
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
import { logger } from '../../../logger/index.ts';
import {
exec,
getToolSettingsOptions,
gradleJvmArg,
} from '../../../util/exec/index.ts';
import type { ExecOptions } from '../../../util/exec/types.ts';
import {
localPathExists,
readLocalFile,
writeLocalFile,
} from '../../../util/fs/index.ts';
import { getRepoStatus } from '../../../util/git/index.ts';
import type { StatusResult } from '../../../util/git/types.ts';
import { Http } from '../../../util/http/index.ts';
import { newlineRegex, regEx } from '../../../util/regex.ts';
import { replaceAt } from '../../../util/string.ts';
import { isGradleExecutionAllowed } from '../gradle/artifacts.ts';
import { updateArtifacts as gradleUpdateArtifacts } from '../gradle/index.ts';
import type {
UpdateArtifact,
UpdateArtifactsConfig,
UpdateArtifactsResult,
} from '../types.ts';
import { resolveToolConstraint } from '../util.ts';
import {
extraEnv,
getJavaConstraint,
gradleWrapperFileName,
prepareGradleCommand,
} from './utils.ts';
const http = new Http('gradle-wrapper');
const groovy = lang.createLang('groovy');
type Ctx = string[];
async function addIfUpdated(
status: StatusResult,
fileProjectPath: string,
): Promise<UpdateArtifactsResult | null> {
if (status.modified.includes(fileProjectPath)) {
return {
file: {
type: 'addition',
path: fileProjectPath,
contents: await readLocalFile(fileProjectPath),
},
};
}
return null;
}
function getDistributionUrl(newPackageFileContent: string): string | null {
const distributionUrlLine = newPackageFileContent
.split(newlineRegex)
.find((line) => line.startsWith('distributionUrl='));
if (distributionUrlLine) {
return distributionUrlLine
.replace('distributionUrl=', '')
.replace('https\\:', 'https:');
}
return null;
}
async function getDistributionChecksum(url: string): Promise<string> {
const { body } = await http.getText(`${url}.sha256`);
return body;
}
export async function updateBuildFile(
localGradleDir: string,
wrapperProperties: Record<string, string | undefined | null>,
): Promise<string> {
let buildFileName = upath.join(localGradleDir, 'build.gradle');
if (!(await localPathExists(buildFileName))) {
buildFileName = upath.join(localGradleDir, 'build.gradle.kts');
}
const buildFileContent = await readLocalFile(buildFileName, 'utf8');
if (!buildFileContent) {
logger.debug('build.gradle or build.gradle.kts not found');
return buildFileName;
}
let buildFileUpdated = buildFileContent;
for (const [propertyName, newValue] of Object.entries(wrapperProperties)) {
if (!newValue) {
continue;
}
const query = q.tree({
type: 'wrapped-tree',
maxDepth: 1,
search: q
.sym<Ctx>(propertyName)
.op('=')
.str((ctx, { value, offset }) => {
buildFileUpdated = replaceAt(
buildFileUpdated,
offset,
value,
newValue,
);
return ctx;
}),
});
groovy.query(buildFileUpdated, query, []);
}
await writeLocalFile(buildFileName, buildFileUpdated);
return buildFileName;
}
export async function updateLockFiles(
buildFileName: string,
config: UpdateArtifactsConfig,
): Promise<UpdateArtifactsResult[] | null> {
const buildFileContent = await readLocalFile(buildFileName, 'utf8');
if (!buildFileContent) {
logger.debug('build.gradle or build.gradle.kts not found');
return null;
}
return await gradleUpdateArtifacts({
packageFileName: buildFileName,
updatedDeps: [],
newPackageFileContent: buildFileContent,
config,
});
}
export async function updateArtifacts({
packageFileName,
newPackageFileContent,
updatedDeps,
config,
}: UpdateArtifact): Promise<UpdateArtifactsResult[] | null> {
try {
logger.debug({ updatedDeps }, 'gradle-wrapper.updateArtifacts()');
const localGradleDir = upath.join(upath.dirname(packageFileName), '../../');
const gradlewFile = upath.join(localGradleDir, gradleWrapperFileName());
let cmd = await prepareGradleCommand(gradlewFile);
if (!cmd) {
logger.info('No gradlew found - skipping Artifacts update');
return null;
}
if (!isGradleExecutionAllowed(gradlewFile)) {
logger.trace(
'Not allowed to execute gradle due to allowedUnsafeExecutions - aborting update',
);
return null;
}
// Limit the Gradle daemon Java heap memory size to prevent OOM errors
// leading to Renovate kernel-OOMs and timeouts. See #39558
cmd += gradleJvmArg(getToolSettingsOptions(config.toolSettings));
cmd += ' :wrapper';
let checksum: string | null = null;
const distributionUrl = getDistributionUrl(newPackageFileContent);
if (distributionUrl) {
cmd += ` --gradle-distribution-url ${quote(distributionUrl)}`;
if (newPackageFileContent.includes('distributionSha256Sum=')) {
//update checksum in case of distributionSha256Sum in properties then run wrapper
checksum = await getDistributionChecksum(distributionUrl);
await writeLocalFile(
packageFileName,
newPackageFileContent.replace(
regEx(/distributionSha256Sum=.*/),
`distributionSha256Sum=${checksum}`,
),
);
cmd += ` --gradle-distribution-sha256-sum ${quote(checksum)}`;
}
} else {
cmd += ` --gradle-version ${quote(config.newValue!)}`;
}
logger.debug(`Updating gradle wrapper: "${cmd}"`);
const execOptions: ExecOptions = {
cwdFile: gradlewFile,
docker: {},
extraEnv,
toolConstraints: [
{
toolName: 'java',
constraint: await resolveToolConstraint(config, 'java', () =>
getJavaConstraint(config.currentValue, gradlewFile),
),
},
],
};
try {
await exec(cmd, execOptions);
} catch (err) {
// istanbul ignore if
if (err.message === TEMPORARY_ERROR) {
throw err;
}
logger.warn(
{ err },
'Error executing gradle wrapper update command. This may not necessarily be a blocker to the update, so please verify with the gradle wrapper output logs.',
);
}
const buildFileName = await updateBuildFile(localGradleDir, {
gradleVersion: config.newValue,
distributionSha256Sum: checksum,
distributionUrl,
});
const lockFiles = await updateLockFiles(buildFileName, config);
const status = await getRepoStatus();
const artifactFileNames = [
packageFileName,
buildFileName,
...['gradle/wrapper/gradle-wrapper.jar', 'gradlew', 'gradlew.bat'].map(
(filename) => upath.join(localGradleDir, filename),
),
];
const updateArtifactsResult = (
await Promise.all(
artifactFileNames.map((fileProjectPath) =>
addIfUpdated(status, fileProjectPath),
),
)
).filter(isTruthy);
if (lockFiles) {
updateArtifactsResult.push(...lockFiles);
}
logger.debug(
{ files: updateArtifactsResult.map((r) => r.file?.path) },
`Returning updated gradle-wrapper files`,
);
return updateArtifactsResult;
} catch (err) {
logger.debug({ err }, 'Error setting new Gradle Wrapper release value');
return [
{
artifactError: {
fileName: packageFileName,
stderr: err.message,
},
},
];
}
}