mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-25 15:01:49 +00:00
Sebastian Poxhofer
4220c0fe36
* refactor(manager): share the .npmrc host-rule wrapper between bun, deno and npm Adds `withNpmrcHostRules()` to the npm manager utils: it injects the host-rule lines into a directory's `.npmrc`, runs the callback, and restores the original `.npmrc` from a `finally` block. bun, deno, the corepack `updateArtifacts()` and the three lock file loops in `post-update/index.ts` now share it instead of repeating getNpmrcContent / updateNpmrcContent / resetNpmrcContent. Adds `readUpdatedBinaryLockFile()` to the shared manager utils for the `Buffer.compare` plus file-addition block that bun and deno both carried. Behaviour changes: - bun and deno now restore `.npmrc` when `exec()` throws. The reset previously ran only after a successful install, so a failed lock file update left the injected registry credentials in the working tree. Covered by "restores .npmrc when the install fails" in `bun/artifacts.spec.ts` and `deno/artifacts.spec.ts`. - The npm, yarn and pnpm loops in `post-update/index.ts` now restore `.npmrc` when the loop body throws an `ExternalHostError`, for the same reason. - deno reads `config.isLockFileMaintenance` instead of deriving the flag from `config.updateType === 'lockFileMaintenance'`. Grouped branches overwrite `updateType` while `isLockFileMaintenance` is set explicitly, so the flag is the reliable source. The deno specs were updated to set it. * refactor(manager): let updateLockFile() compare binary lock files A Buffer as the existing content makes the skeleton read, compare and return the new lock file as bytes, so bun and deno use it instead of a separate readUpdatedBinaryLockFile() helper. * refactor(manager/devbox): update the lock file through updateLockFile() devbox kept the same Buffer compare as bun and deno; the trace log before returning the lock file goes away with it. * fix(manager/devbox): type the command list explicitly The list is now only read inside the run() closure, where TypeScript cannot resolve an evolving array type, so tsc reported an implicit any.
93 lines
2.9 KiB
TypeScript
93 lines
2.9 KiB
TypeScript
import { isEmptyArray } from '@sindresorhus/is';
|
|
import upath from 'upath';
|
|
import { GlobalConfig } from '../../../config/global.ts';
|
|
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { exec } from '../../../util/exec/index.ts';
|
|
import type { ExecOptions } from '../../../util/exec/types.ts';
|
|
import { readLocalFile } from '../../../util/fs/index.ts';
|
|
import { processHostRules } from '../npm/post-update/rules.ts';
|
|
import { withNpmrcHostRules } from '../npm/utils.ts';
|
|
import type { UpdateArtifact, UpdateArtifactsResult } from '../types.ts';
|
|
import {
|
|
artifactErrorResult,
|
|
resolveToolConstraint,
|
|
updateLockFile,
|
|
} from '../util.ts';
|
|
|
|
export async function updateArtifacts(
|
|
updateArtifact: UpdateArtifact,
|
|
): Promise<UpdateArtifactsResult[] | null> {
|
|
const { packageFileName, updatedDeps, newPackageFileContent, config } =
|
|
updateArtifact;
|
|
logger.debug(`bun.updateArtifacts(${packageFileName})`);
|
|
const { isLockFileMaintenance } = config;
|
|
|
|
if (isEmptyArray(updatedDeps) && !isLockFileMaintenance) {
|
|
logger.debug('No updated bun deps - returning null');
|
|
return null;
|
|
}
|
|
|
|
// Find the first bun dependency in order to handle mixed manager updates,
|
|
// eventually falling back to the first lock file from config.
|
|
const lockFileName =
|
|
updatedDeps.find((dep) => dep.manager === 'bun')?.lockFiles?.[0] ??
|
|
config.lockFiles?.[0];
|
|
|
|
if (!lockFileName) {
|
|
logger.debug(`bun: No lock file found`);
|
|
return null;
|
|
}
|
|
|
|
const oldLockFileContent = await readLocalFile(lockFileName);
|
|
if (!oldLockFileContent) {
|
|
logger.debug(`No ${lockFileName} found`);
|
|
return null;
|
|
}
|
|
|
|
const pkgFileDir = upath.dirname(packageFileName);
|
|
const { additionalNpmrcContent } = processHostRules();
|
|
|
|
try {
|
|
return await withNpmrcHostRules(
|
|
pkgFileDir,
|
|
additionalNpmrcContent,
|
|
async () => {
|
|
let cmd = 'bun install';
|
|
|
|
if (!GlobalConfig.get('allowScripts') || config.ignoreScripts) {
|
|
cmd += ' --ignore-scripts';
|
|
}
|
|
|
|
const execOptions: ExecOptions = {
|
|
cwdFile: lockFileName,
|
|
docker: {},
|
|
toolConstraints: [
|
|
{
|
|
toolName: 'bun',
|
|
constraint: await resolveToolConstraint(config, 'bun'),
|
|
},
|
|
],
|
|
};
|
|
|
|
return await updateLockFile({
|
|
lockFileName,
|
|
existingLockFileContent: oldLockFileContent,
|
|
packageFile: {
|
|
path: packageFileName,
|
|
contents: newPackageFileContent,
|
|
},
|
|
deleteLockFile: isLockFileMaintenance,
|
|
run: () => exec(cmd, execOptions),
|
|
});
|
|
},
|
|
);
|
|
} catch (err) {
|
|
if (err.message === TEMPORARY_ERROR) {
|
|
throw err;
|
|
}
|
|
logger.warn({ lockfile: lockFileName, err }, `Failed to update lock file`);
|
|
return artifactErrorResult(lockFileName, err);
|
|
}
|
|
}
|