Files
Sebastian Poxhofer 16ef1715e9 refactor(linters): add rules for @sindresorhus/is helpers (#45229)
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules

Flag ad-hoc type checks that have @sindresorhus/is equivalents:
- .filter(Boolean) -> .filter(isTruthy)
- typeof x === 'string' -> isString(x)
- x === null || x === undefined -> isNullOrUndefined(x) (and negation)

The typeof x === 'object' shape lives in a separate suggestion-only rule
(renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject()
are not drop-in equivalents: null, arrays and functions behave differently.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: fix renovate/prefer-is-helpers violations

Replace ad-hoc type checks with @sindresorhus/is helpers across lib/:
- 13x .filter(Boolean) -> .filter(isTruthy)
- 36x typeof x ==/!== 'string' -> isString(x) / !isString(x)
- 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation)

Promote renovate/prefer-is-helpers to error now that the codebase is clean.
renovate/prefer-is-object stays at warn: its 15 remaining sites guard
parsed YAML/JSON or unknown values where isObject()/isPlainObject() are
not provably equivalent (null/array/function semantics).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: enforce renovate/prefer-is-object at error level

Resolve the 15 remaining warnings and raise the rule from warn to error:

- Migrate 10 sites to isObject() where the guarded value provably cannot
  be a function (parsed YAML/JSON, typed exec command arguments, or
  test-controlled fixtures): helm-values, woodpecker, bun, pre-commit
  managers, exec utils, file package cache, and the github http spec.
  In the bun manager this also fixes a latent crash where a null
  `workspaces` value would throw on the `in` operator.
- Keep 5 sites as reasoned oxlint-disable comments where excluding
  functions is load-bearing: the byte-exact fingerprint canonicalizer
  (2), the circularity walker, the zod result guard, and the generic
  hasKey helper.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-13 14:22:03 +00:00

64 lines
2.2 KiB
TypeScript

import { isNullOrUndefined } from '@sindresorhus/is';
import { logger } from '../../../logger/index.ts';
import type { UpdateDependencyConfig } from '../types.ts';
/** For external .properties files: updateDependency is necessary because extractPackageFile can't reconstruct dep metadata from a .properties file alone */
export function updateDependency({
fileContent,
upgrade,
}: UpdateDependencyConfig): string | null {
const { depName, currentValue, newValue, fileReplacePosition } = upgrade;
if (isNullOrUndefined(fileReplacePosition)) {
logger.debug({ depName }, 'No fileReplacePosition for ant dependency');
return null;
}
const leftPart = fileContent.slice(0, fileReplacePosition);
const rightPart = fileContent.slice(fileReplacePosition);
// Find the end of the value (closing quote or end of line for .properties files)
let endIndex: number;
const quoteChar = leftPart.at(-1);
if (quoteChar === '"' || quoteChar === "'") {
endIndex = rightPart.indexOf(quoteChar);
} else {
// Could be a .properties file or a substring inside a coords attribute
const newlineIndex = rightPart.indexOf('\n');
const lineEnd = newlineIndex === -1 ? rightPart.length : newlineIndex;
// Check for closing quote before newline (indicates coords attribute)
const nearestQuote = [
rightPart.indexOf('"'),
rightPart.indexOf("'"),
].filter((i) => i !== -1 && i < lineEnd);
if (nearestQuote.length > 0) {
// Inside a quoted attribute (coords) - version ends at : or closing quote
const quoteEnd = Math.min(...nearestQuote);
const colonIndex = rightPart.indexOf(':');
endIndex =
colonIndex !== -1 && colonIndex < quoteEnd ? colonIndex : quoteEnd;
} else {
// .properties file: value ends at newline or EOF
endIndex = lineEnd;
}
}
const currentFound = rightPart.slice(0, endIndex);
if (currentFound === newValue) {
return fileContent;
}
if (currentFound === currentValue || upgrade.sharedVariableName) {
return `${leftPart}${newValue}${rightPart.slice(endIndex)}`;
}
logger.debug(
{ depName, currentFound, currentValue, newValue },
'ant: unexpected value at fileReplacePosition',
);
return null;
}