Files
Michael Kriese f64ec3975a fix(cache): build all cache keys with a shared helper (#46811)
* refactor(datasource): separate registry URLs in cache keys with a colon

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
Co-Authored-By: Claude Sonnet 5.5 <michael.kriese+claude-code@mend.io>

* fix(datasource/go): separate the remaining cache key parts with a colon

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>

* refactor(datasource): build cache keys with a shared colon-joining helper

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>

* refactor: build all cache keys with buildCacheKey

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>

* refactor(http): keep GET package cache keys as the bare URL

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>

* refactor(cache): extend cache key helper to memory cache keys

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>

* refactor(datasource/go): prefix the goproxy cache keys with their purpose

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>

---------

Co-authored-by: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
2026-10-10 10:46:09 +00:00

281 lines
7.7 KiB
TypeScript

import { verify as verifySignature } from 'node:crypto';
import { promisify } from 'node:util';
import { gunzip } from 'node:zlib';
import { logger } from '../../../logger/index.ts';
import { buildCacheKey } from '../../../util/cache/package/key.ts';
import { withCache } from '../../../util/cache/package/with-cache.ts';
import { memCacheProvider } from '../../../util/http/cache/memory-http-cache-provider.ts';
import { joinUrlParts, parseUrl } from '../../../util/url.ts';
import * as hexVersioning from '../../versioning/hex/index.ts';
import { Datasource } from '../datasource.ts';
import type { GetReleasesConfig, Release, ReleaseResult } from '../types.ts';
import { HexRelease } from './schema.ts';
import { Package } from './v2/package.ts';
import { Signed } from './v2/signed.ts';
const defaultRegistryUrl = 'https://hex.pm';
const defaultHexRepositoryUrl = 'https://repo.hex.pm';
const defaultHexRepositoryName = 'hexpm';
const defaultHexRepositoryHostname = parseUrl(
defaultHexRepositoryUrl,
)?.hostname;
const defaultHexPublicKey = `-----BEGIN PUBLIC KEY-----
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEApqREcFDt5vV21JVe2QNB
Edvzk6w36aNFhVGWN5toNJRjRJ6m4hIuG4KaXtDWVLjnvct6MYMfqhC79HAGwyF+
IqR6Q6a5bbFSsImgBJwz1oadoVKD6ZNetAuCIK84cjMrEFRkELtEIPNHblCzUkkM
3rS9+DPlnfG8hBvGi6tvQIuZmXGCxF/73hU0/MyGhbmEjIKRtG6b0sJYKelRLTPW
XgK7s5pESgiwf2YC/2MGDXjAJfpfCd0RpLdvd4eRiXtVlE9qO9bND94E7PgQ/xqZ
J1i2xWFndWa6nfFnRxZmCStCOZWYYPlaxr+FZceFbpMwzTNs4g3d4tLNUcbKAIH4
0wIDAQAB
-----END PUBLIC KEY-----`;
const gunzipAsync = promisify(gunzip);
interface ParsedPackageName {
hexPackageName: string;
organizationName: string | null;
organizationUrlPrefix: string;
}
function parsePackageName(packageName: string): ParsedPackageName {
const [hexPackageName, organizationName] = packageName.split(':');
const organizationUrlPrefix = organizationName
? `repos/${organizationName}/`
: '';
return {
hexPackageName,
organizationName: organizationName ?? null,
organizationUrlPrefix,
};
}
function getExpectedRepositoryName(
registryUrl: string,
organizationName: string | null,
): string | null {
if (organizationName) {
return organizationName;
}
const hostname = parseUrl(registryUrl)?.hostname;
return hostname === defaultHexRepositoryHostname
? defaultHexRepositoryName
: null;
}
function isSignedPayloadValid(
signed: Signed,
publicKey: string,
packageName: string,
): boolean {
if (!signed.signature?.length) {
logger.warn({ packageName }, 'hex: missing signature in V2 response');
return false;
}
try {
return verifySignature(
'RSA-SHA512',
signed.payload,
publicKey,
signed.signature,
);
} catch (err) {
logger.warn({ err, packageName }, 'hex: invalid public key or signature');
return false;
}
}
function mapV2Releases(pkg: Package): Release[] {
const releases: Release[] = [];
for (const release of pkg.releases) {
if (!release.version) {
continue;
}
releases.push({
version: release.version,
...(release.retired && { isDeprecated: true }),
});
}
return releases;
}
export class HexDatasource extends Datasource {
static readonly id = 'hex';
constructor() {
super(HexDatasource.id);
}
override getDefaultRegistryUrls(_packageName: string): string[] {
return [defaultRegistryUrl];
}
override readonly defaultVersioning = hexVersioning.id;
override readonly releaseTimestampSupport = true;
override readonly releaseTimestampNote =
'The release timestamp is determined the `inserted_at` field in the results.';
override readonly sourceUrlSupport = 'package';
override readonly sourceUrlNote =
'The source URL is determined from the `Github` field in the results.';
private async getReleasesViaJsonApi({
packageName,
registryUrl,
}: GetReleasesConfig): Promise<ReleaseResult | null> {
/* v8 ignore if -- should never happen */
if (!registryUrl) {
return null;
}
const { hexPackageName, organizationUrlPrefix } =
parsePackageName(packageName);
const hexUrl = joinUrlParts(
registryUrl,
`/api/${organizationUrlPrefix}packages/${hexPackageName}`,
);
return this.fetchJsonOrNull(hexUrl, HexRelease);
}
private async getReleasesViaV2Protocol({
packageName,
registryUrl,
}: GetReleasesConfig): Promise<ReleaseResult | null> {
/* v8 ignore if -- should never happen */
if (!registryUrl) {
return null;
}
const { hexPackageName, organizationName, organizationUrlPrefix } =
parsePackageName(packageName);
const url = joinUrlParts(
registryUrl,
`/${organizationUrlPrefix}packages/${hexPackageName}`,
);
const { body } = await this.http.getBuffer(url);
const decompressed = await gunzipAsync(body);
const signed = Signed.decode(decompressed);
const publicKey = await this.getPublicKey(registryUrl);
if (publicKey && !isSignedPayloadValid(signed, publicKey, packageName)) {
return null;
}
const pkg = Package.decode(signed.payload);
if (pkg.name !== hexPackageName) {
logger.warn(
{
packageName,
registryUrl,
expectedPackageName: hexPackageName,
actualPackageName: pkg.name,
},
'hex: V2 package name mismatch',
);
return null;
}
const expectedRepositoryName = getExpectedRepositoryName(
registryUrl,
organizationName,
);
if (expectedRepositoryName && pkg.repository !== expectedRepositoryName) {
logger.warn(
{
packageName,
registryUrl,
expectedRepositoryName,
actualRepositoryName: pkg.repository,
},
'hex: V2 repository mismatch',
);
return null;
}
const releases = mapV2Releases(pkg);
if (releases.length === 0) {
return null;
}
return { releases };
}
private async getPublicKey(registryUrl: string): Promise<string | null> {
if (registryUrl === defaultHexRepositoryUrl) {
return defaultHexPublicKey;
}
const url = joinUrlParts(registryUrl, '/public_key');
try {
const { body } = await this.http.getText(url, {
cacheProvider: memCacheProvider,
});
const publicKey = body.trim();
if (publicKey.length === 0) {
logger.warn({ registryUrl, url }, 'hex: empty V2 public key response');
return null;
}
return publicKey;
} catch (err) {
logger.warn(
{ err, registryUrl, url },
'hex: failed to fetch V2 public key, falling back to unsigned payload',
);
return null;
}
}
private async _getReleases(
config: GetReleasesConfig,
): Promise<ReleaseResult | null> {
if (HexDatasource.isDefaultRegistry(config.registryUrl)) {
return this.getReleasesViaJsonApi(config);
}
try {
return await this.getReleasesViaV2Protocol(config);
} catch (err) {
logger.warn(
{
registryUrl: config.registryUrl,
packageName: config.packageName,
err,
},
'hex: error fetching package via V2 protocol',
);
this.handleGenericErrors(err as Error);
}
}
private static isDefaultRegistry(registryUrl: string | undefined): boolean {
return !registryUrl || registryUrl === defaultRegistryUrl;
}
getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null> {
const isDefault = HexDatasource.isDefaultRegistry(config.registryUrl);
const registryUrl = isDefault ? defaultRegistryUrl : config.registryUrl;
return withCache(
{
namespace: `datasource-${HexDatasource.id}`,
key: buildCacheKey(registryUrl, config.packageName),
cacheable: isDefault,
fallback: true,
},
() => this._getReleases(config),
);
}
}