mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-26 07:20:39 +00:00
f64ec3975a
* refactor(datasource): separate registry URLs in cache keys with a colon Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io> Co-Authored-By: Claude Sonnet 5.5 <michael.kriese+claude-code@mend.io> * fix(datasource/go): separate the remaining cache key parts with a colon Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io> * refactor(datasource): build cache keys with a shared colon-joining helper Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io> * refactor: build all cache keys with buildCacheKey Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io> * refactor(http): keep GET package cache keys as the bare URL Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io> * refactor(cache): extend cache key helper to memory cache keys Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io> * refactor(datasource/go): prefix the goproxy cache keys with their purpose Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io> --------- Co-authored-by: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
187 lines
5.7 KiB
TypeScript
187 lines
5.7 KiB
TypeScript
import { Readable } from 'node:stream';
|
|
import type {
|
|
GetObjectCommandOutput,
|
|
S3ClientConfig,
|
|
} from '@aws-sdk/client-s3';
|
|
import { GetObjectCommand } from '@aws-sdk/client-s3';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { ExternalHostError } from '../../../types/errors/external-host-error.ts';
|
|
import { buildCacheKey } from '../../../util/cache/package/key.ts';
|
|
import { withCache } from '../../../util/cache/package/with-cache.ts';
|
|
import * as hostRules from '../../../util/host-rules.ts';
|
|
import type { S3UrlParts } from '../../../util/s3.ts';
|
|
import { getS3Client, parseS3Url } from '../../../util/s3.ts';
|
|
import { streamToString } from '../../../util/streams.ts';
|
|
import { ensureTrailingSlash } from '../../../util/url.ts';
|
|
import { parseSingleYaml } from '../../../util/yaml.ts';
|
|
import * as helmVersioning from '../../versioning/helm/index.ts';
|
|
import { Datasource } from '../datasource.ts';
|
|
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
|
|
import { HelmRepository } from './schema.ts';
|
|
|
|
export class HelmDatasource extends Datasource {
|
|
static readonly id = 'helm';
|
|
|
|
constructor() {
|
|
super(HelmDatasource.id);
|
|
}
|
|
|
|
override getDefaultRegistryUrls(_packageName: string): string[] {
|
|
return ['https://charts.helm.sh/stable'];
|
|
}
|
|
|
|
override readonly defaultConfig = {
|
|
commitMessageTopic: 'Helm release {{depName}}',
|
|
};
|
|
|
|
override readonly defaultVersioning = helmVersioning.id;
|
|
|
|
override readonly releaseTimestampSupport = true;
|
|
override readonly releaseTimestampNote =
|
|
'The release timstamp is determined from the `created` field in the results.';
|
|
override readonly sourceUrlSupport = 'package';
|
|
override readonly sourceUrlNote =
|
|
'The source URL is determined from the `home` field or the `sources` field in the results.';
|
|
|
|
private async _getRepositoryData(
|
|
helmRepository: string,
|
|
): Promise<HelmRepository> {
|
|
const baseUrl = ensureTrailingSlash(helmRepository);
|
|
const indexUrl = `${baseUrl}index.yaml`;
|
|
|
|
const s3Url = parseS3Url(indexUrl);
|
|
if (s3Url) {
|
|
return await getS3RepositoryData(s3Url, indexUrl);
|
|
}
|
|
|
|
const { val, err } = await this.http
|
|
.getYamlSafe('index.yaml', { baseUrl }, HelmRepository)
|
|
.unwrap();
|
|
|
|
if (err) {
|
|
this.handleGenericErrors(err);
|
|
}
|
|
|
|
return val;
|
|
}
|
|
|
|
getRepositoryData(helmRepository: string): Promise<HelmRepository> {
|
|
return withCache(
|
|
{
|
|
namespace: `datasource-${HelmDatasource.id}`,
|
|
key: buildCacheKey('repository-data', helmRepository),
|
|
},
|
|
() => this._getRepositoryData(helmRepository),
|
|
);
|
|
}
|
|
|
|
async getReleases({
|
|
packageName,
|
|
registryUrl: helmRepository,
|
|
}: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
/* v8 ignore next -- should never happen */
|
|
if (!helmRepository) {
|
|
return null;
|
|
}
|
|
|
|
const repositoryData = await this.getRepositoryData(helmRepository);
|
|
const releases = repositoryData[packageName];
|
|
if (!releases) {
|
|
logger.debug(
|
|
{ dependency: packageName },
|
|
`Entry ${packageName} doesn't exist in index.yaml from ${helmRepository}`,
|
|
);
|
|
return null;
|
|
}
|
|
return releases;
|
|
}
|
|
}
|
|
|
|
async function getS3RepositoryData(
|
|
s3Url: S3UrlParts,
|
|
indexUrl: string,
|
|
): Promise<HelmRepository> {
|
|
const client = getS3Client(undefined, undefined, getS3Credentials(indexUrl));
|
|
|
|
let res: GetObjectCommandOutput;
|
|
try {
|
|
res = await client.send(new GetObjectCommand(s3Url));
|
|
} catch (err) {
|
|
throw classifyS3Error(err, indexUrl);
|
|
}
|
|
|
|
if (res.DeleteMarker) {
|
|
logger.debug(
|
|
{ indexUrl },
|
|
'Helm S3 lookup error: DeleteMarker encountered',
|
|
);
|
|
throw new Error(`No index.yaml found at ${indexUrl}`);
|
|
}
|
|
|
|
if (!(res.Body instanceof Readable)) {
|
|
logger.debug({ indexUrl }, 'Helm S3 lookup error: unsupported Body type');
|
|
throw new Error(`Unsupported S3 response body for ${indexUrl}`);
|
|
}
|
|
|
|
return parseSingleYaml(await streamToString(res.Body), {
|
|
customSchema: HelmRepository,
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Only a missing object means "this chart repository has no releases", so that
|
|
* error is rethrown as-is and the lookup resolves to `null`.
|
|
* Everything else becomes an `ExternalHostError` to abort the run, otherwise a
|
|
* transient S3 failure looks like a deleted chart and closes open PRs.
|
|
*/
|
|
function classifyS3Error(
|
|
// `name` holds the S3 error code, `message` holds server-supplied prose
|
|
err: Error & { $metadata?: { httpStatusCode?: number } },
|
|
indexUrl: string,
|
|
): Error {
|
|
if (err.name === 'NotFound' || err.name === 'NoSuchKey') {
|
|
logger.debug({ indexUrl }, 'Helm S3 lookup error: object not found');
|
|
return err;
|
|
}
|
|
|
|
if (
|
|
err.name === 'CredentialsProviderError' ||
|
|
err.$metadata?.httpStatusCode === 403
|
|
) {
|
|
logger.debug(
|
|
{ indexUrl, err },
|
|
'Helm S3 lookup error: credentials error, check "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY" variables or the matching `hostRules` entry',
|
|
);
|
|
} else if (err.message === 'Region is missing') {
|
|
// Thrown client-side by the SDK region resolver, so this string is stable
|
|
logger.debug(
|
|
{ indexUrl },
|
|
'Helm S3 lookup error: missing region, check "AWS_REGION" variable',
|
|
);
|
|
} else {
|
|
logger.debug({ indexUrl, err }, 'Helm S3 lookup error: unknown error');
|
|
}
|
|
|
|
return new ExternalHostError(err, HelmDatasource.id);
|
|
}
|
|
|
|
function getS3Credentials(
|
|
indexUrl: string,
|
|
): S3ClientConfig['credentials'] | undefined {
|
|
const { username, password, token } = hostRules.find({
|
|
hostType: HelmDatasource.id,
|
|
url: indexUrl,
|
|
});
|
|
|
|
// Fall back to the default AWS credential provider chain
|
|
if (!username || !password) {
|
|
return undefined;
|
|
}
|
|
|
|
return {
|
|
accessKeyId: username,
|
|
secretAccessKey: password,
|
|
sessionToken: token,
|
|
};
|
|
}
|