mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
a1971afa78
* ci(linter): add renovate/require-regex-util rule Adds a custom oxlint rule that flags raw RegExp usage in lib/ production code: any `new RegExp(...)` call and any regex literal that is not the direct first argument of `regEx(...)`. The regEx() helper from lib/util/regex.ts uses the RE2 engine for ReDoS-safe matching and caches compiled patterns. lib/util/regex.ts itself is exempt. The rule is disabled for **/*.spec.ts, test/**, and tools/** via config overrides, because vitest APIs such as expect.stringMatching need bare RegExp instances (a past commit reverted regEx() there). Severity is set to "warn" instead of "error": the repo currently has 197 pre-existing violations (above the agreed mechanical-fix threshold of 80), and a number of them are deliberately RE2-incompatible patterns (lookahead/lookbehind/named backreferences, see TODO #12872/#12875 markers in e.g. lib/modules/versioning/rez/ pattern.ts and lib/modules/manager/dockerfile/extract.ts) that need per-site judgment before they can be wrapped in regEx() or suppressed with a justified disable comment. No violation fixes are included in this commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci(linter): enforce renovate/require-regex-util at error Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: use regEx() for regex literals and RegExp construction in lib Burn down all renovate/require-regex-util violations (197): - wrap RE2-compatible regex literals and RegExp constructions in regEx() - rewrite lookaround patterns where behavior is provably preserved: goproxy separator split, sbt-package link extraction, leiningen comment stripping and keyword search, npm GitHub owner validation (unit-count bound replaced by an explicit length check) - keep native RegExp with disable comments where RE2 cannot be used: moo / good-enough-parser lexer patterns (moo rejects RE2 instances), MigrationsService propertyName (matched via isRegExp, which RE2 instances fail), rez named backreferences and lookaheads, GitHub markdown link negative lookbehind, emoji astral-plane matching - drop stale TODO #12875 comments for patterns current re2 handles Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: reduce require-regex-util disable comments Rewrite the github massage-markdown-links URL regex to capture an optional `api.` prefix in a named group (skipped in code) instead of relying on a negative lookbehind, so both the base and global variants can use regEx()/RE2 and their two disable comments are removed. Add spec cases for api-prefixed URLs that match the URL shape. Consolidate the four related line disables in rez/pattern.ts (bound and range patterns emulating Python conditional patterns via named backreferences and lookaheads, which RE2 cannot express) into a single block disable/enable pair, matching the treatment of the lexer files. Disable comment count drops from 13 to 8. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(datasource/sbt-package): use named capture group in link regex Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(manager/cake): restore original multiLineComment regex spelling The [^] -> [\\s\\S] rewrite was only needed for an RE2 wrap that was later reverted; keep the diff minimal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(datasource/go): skip empty GOPROXY segments The switch from a lookahead split to a capture-group split (needed because RE2 has no lookahead support) changed how empty GOPROXY segments parse: `a|,b` yielded `{ url: ',', fallback: '|' }` before and `{ url: '', fallback: ',' }` after. The comma fallback only continues on 404/410, so a failing proxy ahead of an empty segment silently stopped the lookup instead of falling through to the remaining proxies. Empty segments carry no url to query, so drop them. * refactor(datasource/go): use isTruthy for empty segment filter * fix(datasource/go): filter empty segments before mapping Filtering after the map broke the contextual typing from the GoproxyItem[] annotation, widening fallback to string. * refactor(platform/github): use regEx() for merge queue query stripping --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
197 lines
5.2 KiB
TypeScript
197 lines
5.2 KiB
TypeScript
import {
|
|
isArray,
|
|
isNonEmptyString,
|
|
isString,
|
|
isUrlInstance,
|
|
} from '@sindresorhus/is';
|
|
// oxlint-disable-next-line no-restricted-imports
|
|
import _parseLinkHeader from 'parse-link-header';
|
|
import urlJoin from 'url-join';
|
|
import { logger } from '../logger/index.ts';
|
|
import { regEx } from './regex.ts';
|
|
|
|
export function joinUrlParts(...parts: string[]): string {
|
|
return urlJoin(...parts);
|
|
}
|
|
|
|
export function ensurePathPrefix(url: string, prefix: string): string {
|
|
const parsed = new URL(url);
|
|
const fullPath = parsed.pathname + parsed.search;
|
|
if (fullPath.startsWith(prefix)) {
|
|
return url;
|
|
}
|
|
return parsed.origin + prefix + fullPath;
|
|
}
|
|
|
|
export function ensureTrailingSlash(url: string): string {
|
|
return url.replace(regEx(/\/?$/), '/');
|
|
}
|
|
|
|
export function trimTrailingSlash(url: string): string {
|
|
return url.replace(regEx(/\/+$/), '');
|
|
}
|
|
|
|
export function trimLeadingSlash(path: string): string {
|
|
return path.replace(regEx(/^\/+/), '');
|
|
}
|
|
|
|
export function trimSlashes(path: string): string {
|
|
return trimLeadingSlash(trimTrailingSlash(path));
|
|
}
|
|
|
|
/**
|
|
* Resolves an input path against a base URL
|
|
*
|
|
* @param baseUrl - base URL to resolve against
|
|
* @param input - input path (if this is a full URL, it will be returned)
|
|
*/
|
|
export function resolveBaseUrl(baseUrl: string, input: string | URL): string {
|
|
const inputString = input.toString();
|
|
|
|
let host;
|
|
let pathname;
|
|
try {
|
|
({ host, pathname } = new URL(inputString));
|
|
} catch {
|
|
pathname = inputString;
|
|
}
|
|
|
|
return host ? inputString : urlJoin(baseUrl, pathname || '');
|
|
}
|
|
|
|
/**
|
|
* Replaces the path of a URL with a new path
|
|
*
|
|
* @param baseUrl - source URL
|
|
* @param path - replacement path (if this is a full URL, it will be returned)
|
|
*/
|
|
export function replaceUrlPath(baseUrl: string | URL, path: string): string {
|
|
if (parseUrl(path)) {
|
|
return path;
|
|
}
|
|
|
|
const { origin } = isString(baseUrl) ? new URL(baseUrl) : baseUrl;
|
|
return urlJoin(origin, path);
|
|
}
|
|
|
|
/**
|
|
* Resolves a server-provided pagination "next" URL against the current request
|
|
* URL, returning it only when it stays on the same origin.
|
|
*
|
|
* Registries paginate by returning a `Link` header (or Atom `<link rel="next">`)
|
|
* pointing at the next page.
|
|
*
|
|
* However, if we were to follow that URL without validating it, this could lead to us being redirected to a different host, which could lead to Server-Side Request Forgery (SSRF).
|
|
*
|
|
* This guard drops any `next` URL that resolves to a different origin.
|
|
*
|
|
* @param baseUrl - the URL of the request that produced `nextUrl`
|
|
* @param nextUrl - the remote-server-provided pagination target (may be relative, and may be malicious)
|
|
* @returns the resolved absolute URL if same-origin, otherwise `null`
|
|
*/
|
|
export function resolveSameOriginUrl(
|
|
baseUrl: string | URL,
|
|
nextUrl: string | URL,
|
|
): string | null {
|
|
const base = parseUrl(baseUrl);
|
|
if (!base) {
|
|
return null;
|
|
}
|
|
|
|
let resolved: URL;
|
|
try {
|
|
resolved = new URL(nextUrl.toString(), base);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
// If the base URL is HTTPS and the resolved URL is HTTP, but has no port specified, we can assume that the server intended to use HTTPS. This is a common misconfiguration in some registries.
|
|
if (
|
|
base.protocol === 'https:' &&
|
|
resolved.protocol === 'http:' &&
|
|
resolved.port === ''
|
|
) {
|
|
logger.debug(`Detected protocol downgrade and fixed it: ${resolved.href}`);
|
|
resolved.protocol = 'https:';
|
|
}
|
|
|
|
return resolved.origin === base.origin ? resolved.href : null;
|
|
}
|
|
|
|
export function getQueryString(params: Record<string, any>): string {
|
|
const usp = new URLSearchParams();
|
|
for (const [k, v] of Object.entries(params)) {
|
|
if (isArray<object>(v)) {
|
|
for (const item of v) {
|
|
// TODO: fix me?
|
|
// oxlint-disable-next-line typescript/no-base-to-string
|
|
usp.append(k, item.toString());
|
|
}
|
|
} else {
|
|
usp.append(k, v.toString());
|
|
}
|
|
}
|
|
return usp.toString();
|
|
}
|
|
|
|
export function isHttpUrl(url: unknown): boolean {
|
|
if (!isNonEmptyString(url) && !isUrlInstance(url)) {
|
|
return false;
|
|
}
|
|
const protocol = parseUrl(url)?.protocol;
|
|
return protocol === 'https:' || protocol === 'http:';
|
|
}
|
|
|
|
export function parseUrl(url: URL | string | undefined | null): URL | null {
|
|
if (!url) {
|
|
return null;
|
|
}
|
|
|
|
if (url instanceof URL) {
|
|
return url;
|
|
}
|
|
|
|
try {
|
|
return new URL(url);
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Tries to create an URL object from either a full URL string or a hostname
|
|
* @param url either the full url or a hostname
|
|
* @returns an URL object or null
|
|
*/
|
|
export function createURLFromHostOrURL(url: string): URL | null {
|
|
return parseUrl(url) ?? parseUrl(`https://${url}`);
|
|
}
|
|
|
|
export type LinkHeaderLinks = _parseLinkHeader.Links;
|
|
|
|
export function parseLinkHeader(
|
|
linkHeader: string | null | undefined,
|
|
): LinkHeaderLinks | null {
|
|
if (!isNonEmptyString(linkHeader)) {
|
|
return null;
|
|
}
|
|
if (linkHeader.length > 2000) {
|
|
logger.warn({ linkHeader }, 'Link header too long.');
|
|
return null;
|
|
}
|
|
return _parseLinkHeader(linkHeader);
|
|
}
|
|
|
|
/**
|
|
* prefix https:// to hosts with port or path
|
|
*/
|
|
export function massageHostUrl(url: string): string {
|
|
if (!url.includes('://') && url.includes('/')) {
|
|
return `https://${url}`;
|
|
}
|
|
if (!url.includes('://') && url.includes(':')) {
|
|
return `https://${url}`;
|
|
}
|
|
return url;
|
|
}
|