mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
3412de84ce
* refactor(lint): enable oxlint prefer-named-capture-group at error Numbered capture groups (m[1], $1) break silently when a regex is edited and group order shifts. Named groups (?<name>...) make intent explicit and accesses (m.groups.name) resilient to reordering. This enables the built-in eslint rule prefer-named-capture-group, surfacing 321 pre-existing unnamed-group violations across ~121 files to be burned down incrementally in follow-up commits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(versioning): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations in lib/modules/versioning/. Unused capture groups (only reachable via .test() or whole-match) become non-capturing (?:...); groups whose value is read become named (?<name>...), with accesses rewritten to match.groups!.<name> (or destructured from .groups!) instead of positional match[n]/$n so a future edit that reorders groups cannot silently break the reader. Two cases needed extra care to preserve behavior: - semver/common.ts and poetry/patterns.ts split() on a regex whose capture group is relied upon by String.prototype.split to keep the separator in the output array; the group is kept capturing and named, not converted to non-capturing. - hashicorp/convertor.ts's semverRegex is only ever embedded via .source into a named `(?<version>...)` group elsewhere and never matched directly, so its internal groups are safe to make non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(datasource): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/datasource/. Same treatment as the versioning module: unused groups become non-capturing, used groups get names, and positional match[n] reads move to match.groups!.<name>. docker/ecr.ts and pypi/common.ts keep their positional destructuring (`const [, region] = ...`, `!!m &&`) working unchanged since a named capture group is still addressable by its numeric index in JavaScript — only pypi/common.ts's access was rewritten to m.groups!.owner for clarity since it read a single group directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(platform): name capture groups for prefer-named-capture-group Burns down all prefer-named-capture-group violations under lib/modules/platform/. Uses the repo's established idiom of `match.groups?.<name>` after an optional-chained exec()/match() (see bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts extractSourceBranch) and `$<name>` in String.replace replacement strings. Unused groups (markdown/HTML massaging regexes matched only to be stripped) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx dropped their unused outer wrapping group (only the inner key/value groups were ever read) and named the key/value groups; nameMatchRegex's remaining unused groups (protocol/user-info/port alternatives) become non-capturing since only source/hostname/depName/version are read via .groups. Accesses in collections.ts and roles.ts move from lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 1) Burns down prefer-named-capture-group violations across the first alphabetical slice of lib/modules/manager/ (ansible through mix). Used groups get names with accesses rewritten to match.groups!.<name> (or $<name> in replacement strings); groups whose value is never read become non-capturing (?:...). Two String.split() call sites (git-submodules/extract.ts, meteor/extract.ts) keep the established "named group still readable positionally from the split() result array" idiom instead of restructuring the destructuring. bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified byte-for-byte equivalent before/after via a quick node script since several nested groups collapsed to non-capturing at once. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(manager): name capture groups for prefer-named-capture-group (batch 2) Burns down prefer-named-capture-group violations across the remaining alphabetical slice of lib/modules/manager/ (npm through terragrunt). Same treatment as batch 1: used groups get names with accesses moved to match.groups!.<name> or $<name> replacement strings; unused groups (wrapping alternations, quantifier repetition groups only consumed via .test(), or values never read from a match) become non-capturing. terraform/extractors/others/modules.ts and terragrunt/modules.ts share near-identical URL-parsing regexes (github/bitbucket/git/azure-devops ref matchers) — the same set of always-unused `depth=`/`&depth=` query-string groups is converted to non-capturing in both files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(config): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/config/. Used groups get names with replacement strings switched from $1/$2 to $<name>; the unused separator group in schedule-migration.ts's afterBeforeRegex becomes non-capturing. presets/parse.ts keeps assigning through the already-declared `repo` variable rather than array-destructuring the exec() result, matching this file's existing style for the other named-group regexes just above it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(util): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations across lib/util/ and lib/logger/. Same treatment as previous batches: named groups for values that are read (via $<name> replacement strings, .groups!.<name>, or destructured from .groups), non-capturing groups where nothing reads the captured value (e.g. semantic.ts's angular-commit .test()-only regex). www-authenticate.ts's tokenizer entries each get their own named group but keep accessing the match generically via match[1], since a positionally-indexed named group is still readable by index. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(workers): name capture groups for prefer-named-capture-group Burns down prefer-named-capture-group violations in lib/workers/. Used groups get names with $<name> replacement strings; unused wrapper/alternation groups (e.g. semantic-commit-message.ts's optional scope/issue wrappers, release-notes.ts's date-heading and horizontal-rule matchers that are only probed with .search()/replaced wholesale) become non-capturing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * refactor(test,tools): name capture groups for prefer-named-capture-group Finishes the prefer-named-capture-group burndown: test/, tools/, and vitest.config.mts. Groups whose value is read get names ($<name> replacement strings or .groups.<name> access); groups only used via .test()/.search() or that feed a .match(/…/g) call (whose return value is the array of whole matches, not captured groups) become non-capturing. This is the last remaining slice of pre-existing violations, so the rule (already enabled at error repo-wide) now passes with zero findings across the whole codebase. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk * fix prettier failure * refactor(lint): use a named capture group in `v8-ignore-no-count` New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
221 lines
5.1 KiB
TypeScript
221 lines
5.1 KiB
TypeScript
import { regEx } from '../../../util/regex.ts';
|
|
import { coerceString } from '../../../util/string.ts';
|
|
import { DistroInfo } from '../distro.ts';
|
|
import type { NewValueConfig, VersioningApi } from '../types.ts';
|
|
import {
|
|
getDatedContainerImageCodename,
|
|
getDatedContainerImageSuffix,
|
|
getDatedContainerImageVersion,
|
|
isDatedCodeName,
|
|
} from './common.ts';
|
|
|
|
export const id = 'ubuntu';
|
|
export const displayName = 'Ubuntu';
|
|
export const urls = [
|
|
'[Ubuntu meta-release](https://changelogs.ubuntu.com/meta-release)',
|
|
'[Ubuntu distro info data](https://debian.pages.debian.net/distro-info-data/ubuntu.csv)',
|
|
];
|
|
export const supportsRanges = false;
|
|
|
|
const di = new DistroInfo('data/ubuntu-distro-info.json');
|
|
|
|
// validation
|
|
|
|
function isValid(input: string): boolean {
|
|
if (
|
|
regEx(/^(?:0[4-5]|[6-9]|[1-9][0-9])\.[0-9][0-9](?:\.[0-9]{1,2})?$/).test(
|
|
input,
|
|
)
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
if (di.isCodename(input)) {
|
|
return true;
|
|
}
|
|
|
|
return isDatedCodeName(input);
|
|
}
|
|
|
|
function isVersion(input: string): boolean {
|
|
return isValid(input);
|
|
}
|
|
|
|
function isCompatible(version: string, _current?: string): boolean {
|
|
return isValid(version);
|
|
}
|
|
|
|
function isSingleVersion(version: string): boolean {
|
|
return isValid(version);
|
|
}
|
|
|
|
function isStable(version: string): boolean {
|
|
const ver = di.getVersionByCodename(version);
|
|
if (!isValid(ver)) {
|
|
return false;
|
|
}
|
|
|
|
const match = ver.match(regEx(/^\d+.\d+/));
|
|
|
|
if (!di.isReleased(coerceString(match?.[0], ver))) {
|
|
return false;
|
|
}
|
|
|
|
return regEx(/^\d?[02468]\.04/).test(ver);
|
|
}
|
|
|
|
// digestion of version
|
|
|
|
function getVersionByCodename(version: string): string {
|
|
const datedImgVersion = getDatedContainerImageCodename(version);
|
|
const getVersion = datedImgVersion ?? version;
|
|
return di.getVersionByCodename(getVersion);
|
|
}
|
|
|
|
function getMajor(version: string): null | number {
|
|
const ver = getVersionByCodename(version);
|
|
if (isValid(ver)) {
|
|
const [major] = ver.split('.');
|
|
return parseInt(major, 10);
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function getMinor(version: string): null | number {
|
|
const ver = getVersionByCodename(version);
|
|
if (isValid(ver)) {
|
|
const [, minor] = ver.split('.');
|
|
return parseInt(minor, 10);
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function getPatch(version: string): null | number {
|
|
const ver = getVersionByCodename(version);
|
|
if (isValid(ver)) {
|
|
const [, , patch] = ver.split('.');
|
|
return patch ? parseInt(patch, 10) : null;
|
|
}
|
|
return null;
|
|
}
|
|
|
|
// comparison
|
|
|
|
function equals(version: string, other: string): boolean {
|
|
const verImage = getDatedContainerImageVersion(version);
|
|
const otherImageVer = getDatedContainerImageVersion(other);
|
|
if (verImage !== otherImageVer) {
|
|
return false;
|
|
}
|
|
|
|
const verSuffix = getDatedContainerImageSuffix(version);
|
|
const otherSuffix = getDatedContainerImageSuffix(other);
|
|
if (verSuffix !== otherSuffix) {
|
|
return false;
|
|
}
|
|
|
|
const ver = getVersionByCodename(version);
|
|
const otherVer = getVersionByCodename(other);
|
|
return isVersion(ver) && isVersion(otherVer) && ver === otherVer;
|
|
}
|
|
|
|
function isGreaterThan(version: string, other: string): boolean {
|
|
const xMajor = getMajor(version) ?? 0;
|
|
const yMajor = getMajor(other) ?? 0;
|
|
if (xMajor > yMajor) {
|
|
return true;
|
|
}
|
|
if (xMajor < yMajor) {
|
|
return false;
|
|
}
|
|
|
|
const xMinor = getMinor(version) ?? 0;
|
|
const yMinor = getMinor(other) ?? 0;
|
|
if (xMinor > yMinor) {
|
|
return true;
|
|
}
|
|
if (xMinor < yMinor) {
|
|
return false;
|
|
}
|
|
|
|
const xImageVersion = getDatedContainerImageVersion(version) ?? 0;
|
|
const yImageVersion = getDatedContainerImageVersion(other) ?? 0;
|
|
if (xImageVersion > yImageVersion) {
|
|
return true;
|
|
}
|
|
if (xImageVersion < yImageVersion) {
|
|
return false;
|
|
}
|
|
|
|
const xSuffixVersion = getDatedContainerImageSuffix(version) ?? 0;
|
|
const ySuffixVersion = getDatedContainerImageSuffix(other) ?? 0;
|
|
if (xSuffixVersion > ySuffixVersion) {
|
|
return true;
|
|
}
|
|
if (xSuffixVersion < ySuffixVersion) {
|
|
return false;
|
|
}
|
|
|
|
const xPatch = getPatch(version) ?? 0;
|
|
const yPatch = getPatch(other) ?? 0;
|
|
return xPatch > yPatch;
|
|
}
|
|
|
|
function getSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
return versions.find((version) => equals(version, range)) ? range : null;
|
|
}
|
|
|
|
function minSatisfyingVersion(
|
|
versions: string[],
|
|
range: string,
|
|
): string | null {
|
|
return getSatisfyingVersion(versions, range);
|
|
}
|
|
|
|
function getNewValue({ currentValue, newVersion }: NewValueConfig): string {
|
|
if (di.isCodename(currentValue)) {
|
|
return di.getCodenameByVersion(newVersion);
|
|
}
|
|
return di.getVersionByCodename(newVersion);
|
|
}
|
|
|
|
function sortVersions(version: string, other: string): number {
|
|
if (equals(version, other)) {
|
|
return 0;
|
|
}
|
|
if (isGreaterThan(version, other)) {
|
|
return 1;
|
|
}
|
|
return -1;
|
|
}
|
|
|
|
function matches(version: string, range: string): boolean {
|
|
return equals(version, range);
|
|
}
|
|
|
|
export const api: VersioningApi = {
|
|
isCompatible,
|
|
isSingleVersion,
|
|
isStable,
|
|
isValid,
|
|
isVersion,
|
|
|
|
getMajor,
|
|
getMinor,
|
|
getPatch,
|
|
|
|
equals,
|
|
isGreaterThan,
|
|
getSatisfyingVersion,
|
|
minSatisfyingVersion,
|
|
getNewValue,
|
|
sortVersions,
|
|
|
|
matches,
|
|
};
|
|
|
|
export default api;
|