Files
renovate/lib/modules/versioning/nuget/version.ts
Sebastian Poxhofer 9717259ffc refactor(oxlint): enable no-else-return and unicorn/no-lonely-if (#44553)
Enable no-else-return (with allowElseIf: false) and unicorn/no-lonely-if
as errors in .oxlintrc.json and fix all 131 pre-existing violations
(91 no-else-return, 40 unicorn/no-lonely-if) across 98 files.

The no-else-return violations were fixed with the oxlint autofix
(iterated to a fixpoint, plus two else-if chains that required
--fix-dangerously) followed by Prettier formatting. One comment dropped
by the autofix in lib/modules/manager/pub/artifacts.ts was restored
manually. The unicorn/no-lonely-if violations were merged by hand,
preserving comments and coverage-ignore hints.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-14 12:11:21 +00:00

101 lines
2.2 KiB
TypeScript

import { regEx } from '../../../util/regex.ts';
import type { NugetVersion } from './types.ts';
// We can't just use `Number.parseInt()` beacause it parses `123abc` as `123`,
// which leads to incorrect version comparison.
function ensureNumber(input: string): number | null {
if (!regEx(/^\d+$/).test(input)) {
return null;
}
return Number.parseInt(input, 10);
}
function comparePrereleases(x: string, y: string): number {
const xParts = x.split('.');
const yParts = y.split('.');
const maxLen = Math.max(xParts.length, yParts.length);
for (let i = 0; i < maxLen; i += 1) {
const xPart = xParts[i] ?? '';
const yPart = yParts[i] ?? '';
const xNum = ensureNumber(xPart);
const yNum = ensureNumber(yPart);
const res =
xNum !== null && yNum !== null
? Math.sign(xNum - yNum)
: xPart.localeCompare(yPart, undefined, { sensitivity: 'base' });
if (res !== 0) {
return res;
}
}
return 0;
}
export function compare(x: NugetVersion, y: NugetVersion): number {
const xMajor = x.major;
const yMajor = y.major;
const xMinor = x.minor ?? 0;
const yMinor = y.minor ?? 0;
const xPatch = x.patch ?? 0;
const yPatch = y.patch ?? 0;
const xRevision = x.revision ?? 0;
const yRevision = y.revision ?? 0;
if (xMajor !== yMajor) {
return Math.sign(xMajor - yMajor);
}
if (xMinor !== yMinor) {
return Math.sign(xMinor - yMinor);
}
if (xPatch !== yPatch) {
return Math.sign(xPatch - yPatch);
}
if (xRevision !== yRevision) {
return Math.sign(xRevision - yRevision);
}
if (x.prerelease && !y.prerelease) {
return -1;
}
if (!x.prerelease && y.prerelease) {
return 1;
}
if (x.prerelease && y.prerelease) {
return comparePrereleases(x.prerelease, y.prerelease);
}
return 0;
}
export function versionToString(version: NugetVersion): string {
let res = `${version.major}`;
if (version.minor !== undefined) {
res += `.${version.minor}`;
}
if (version.patch !== undefined) {
res += `.${version.patch}`;
}
if (version.revision !== undefined) {
res += `.${version.revision}`;
}
if (version.prerelease) {
res += `-${version.prerelease}`;
}
if (version.metadata) {
res += `+${version.metadata}`;
}
return res;
}