Files
Sebastian Poxhofer 58771bb183 refactor(linters): enabled oxlints func-style (#44691)
* refactor(oxlint): enable func-style

Enable the built-in func-style rule as ["warn", "declaration"] so that
named functions are written as function declarations instead of arrow or
function expressions assigned to variables, matching the convention in
docs/development/best-practices.md (Functions section). Inline arrow
callbacks are unaffected; prefer-arrow-callback continues to cover the
callback direction.

Severity is "warn" instead of "error" as a fallback: a repo-wide run
found 196 pre-existing violations (70 in spec files, 126 in production
code), exceeding the 80-violation fix threshold for this change, so no
violations were fixed here. Follow-up work can convert the offenders
(largest clusters: lib/modules/versioning/ruby, lib/util/cache/package,
lib/modules/versioning/maven, lib/modules/versioning/gradle) and then
raise the rule to "error". Note oxlint 1.72 also supports an
allowTypeAnnotation option if typed consts should remain arrows.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci(linter): enforce func-style at error

* refactor(func-style): convert const-arrow functions to declarations in with-cache spec and ruby versioning

* refactor(func-style): convert const-arrow functions to declarations in maven/gradle modules

* refactor(func-style): convert const-arrow functions to declarations in remaining versioning modules

* refactor(func-style): convert const-arrow functions to declarations in platform modules

Discriminated-union closures (ensureCommentRemoval byTopic/byContent
helpers in github, gitlab, bitbucket, bitbucket-server) needed the
narrowed field passed explicitly as a parameter, since function
declarations are hoisted and lose the outer if-narrowing that inline
arrow-function closures previously relied on.

* refactor(func-style): convert const-arrow functions to declarations across util/manager/datasource modules

One case (logger/renovate-logger.ts logOnceFn) is kept as an arrow
function with a documented oxlint-disable: it is stored on
this.logger.once[level] and relies on lexically-bound this, which a
hoisted function declaration would not preserve.

* refactor(func-style): convert remaining const-arrow test helpers to declarations

get-updated.spec.ts: hoisted expectPipCompilePackageAndLockFile to
module scope (it only closes over the module-level pipCompile mock)
and added a documented oxlint-disable for vitest/expect-expect on its
caller test, since oxlint's expect-expect check does not trace
assertions through an externally-defined helper function.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-19 11:14:22 +00:00

116 lines
2.8 KiB
TypeScript

import semver from 'semver';
import stable from 'semver-stable';
import type { RangeStrategy } from '../../../types/versioning.ts';
import { normalizeLegacyXRanges } from '../semver/common.ts';
import { isBreaking } from '../semver/index.ts';
import type { VersioningApi } from '../types.ts';
import { getNewValue } from './range.ts';
export const id = 'npm';
export const displayName = 'npm';
export const urls = [
'[Semantic Versioning](https://semver.org/)',
'[semver npm package](https://www.npmjs.com/package/semver)',
'[npm - About semantic versioning](https://docs.npmjs.com/about-semantic-versioning)',
'[npm semver calculator](https://semver.npmjs.com/)',
];
export const supportsRanges = true;
export const supportedRangeStrategies: RangeStrategy[] = [
'bump',
'widen',
'replace',
];
const {
compare: sortVersions,
maxSatisfying,
minSatisfying,
major: getMajor,
minor: getMinor,
patch: getPatch,
satisfies,
valid,
validRange,
ltr,
gt: isGreaterThan,
eq: equals,
subset: semverSubset,
intersects: semverIntersects,
} = semver;
function normalizeNpmRange(range: string): string {
return normalizeLegacyXRanges(range);
}
// If this is left as an alias, inputs like "17.04.0" throw errors
export function isValid(input: string): boolean {
return !!validRange(normalizeNpmRange(input));
}
export function isVersion(input: string): boolean {
return !!valid(input);
}
function matches(version: string, range: string): boolean {
return satisfies(version, normalizeNpmRange(range));
}
function getSatisfyingVersion(
versions: string[],
range: string,
): string | null {
return maxSatisfying(versions, normalizeNpmRange(range));
}
function minSatisfyingVersion(
versions: string[],
range: string,
): string | null {
return minSatisfying(versions, normalizeNpmRange(range));
}
function isLessThanRange(version: string, range: string): boolean {
return ltr(version, normalizeNpmRange(range));
}
function subset(subRange: string, superRange: string): boolean | undefined {
return semverSubset(
normalizeNpmRange(subRange),
normalizeNpmRange(superRange),
);
}
function intersects(range1: string, range2: string): boolean {
return semverIntersects(normalizeNpmRange(range1), normalizeNpmRange(range2));
}
function isSingleVersion(constraint: string): boolean {
return (
isVersion(constraint) ||
(constraint?.startsWith('=') && isVersion(constraint.substring(1).trim()))
);
}
export const api: VersioningApi = {
equals,
getMajor,
getMinor,
getNewValue,
getPatch,
isBreaking,
isCompatible: isVersion,
isGreaterThan,
isLessThanRange,
isSingleVersion,
isStable: stable.is,
isValid,
isVersion,
matches,
getSatisfyingVersion,
minSatisfyingVersion,
sortVersions,
subset,
intersects,
};
export default api;