mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
Michael Kriese
dec41b697e
test(manager/terraform): close the terraform family coverage gaps Adds two terraform extractions that no test covered: a lock file that cannot be read, and one that holds no locks. Both leave the deps without a locked version. Marks three guards. The lockfile update path needs a change that also satisfies the recorded constraints, `extractTFLintPlugin()` never returns null, and only terragrunt's already-ignored default case leaves its result unset. Two implicit elses stay counted, in the terraform module extractor and the tflint key parser: a coverage-ignore hint does not attach to an `else if`, so they carry a plain note. Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io>
93 lines
2.9 KiB
TypeScript
93 lines
2.9 KiB
TypeScript
import { isString } from '@sindresorhus/is';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import { GithubReleasesDatasource } from '../../datasource/github-releases/index.ts';
|
|
import type { PackageDependency } from '../types.ts';
|
|
import type { ExtractionResult } from './types.ts';
|
|
import { keyValueExtractionRegex } from './util.ts';
|
|
|
|
export function extractTFLintPlugin(
|
|
startingLine: number,
|
|
lines: string[],
|
|
// TODO: remove unused parameter
|
|
_pluginName: string,
|
|
): ExtractionResult {
|
|
let lineNumber = startingLine;
|
|
const deps: PackageDependency[] = [];
|
|
|
|
let pluginSource: string | null = null;
|
|
let currentVersion: string | null = null;
|
|
|
|
let braceCounter = 0;
|
|
do {
|
|
// istanbul ignore if
|
|
if (lineNumber > lines.length - 1) {
|
|
logger.debug(`Malformed TFLint configuration file detected.`);
|
|
}
|
|
|
|
const line = lines[lineNumber];
|
|
|
|
// istanbul ignore else
|
|
if (isString(line)) {
|
|
// `{` will be counted with +1 and `}` with -1.
|
|
// Therefore if we reach braceCounter == 0 then we found the end of the tflint configuration block.
|
|
const openBrackets = coerceArray(line.match(regEx(/\{/g))).length;
|
|
const closedBrackets = coerceArray(line.match(regEx(/\}/g))).length;
|
|
braceCounter = braceCounter + openBrackets - closedBrackets;
|
|
|
|
// only update fields inside the root block
|
|
if (braceCounter === 1) {
|
|
const kvMatch = keyValueExtractionRegex.exec(line);
|
|
if (kvMatch?.groups) {
|
|
if (kvMatch.groups.key === 'version') {
|
|
currentVersion = kvMatch.groups.value;
|
|
// NOTE: the key regex only matches these two, so the implicit else
|
|
// never runs. A coverage-ignore hint cannot suppress it on an
|
|
// `else if`.
|
|
} else if (kvMatch.groups.key === 'source') {
|
|
pluginSource = kvMatch.groups.value;
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
// stop - something went wrong
|
|
braceCounter = 0;
|
|
}
|
|
lineNumber += 1;
|
|
} while (braceCounter !== 0);
|
|
|
|
const dep = analyseTFLintPlugin(pluginSource, currentVersion);
|
|
deps.push(dep);
|
|
|
|
// remove last lineNumber addition to not skip a line after the last bracket
|
|
lineNumber -= 1;
|
|
return { lineNumber, dependencies: deps };
|
|
}
|
|
|
|
function analyseTFLintPlugin(
|
|
source: string | null,
|
|
version: string | null,
|
|
): PackageDependency {
|
|
const dep: PackageDependency = {};
|
|
|
|
if (source) {
|
|
dep.depType = 'plugin';
|
|
|
|
const sourceParts = source.split('/');
|
|
if (sourceParts[0] === 'github.com') {
|
|
dep.currentValue = version;
|
|
dep.datasource = GithubReleasesDatasource.id;
|
|
dep.depName = sourceParts.slice(1).join('/');
|
|
} else {
|
|
dep.skipReason = 'unsupported-datasource';
|
|
dep.depName = source;
|
|
}
|
|
} else {
|
|
logger.debug({ dep }, 'tflint plugin has no source');
|
|
dep.skipReason = 'no-source';
|
|
}
|
|
|
|
return dep;
|
|
}
|