mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 02:00:10 +00:00
4b4d14ec00
* feat(manager): pass extracted constraints to updateArtifacts `extractedConstraints` were collected during extraction but only ever read by `fetch.ts` for the lookup. At artifact time every manager had to derive the same tool constraints a second time, and when the updated package file no longer carried the constraint there was nothing to fall back to. `generateBranchConfig()` now merges the `extractedConstraints` of all upgrades of a branch onto the branch config, which reaches `updateArtifacts()` through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares the field and documents what it contains. The new `resolveToolConstraint()` helper implements the ladder once: user `constraints` > an optional artifact-time derivation > the extracted value. The derivation is ranked above the extracted value on purpose: it reads the package files as the branch changed them, so poetry (python is an updatable dependency there), composer, pipenv (`pipenv` can be a dev package) and pep621 (`requires-python` is an updatable dependency) would otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and composer are migrated to the helper and keep their derivation. Behaviour change: these managers now use the extract-time constraint as a last resort instead of running unconstrained, for example on lock file maintenance where pipenv deletes `Pipfile.lock` before deriving. `execute-post-upgrade-commands.ts` is unaffected: it reads `upgrade.constraints` per upgrade, and the extracted values are kept in a separate field rather than folded into `constraints`, so post-upgrade task tool constraints still come from user config only. Not migrated, because their constraints are never extracted, so the fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`), pep621 uv (`required-version`) and npm's node ladder, whose last step already reads `package.json` engines. * refactor(manager): resolve tool constraints through resolveToolConstraint() Every manager now obtains the constraint of a tool it runs through `resolveToolConstraint()` instead of reading `config.constraints` itself, so the precedence "user config, then a value derived from the updated files, then the constraints collected during extraction" applies everywhere. The helper treats an empty string as not set at every step and accepts the `PostUpdateConfig` shape, whose `constraints` may be `null`. Behaviour changes that go beyond the new fallback to extracted constraints: - `mix` applies its hardcoded erlang default only after the extracted constraint, so an erlang version collected at extraction can win over it. - `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm constraint; `generateHelmEnvs()` takes that value instead of the config. - `npm` (yarn): an upgrade of yarn without a new value now consults the user constraint before deriving one from package.json or the lock file. - The "Using <tool> constraint from config" debug lines in bundler, composer, copier and pip-compile are gone, as the helper is the only reader of the config now. Helpers that read the config synchronously became async: bundler `getBundlerConstraint()`, copier `getPythonVersionConstraint()` and `getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and `getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and `getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer `getPhpConstraint()` is removed. Each converted manager has a test showing the extracted constraint reaching the executed tool, and, where a derive callback exists, that the derived value still wins over it. * refactor(linters): add prefer-resolve-tool-constraint rule Reports member reads and destructuring of `constraints` and `extractedConstraints` from a manager config in `lib/modules/manager/**`, so that tool constraints are resolved through `resolveToolConstraint()` in `lib/modules/manager/util.ts` only. Writes and the same properties on package files, which extraction has to populate, are not reported. The helper itself and spec files are exempt in `.oxlintrc.json`. * refactor(manager): inline thin resolveToolConstraint wrappers Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint / getUvVersionConstraint helpers, which only forwarded to resolveToolConstraint(). Callers now call it directly. * docs(development): note lock file maintenance in tool constraints section * refactor(manager): address review on tool constraint resolution composer only runs extractConstraints() when a user constraint is missing, via Lazy. UpdateArtifactsConfig no longer re-declares constraints and extractedConstraints, which ToolConstraintsConfig already provides.
209 lines
6.4 KiB
TypeScript
209 lines
6.4 KiB
TypeScript
import { pipenv as pipenvDetect } from '@renovatebot/detect-tools';
|
|
import {
|
|
isNonEmptyStringAndNotWhitespace,
|
|
isUrlInstance,
|
|
} from '@sindresorhus/is';
|
|
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import type { HostRule } from '../../../types/index.ts';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import { exec } from '../../../util/exec/index.ts';
|
|
import type { ExecOptions, ExtraEnv, Opt } from '../../../util/exec/types.ts';
|
|
import {
|
|
deleteLocalFile,
|
|
ensureCacheDir,
|
|
getParentDir,
|
|
localPathExists,
|
|
readLocalFile,
|
|
writeLocalFile,
|
|
} from '../../../util/fs/index.ts';
|
|
import { ensureLocalPath } from '../../../util/fs/util.ts';
|
|
import { getRepoStatus } from '../../../util/git/index.ts';
|
|
import { find } from '../../../util/host-rules.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import { parseUrl } from '../../../util/url.ts';
|
|
import { PypiDatasource } from '../../datasource/pypi/index.ts';
|
|
import type { UpdateArtifact, UpdateArtifactsResult } from '../types.ts';
|
|
import { resolveToolConstraint } from '../util.ts';
|
|
import { extractPackageFile } from './extract.ts';
|
|
|
|
export function getMatchingHostRule(url: string): HostRule | null {
|
|
const parsedUrl = parseUrl(url);
|
|
if (parsedUrl) {
|
|
parsedUrl.username = '';
|
|
parsedUrl.password = '';
|
|
const urlWithoutCredentials = parsedUrl.toString();
|
|
|
|
return find({ hostType: PypiDatasource.id, url: urlWithoutCredentials });
|
|
}
|
|
return null;
|
|
}
|
|
|
|
async function findPipfileSourceUrlsWithCredentials(
|
|
pipfileContent: string,
|
|
pipfileName: string,
|
|
): Promise<URL[]> {
|
|
const pipfile = await extractPackageFile(pipfileContent, pipfileName);
|
|
|
|
return coerceArray(
|
|
pipfile?.registryUrls
|
|
?.map(parseUrl)
|
|
.filter(isUrlInstance)
|
|
.filter((url) => isNonEmptyStringAndNotWhitespace(url.username)),
|
|
);
|
|
}
|
|
|
|
/**
|
|
* This will extract the actual variable name from an environment-placeholder:
|
|
* ${USERNAME:-defaultvalue} will yield 'USERNAME'
|
|
*/
|
|
export function extractEnvironmentVariableName(
|
|
credential: string,
|
|
): string | null {
|
|
const match = regEx('([a-z0-9_]+)', 'i').exec(decodeURI(credential));
|
|
return match?.length ? match[0] : null;
|
|
}
|
|
|
|
export function addExtraEnvVariable(
|
|
extraEnv: ExtraEnv,
|
|
environmentVariableName: string,
|
|
environmentValue: string,
|
|
): void {
|
|
logger.trace(
|
|
`Adding ${environmentVariableName} environment variable for pipenv`,
|
|
);
|
|
if (
|
|
extraEnv[environmentVariableName] &&
|
|
extraEnv[environmentVariableName] !== environmentValue
|
|
) {
|
|
logger.warn(
|
|
{ envVar: environmentVariableName },
|
|
'Possible misconfiguration, environment variable already set to a different value',
|
|
);
|
|
}
|
|
extraEnv[environmentVariableName] = environmentValue;
|
|
}
|
|
|
|
/**
|
|
* Pipenv allows configuring source-urls for remote repositories with placeholders for credentials, i.e. http://$USER:$PASS@myprivate.repo
|
|
* if a matching host rule exists for that repository, we need to set the corresponding variables.
|
|
* Simply substituting them in the URL is not an option as it would impact the hash for the resulting Pipfile.lock
|
|
*
|
|
*/
|
|
async function addCredentialsForSourceUrls(
|
|
newPipfileContent: string,
|
|
pipfileName: string,
|
|
extraEnv: ExtraEnv,
|
|
): Promise<void> {
|
|
const sourceUrls = await findPipfileSourceUrlsWithCredentials(
|
|
newPipfileContent,
|
|
pipfileName,
|
|
);
|
|
for (const parsedSourceUrl of sourceUrls) {
|
|
logger.trace(`Trying to add credentials for ${parsedSourceUrl.toString()}`);
|
|
const matchingHostRule = getMatchingHostRule(parsedSourceUrl.toString());
|
|
if (matchingHostRule) {
|
|
const usernameVariableName = extractEnvironmentVariableName(
|
|
parsedSourceUrl.username,
|
|
);
|
|
if (matchingHostRule.username && usernameVariableName) {
|
|
addExtraEnvVariable(
|
|
extraEnv,
|
|
usernameVariableName,
|
|
matchingHostRule.username,
|
|
);
|
|
}
|
|
const passwordVariableName = extractEnvironmentVariableName(
|
|
parsedSourceUrl.password,
|
|
);
|
|
if (matchingHostRule.password && passwordVariableName) {
|
|
addExtraEnvVariable(
|
|
extraEnv,
|
|
passwordVariableName,
|
|
matchingHostRule.password,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
export async function updateArtifacts({
|
|
packageFileName: pipfileName,
|
|
newPackageFileContent: newPipfileContent,
|
|
config,
|
|
}: UpdateArtifact): Promise<UpdateArtifactsResult[] | null> {
|
|
logger.debug(`pipenv.updateArtifacts(${pipfileName})`);
|
|
|
|
const lockFileName = `${pipfileName}.lock`;
|
|
if (!(await localPathExists(lockFileName))) {
|
|
logger.debug('No Pipfile.lock found');
|
|
return null;
|
|
}
|
|
try {
|
|
await writeLocalFile(pipfileName, newPipfileContent);
|
|
if (config.isLockFileMaintenance) {
|
|
await deleteLocalFile(lockFileName);
|
|
}
|
|
const cmd = 'pipenv lock';
|
|
const pipfileDir = getParentDir(ensureLocalPath(pipfileName));
|
|
const tagConstraint = await resolveToolConstraint(config, 'python', () =>
|
|
pipenvDetect.getPythonConstraint(pipfileDir),
|
|
);
|
|
const pipenvConstraint = await resolveToolConstraint(config, 'pipenv', () =>
|
|
pipenvDetect.getPipenvConstraint(pipfileDir),
|
|
);
|
|
const extraEnv: Opt<ExtraEnv> = {
|
|
PIPENV_CACHE_DIR: await ensureCacheDir('pipenv'),
|
|
PIP_CACHE_DIR: await ensureCacheDir('pip'),
|
|
WORKON_HOME: await ensureCacheDir('virtualenvs'),
|
|
};
|
|
const execOptions: ExecOptions = {
|
|
cwdFile: pipfileName,
|
|
docker: {},
|
|
toolConstraints: [
|
|
{
|
|
toolName: 'python',
|
|
constraint: tagConstraint,
|
|
},
|
|
{
|
|
toolName: 'pipenv',
|
|
constraint: pipenvConstraint,
|
|
},
|
|
],
|
|
};
|
|
await addCredentialsForSourceUrls(newPipfileContent, pipfileName, extraEnv);
|
|
execOptions.extraEnv = extraEnv;
|
|
|
|
logger.trace({ cmd }, 'pipenv lock command');
|
|
await exec(cmd, execOptions);
|
|
const status = await getRepoStatus();
|
|
if (!status?.modified.includes(lockFileName)) {
|
|
return null;
|
|
}
|
|
logger.debug('Returning updated Pipfile.lock');
|
|
return [
|
|
{
|
|
file: {
|
|
type: 'addition',
|
|
path: lockFileName,
|
|
contents: await readLocalFile(lockFileName, 'utf8'),
|
|
},
|
|
},
|
|
];
|
|
} catch (err) {
|
|
// istanbul ignore if
|
|
if (err.message === TEMPORARY_ERROR) {
|
|
throw err;
|
|
}
|
|
logger.debug({ err }, 'Failed to update Pipfile.lock');
|
|
return [
|
|
{
|
|
artifactError: {
|
|
fileName: lockFileName,
|
|
stderr: err.message,
|
|
},
|
|
},
|
|
];
|
|
}
|
|
}
|