Files
Sebastian Poxhofer 4b4d14ec00 feat(manager): pass extracted constraints to updateArtifacts (#45826)
* feat(manager): pass extracted constraints to updateArtifacts

`extractedConstraints` were collected during extraction but only ever read
by `fetch.ts` for the lookup. At artifact time every manager had to derive
the same tool constraints a second time, and when the updated package file
no longer carried the constraint there was nothing to fall back to.

`generateBranchConfig()` now merges the `extractedConstraints` of all
upgrades of a branch onto the branch config, which reaches `updateArtifacts()`
through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares
the field and documents what it contains.

The new `resolveToolConstraint()` helper implements the ladder once:
user `constraints` > an optional artifact-time derivation > the extracted
value. The derivation is ranked above the extracted value on purpose: it
reads the package files as the branch changed them, so poetry (python is an
updatable dependency there), composer, pipenv (`pipenv` can be a dev
package) and pep621 (`requires-python` is an updatable dependency) would
otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and
composer are migrated to the helper and keep their derivation.

Behaviour change: these managers now use the extract-time constraint as a
last resort instead of running unconstrained, for example on lock file
maintenance where pipenv deletes `Pipfile.lock` before deriving.

`execute-post-upgrade-commands.ts` is unaffected: it reads
`upgrade.constraints` per upgrade, and the extracted values are kept in a
separate field rather than folded into `constraints`, so post-upgrade task
tool constraints still come from user config only.

Not migrated, because their constraints are never extracted, so the
fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`),
pep621 uv (`required-version`) and npm's node ladder, whose last step
already reads `package.json` engines.

* refactor(manager): resolve tool constraints through resolveToolConstraint()

Every manager now obtains the constraint of a tool it runs through
`resolveToolConstraint()` instead of reading `config.constraints` itself, so
the precedence "user config, then a value derived from the updated files, then
the constraints collected during extraction" applies everywhere. The helper
treats an empty string as not set at every step and accepts the
`PostUpdateConfig` shape, whose `constraints` may be `null`.

Behaviour changes that go beyond the new fallback to extracted constraints:

- `mix` applies its hardcoded erlang default only after the extracted
  constraint, so an erlang version collected at extraction can win over it.
- `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm
  constraint; `generateHelmEnvs()` takes that value instead of the config.
- `npm` (yarn): an upgrade of yarn without a new value now consults the user
  constraint before deriving one from package.json or the lock file.
- The "Using <tool> constraint from config" debug lines in bundler, composer,
  copier and pip-compile are gone, as the helper is the only reader of the
  config now.

Helpers that read the config synchronously became async: bundler
`getBundlerConstraint()`, copier `getPythonVersionConstraint()` and
`getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and
`getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and
`getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer
`getPhpConstraint()` is removed.

Each converted manager has a test showing the extracted constraint reaching
the executed tool, and, where a derive callback exists, that the derived value
still wins over it.

* refactor(linters): add prefer-resolve-tool-constraint rule

Reports member reads and destructuring of `constraints` and
`extractedConstraints` from a manager config in `lib/modules/manager/**`, so
that tool constraints are resolved through `resolveToolConstraint()` in
`lib/modules/manager/util.ts` only. Writes and the same properties on package
files, which extraction has to populate, are not reported. The helper itself
and spec files are exempt in `.oxlintrc.json`.

* refactor(manager): inline thin resolveToolConstraint wrappers

Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint /
getUvVersionConstraint helpers, which only forwarded to
resolveToolConstraint(). Callers now call it directly.

* docs(development): note lock file maintenance in tool constraints section

* refactor(manager): address review on tool constraint resolution

composer only runs extractConstraints() when a user constraint is missing,
via Lazy. UpdateArtifactsConfig no longer re-declares constraints and
extractedConstraints, which ToolConstraintsConfig already provides.
2026-09-14 11:09:07 +00:00

387 lines
11 KiB
TypeScript

import { split } from 'shlex';
import upath from 'upath';
import { logger } from '../../../logger/index.ts';
import { coerceArray, isNotNullOrUndefined } from '../../../util/array.ts';
import type {
ExecOptions,
ExtraEnv,
ToolConstraint,
} from '../../../util/exec/types.ts';
import { ensureCacheDir } from '../../../util/fs/index.ts';
import { ensureLocalPath } from '../../../util/fs/util.ts';
import * as hostRules from '../../../util/host-rules.ts';
import { regEx } from '../../../util/regex.ts';
import { parseUrl } from '../../../util/url.ts';
import type { PackageFileContent, UpdateArtifactsConfig } from '../types.ts';
import { resolveToolConstraint } from '../util.ts';
import type {
CommandType,
PipCompileArgs,
SupportedManagers,
} from './types.ts';
export async function getPythonVersionConstraint(
config: UpdateArtifactsConfig,
extractedPythonVersion: string | undefined,
): Promise<string | undefined> {
return await resolveToolConstraint(config, 'python', () => {
if (extractedPythonVersion) {
logger.debug('Using python constraint extracted from the lock file');
return `==${extractedPythonVersion}`;
}
return undefined;
});
}
export async function getToolVersionConstraint(
config: UpdateArtifactsConfig,
commandType: CommandType,
): Promise<ToolConstraint> {
if (commandType === 'uv') {
return {
toolName: 'uv',
constraint: await resolveToolConstraint(config, 'uv'),
};
}
return {
toolName: 'pip-tools',
constraint: await resolveToolConstraint(config, 'pipTools'),
};
}
export async function getExecOptions(
config: UpdateArtifactsConfig,
commandType: CommandType,
cwd: string,
extraEnv: ExtraEnv<string>,
extractedPythonVersion: string | undefined,
): Promise<ExecOptions> {
const constraint = await getPythonVersionConstraint(
config,
extractedPythonVersion,
);
const execOptions: ExecOptions = {
cwd: ensureLocalPath(cwd),
docker: {},
toolConstraints: [
{
toolName: 'python',
constraint,
},
await getToolVersionConstraint(config, commandType),
],
extraEnv: {
PIP_CACHE_DIR: await ensureCacheDir('pip'),
PIP_NO_INPUT: 'true', // ensure pip doesn't block forever waiting for credentials on stdin
PIP_KEYRING_PROVIDER: 'import',
PYTHON_KEYRING_BACKEND: 'keyrings.envvars.keyring.EnvvarsKeyring',
...extraEnv,
},
};
return execOptions;
}
export const constraintLineRegex = regEx(
/^(?:#.*?\r?\n)+# {4}(?<command>\S*)(?<arguments> .*?)?\r?\n/,
);
export const disallowedPipOptions = [
'--no-header', // header is required by this manager
];
const commonOptionsWithArguments = [
'--output-file',
'--extra',
'--extra-index-url',
];
const pipOptionsWithArguments = [
'--resolver',
'--constraint',
...commonOptionsWithArguments,
];
const uvOptionsWithArguments = [
'--constraints',
'--constraint', // singular alias accepted by uv
'--python-version',
'--no-emit-package',
'--prerelease',
'--format',
'--resolution',
'--fork-strategy',
'--exclude-newer',
'--exclude-newer-package',
'--group',
'--override',
'--overrides',
...commonOptionsWithArguments,
];
export const optionsWithArguments = [
...pipOptionsWithArguments,
...uvOptionsWithArguments,
];
const allowedCommonOptions = [
'-v',
'--generate-hashes',
'--emit-index-url',
'--index-url',
'--all-extras',
];
export const allowedOptions: Record<CommandType, string[]> = {
'pip-compile': [
'--allow-unsafe',
'--generate-hashes',
'--no-emit-index-url',
'--strip-extras',
...allowedCommonOptions,
...pipOptionsWithArguments,
],
uv: [
'--no-strip-extras',
'--universal',
...allowedCommonOptions,
...uvOptionsWithArguments,
],
custom: [],
};
// TODO(not7cd): test on all correct headers, even with CUSTOM_COMPILE_COMMAND
export function extractHeaderCommand(
content: string,
fileName: string,
): PipCompileArgs {
const compileCommand = constraintLineRegex.exec(content);
if (compileCommand?.groups === undefined) {
throw new Error(
`Failed to extract command from header in ${fileName} ${content}`,
);
}
logger.trace(
`pip-compile: found header in ${fileName}: \n${compileCommand[0]}`,
);
const command = compileCommand.groups.command;
const argv = [command];
let commandType: CommandType;
if (command === 'pip-compile') {
commandType = 'pip-compile';
} else if (command === 'uv') {
commandType = 'uv';
} else {
commandType = 'custom';
}
if (compileCommand.groups.arguments) {
argv.push(...split(compileCommand.groups.arguments));
}
logger.debug(
{ fileName, argv, commandType },
`pip-compile: extracted command from header`,
);
const result: PipCompileArgs = {
argv,
command,
commandType,
outputFile: '',
sourceFiles: [],
};
for (const arg of argv.slice(1)) {
if (commandType === 'uv' && ['pip', 'compile'].includes(arg)) {
continue;
}
// TODO(not7cd): check for "--option -- argument" case
if (!arg.startsWith('-')) {
result.sourceFiles.push(arg);
continue;
}
throwForDisallowedOption(arg);
throwForNoEqualSignInOptionWithArgument(arg);
throwForUnknownOption(commandType, arg);
if (arg.includes('=')) {
const [option, value] = arg.split('=');
if (option === '--extra') {
result.extra = coerceArray(result.extra);
result.extra.push(value);
} else if (option === '--extra-index-url') {
result.extraIndexUrl = coerceArray(result.extraIndexUrl);
result.extraIndexUrl.push(value);
// TODO: add to secrets? next PR
} else if (['--constraint', '--constraints'].includes(option)) {
result.constraintsFiles = coerceArray(result.constraintsFiles);
result.constraintsFiles.push(value);
} else if (['--override', '--overrides'].includes(option)) {
result.overridesFiles = coerceArray(result.overridesFiles);
result.overridesFiles.push(value);
} else if (option === '--output-file') {
if (result.outputFile) {
throw new Error('Cannot use multiple --output-file options');
}
result.outputFile = upath.normalize(value);
} else if (option === '--python-version') {
result.pythonVersion = value;
} else if (option === '--index-url') {
if (result.indexUrl) {
throw new Error('Cannot use multiple --index-url options');
}
result.indexUrl = value;
// TODO: add to secrets? next PR
} else {
logger.debug({ option }, `pip-compile: option not handled`);
}
continue;
}
if (arg === '--no-emit-index-url') {
result.noEmitIndexUrl = true;
continue;
}
if (arg === '--emit-index-url') {
result.emitIndexUrl = true;
continue;
}
if (arg === '--all-extras') {
result.allExtras = true;
continue;
}
logger.debug({ option: arg }, `pip-compile: option not handled`);
}
logger.trace(
{
...result,
},
'Parsed pip-compile command from header',
);
if (result.noEmitIndexUrl && result.emitIndexUrl) {
throw new Error('Cannot use both --no-emit-index-url and --emit-index-url');
}
if (result.sourceFiles.length === 0) {
throw new Error(
'No source files detected in command, pass at least one package file explicitly',
);
}
return result;
}
const pythonVersionRegex = regEx(
/^(?:#.*?\r?\n)*# This file is autogenerated by pip-compile with Python (?<pythonVersion>\d+(?:\.\d+)*)\s/,
'i',
);
export function extractPythonVersion(
content: string,
fileName: string,
): string | undefined {
const match = pythonVersionRegex.exec(content);
if (match?.groups === undefined) {
logger.warn(
{ fileName, content },
'pip-compile: failed to extract Python version from header in file',
);
return undefined;
}
logger.trace(
`pip-compile: found Python version header in ${fileName}: \n${match[0]}`,
);
const { pythonVersion } = match.groups;
logger.debug(
{ fileName, pythonVersion },
`pip-compile: extracted Python version from header`,
);
return pythonVersion;
}
function throwForDisallowedOption(arg: string): void {
if (disallowedPipOptions.includes(arg)) {
throw new Error(`Option ${arg} not allowed for this manager`);
}
}
function throwForNoEqualSignInOptionWithArgument(arg: string): void {
if (optionsWithArguments.includes(arg)) {
throw new Error(
`Option ${arg} must have equal sign '=' separating it's argument`,
);
}
}
function throwForUnknownOption(commandType: CommandType, arg: string): void {
if (arg.includes('=')) {
const [option] = arg.split('=');
if (allowedOptions[commandType].includes(option)) {
return;
}
}
if (allowedOptions[commandType].includes(arg)) {
return;
}
throw new Error(`Option ${arg} not supported (yet)`);
}
function getRegistryCredEnvVars(
url: URL,
index: number,
): Record<string, string> {
const hostRule = hostRules.find({ url: url.href });
logger.debug(hostRule, `Found host rule for url ${url.href}`);
const ret: Record<string, string> = {};
if (!!hostRule.username || !!hostRule.password) {
ret[`KEYRING_SERVICE_NAME_${index}`] = url.hostname;
ret[`KEYRING_SERVICE_USERNAME_${index}`] = hostRule.username ?? '';
ret[`KEYRING_SERVICE_PASSWORD_${index}`] = hostRule.password ?? '';
}
return ret;
}
function cleanUrl(url: string): URL | null {
// Strip everything but protocol, host, and port
const urlObj = parseUrl(url);
if (!urlObj) {
return null;
}
// origin of a valid URL is always parseable
return parseUrl(urlObj.origin);
}
export function getRegistryCredVarsFromPackageFiles(
packageFiles: PackageFileContent[],
): ExtraEnv<string> {
const urls: string[] = [];
for (const packageFile of packageFiles) {
urls.push(
...coerceArray(packageFile.registryUrls),
...coerceArray(packageFile.additionalRegistryUrls),
);
}
logger.debug(urls, 'Extracted registry URLs from package files');
const uniqueHosts = new Set<URL>(
urls.map(cleanUrl).filter(isNotNullOrUndefined),
);
let allCreds: ExtraEnv<string> = {};
for (const [index, host] of [...uniqueHosts].entries()) {
const hostCreds = getRegistryCredEnvVars(host, index);
allCreds = {
...allCreds,
...hostCreds,
};
}
return allCreds;
}
export function matchManager(filename: string): SupportedManagers | 'unknown' {
if (filename.endsWith('setup.py')) {
return 'pip_setup';
}
if (filename.endsWith('setup.cfg')) {
return 'setup-cfg';
}
if (filename.endsWith('pyproject.toml')) {
return 'pep621';
}
// naive, could be improved, maybe use pip_requirements.managerFilePatterns
if (filename.endsWith('.in') || filename.endsWith('.txt')) {
return 'pip_requirements';
}
return 'unknown';
}