mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
4b4d14ec00
* feat(manager): pass extracted constraints to updateArtifacts `extractedConstraints` were collected during extraction but only ever read by `fetch.ts` for the lookup. At artifact time every manager had to derive the same tool constraints a second time, and when the updated package file no longer carried the constraint there was nothing to fall back to. `generateBranchConfig()` now merges the `extractedConstraints` of all upgrades of a branch onto the branch config, which reaches `updateArtifacts()` through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares the field and documents what it contains. The new `resolveToolConstraint()` helper implements the ladder once: user `constraints` > an optional artifact-time derivation > the extracted value. The derivation is ranked above the extracted value on purpose: it reads the package files as the branch changed them, so poetry (python is an updatable dependency there), composer, pipenv (`pipenv` can be a dev package) and pep621 (`requires-python` is an updatable dependency) would otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and composer are migrated to the helper and keep their derivation. Behaviour change: these managers now use the extract-time constraint as a last resort instead of running unconstrained, for example on lock file maintenance where pipenv deletes `Pipfile.lock` before deriving. `execute-post-upgrade-commands.ts` is unaffected: it reads `upgrade.constraints` per upgrade, and the extracted values are kept in a separate field rather than folded into `constraints`, so post-upgrade task tool constraints still come from user config only. Not migrated, because their constraints are never extracted, so the fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`), pep621 uv (`required-version`) and npm's node ladder, whose last step already reads `package.json` engines. * refactor(manager): resolve tool constraints through resolveToolConstraint() Every manager now obtains the constraint of a tool it runs through `resolveToolConstraint()` instead of reading `config.constraints` itself, so the precedence "user config, then a value derived from the updated files, then the constraints collected during extraction" applies everywhere. The helper treats an empty string as not set at every step and accepts the `PostUpdateConfig` shape, whose `constraints` may be `null`. Behaviour changes that go beyond the new fallback to extracted constraints: - `mix` applies its hardcoded erlang default only after the extracted constraint, so an erlang version collected at extraction can win over it. - `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm constraint; `generateHelmEnvs()` takes that value instead of the config. - `npm` (yarn): an upgrade of yarn without a new value now consults the user constraint before deriving one from package.json or the lock file. - The "Using <tool> constraint from config" debug lines in bundler, composer, copier and pip-compile are gone, as the helper is the only reader of the config now. Helpers that read the config synchronously became async: bundler `getBundlerConstraint()`, copier `getPythonVersionConstraint()` and `getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and `getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and `getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer `getPhpConstraint()` is removed. Each converted manager has a test showing the extracted constraint reaching the executed tool, and, where a derive callback exists, that the derived value still wins over it. * refactor(linters): add prefer-resolve-tool-constraint rule Reports member reads and destructuring of `constraints` and `extractedConstraints` from a manager config in `lib/modules/manager/**`, so that tool constraints are resolved through `resolveToolConstraint()` in `lib/modules/manager/util.ts` only. Writes and the same properties on package files, which extraction has to populate, are not reported. The helper itself and spec files are exempt in `.oxlintrc.json`. * refactor(manager): inline thin resolveToolConstraint wrappers Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint / getUvVersionConstraint helpers, which only forwarded to resolveToolConstraint(). Callers now call it directly. * docs(development): note lock file maintenance in tool constraints section * refactor(manager): address review on tool constraint resolution composer only runs extractConstraints() when a user constraint is missing, via Lazy. UpdateArtifactsConfig no longer re-declares constraints and extractedConstraints, which ToolConstraintsConfig already provides.
231 lines
6.5 KiB
TypeScript
231 lines
6.5 KiB
TypeScript
import { isNonEmptyString } from '@sindresorhus/is';
|
|
import { quote } from 'shlex';
|
|
import upath from 'upath';
|
|
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import { exec } from '../../../util/exec/index.ts';
|
|
import type { ExecOptions } from '../../../util/exec/types.ts';
|
|
import {
|
|
ensureDir,
|
|
getLocalFiles,
|
|
getSiblingFileName,
|
|
outputCacheFile,
|
|
privateCacheDir,
|
|
writeLocalFile,
|
|
} from '../../../util/fs/index.ts';
|
|
import { getFiles } from '../../../util/git/index.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import type {
|
|
UpdateArtifact,
|
|
UpdateArtifactsConfig,
|
|
UpdateArtifactsResult,
|
|
Upgrade,
|
|
} from '../types.ts';
|
|
import { resolveToolConstraint } from '../util.ts';
|
|
import { createNuGetConfigXml } from './config-formatter.ts';
|
|
import {
|
|
DIRECTORY_BUILD_PROPS,
|
|
GLOBAL_JSON,
|
|
MSBUILD_CENTRAL_FILE,
|
|
NUGET_CENTRAL_FILE,
|
|
getDependentPackageFiles,
|
|
} from './package-tree.ts';
|
|
import type { Registry } from './types.ts';
|
|
import {
|
|
findGlobalJson,
|
|
getConfiguredRegistries,
|
|
getDefaultRegistries,
|
|
} from './util.ts';
|
|
|
|
async function createCachedNuGetConfigFile(
|
|
nugetCacheDir: string,
|
|
packageFileName: string,
|
|
updatedDeps: Upgrade[],
|
|
): Promise<string> {
|
|
const registries =
|
|
(await getConfiguredRegistries(packageFileName)) ?? getDefaultRegistries();
|
|
|
|
const updatedDepsRegistries: Registry[] = Array.from(
|
|
new Set(
|
|
updatedDeps
|
|
.flatMap((dep) => coerceArray(dep.registryUrls))
|
|
.filter(isNonEmptyString),
|
|
),
|
|
(url) => ({ url }),
|
|
);
|
|
|
|
const combinedRegistries = [...registries, ...updatedDepsRegistries];
|
|
|
|
const contents = createNuGetConfigXml(combinedRegistries);
|
|
|
|
const cachedNugetConfigFile = upath.join(nugetCacheDir, `nuget.config`);
|
|
await ensureDir(nugetCacheDir);
|
|
await outputCacheFile(cachedNugetConfigFile, contents);
|
|
|
|
return cachedNugetConfigFile;
|
|
}
|
|
|
|
async function runDotnetRestore(
|
|
packageFileName: string,
|
|
dependentPackageFileNames: string[],
|
|
config: UpdateArtifactsConfig,
|
|
updatedDeps: Upgrade[],
|
|
): Promise<void> {
|
|
const nugetCacheDir = upath.join(privateCacheDir(), 'nuget');
|
|
|
|
const nugetConfigFile = await createCachedNuGetConfigFile(
|
|
nugetCacheDir,
|
|
packageFileName,
|
|
updatedDeps,
|
|
);
|
|
|
|
const dotnetVersion = await resolveToolConstraint(
|
|
config,
|
|
'dotnet',
|
|
async () => (await findGlobalJson(packageFileName))?.sdk?.version,
|
|
);
|
|
const execOptions: ExecOptions = {
|
|
docker: {},
|
|
extraEnv: {
|
|
NUGET_PACKAGES: upath.join(nugetCacheDir, 'packages'),
|
|
MSBUILDDISABLENODEREUSE: '1',
|
|
},
|
|
toolConstraints: [{ toolName: 'dotnet', constraint: dotnetVersion }],
|
|
};
|
|
|
|
const cmds = dependentPackageFileNames.map(
|
|
(fileName) =>
|
|
`dotnet restore ${quote(
|
|
fileName,
|
|
)} --force-evaluate --configfile ${quote(nugetConfigFile)}`,
|
|
);
|
|
|
|
if (config.postUpdateOptions?.includes('dotnetWorkloadRestore')) {
|
|
cmds.unshift(
|
|
`dotnet workload restore --configfile ${quote(nugetConfigFile)}`,
|
|
);
|
|
}
|
|
|
|
await exec(cmds, execOptions);
|
|
}
|
|
|
|
export async function updateArtifacts({
|
|
packageFileName,
|
|
newPackageFileContent,
|
|
config,
|
|
updatedDeps,
|
|
}: UpdateArtifact): Promise<UpdateArtifactsResult[] | null> {
|
|
logger.debug(`nuget.updateArtifacts(${packageFileName})`);
|
|
|
|
// https://github.com/NuGet/Home/wiki/Centrally-managing-NuGet-package-versions
|
|
// https://github.com/microsoft/MSBuildSdks/tree/main/src/CentralPackageVersions
|
|
const isCentralManagement =
|
|
packageFileName === NUGET_CENTRAL_FILE ||
|
|
packageFileName === MSBUILD_CENTRAL_FILE ||
|
|
packageFileName.endsWith(`/${NUGET_CENTRAL_FILE}`) ||
|
|
packageFileName.endsWith(`/${MSBUILD_CENTRAL_FILE}`);
|
|
|
|
const isGlobalJson = packageFileName === GLOBAL_JSON;
|
|
|
|
const isDirectoryBuildProps =
|
|
packageFileName === DIRECTORY_BUILD_PROPS ||
|
|
packageFileName.endsWith(`/${DIRECTORY_BUILD_PROPS}`);
|
|
|
|
if (
|
|
!isCentralManagement &&
|
|
!isGlobalJson &&
|
|
!isDirectoryBuildProps &&
|
|
!regEx(/(?:cs|vb|fs)proj$/i).test(packageFileName)
|
|
) {
|
|
// This could be implemented in the future if necessary.
|
|
// It's not that easy though because the questions which
|
|
// project file to restore how to determine which lock files
|
|
// have been changed in such cases.
|
|
logger.debug(
|
|
{ packageFileName },
|
|
'Not updating lock file for non project files',
|
|
);
|
|
return null;
|
|
}
|
|
|
|
const deps = await getDependentPackageFiles(
|
|
packageFileName,
|
|
isCentralManagement || isDirectoryBuildProps,
|
|
isGlobalJson,
|
|
);
|
|
const packageFiles = deps.filter((d) => d.isLeaf).map((d) => d.name);
|
|
|
|
logger.trace(
|
|
{ packageFiles },
|
|
`Found ${packageFiles.length} dependent package files`,
|
|
);
|
|
|
|
const lockFileNames = deps.map((f) =>
|
|
getSiblingFileName(f.name, 'packages.lock.json'),
|
|
);
|
|
|
|
const existingLockFileContentMap = await getFiles(lockFileNames);
|
|
|
|
const hasLockFileContent = Object.values(existingLockFileContentMap).some(
|
|
(val) => !!val,
|
|
);
|
|
if (!hasLockFileContent) {
|
|
logger.debug(
|
|
{ packageFileName },
|
|
'No lock file found for package or dependents',
|
|
);
|
|
return null;
|
|
}
|
|
|
|
try {
|
|
if (updatedDeps.length === 0 && config.isLockFileMaintenance !== true) {
|
|
logger.debug(
|
|
`Not updating lock file because no deps changed and no lock file maintenance.`,
|
|
);
|
|
return null;
|
|
}
|
|
|
|
await writeLocalFile(packageFileName, newPackageFileContent);
|
|
|
|
await runDotnetRestore(packageFileName, packageFiles, config, updatedDeps);
|
|
|
|
const newLockFileContentMap = await getLocalFiles(lockFileNames);
|
|
|
|
const retArray: UpdateArtifactsResult[] = [];
|
|
for (const lockFileName of lockFileNames) {
|
|
if (
|
|
existingLockFileContentMap[lockFileName] ===
|
|
newLockFileContentMap[lockFileName]
|
|
) {
|
|
logger.trace(`Lock file ${lockFileName} is unchanged`);
|
|
} else if (newLockFileContentMap[lockFileName]) {
|
|
retArray.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: lockFileName,
|
|
contents: newLockFileContentMap[lockFileName],
|
|
},
|
|
});
|
|
}
|
|
// TODO: else should we return an artifact error if new content is missing?
|
|
}
|
|
|
|
return retArray.length > 0 ? retArray : null;
|
|
} catch (err) {
|
|
if (err.message === TEMPORARY_ERROR) {
|
|
throw err;
|
|
}
|
|
logger.debug({ err }, 'Failed to generate lock file');
|
|
return [
|
|
{
|
|
artifactError: {
|
|
fileName: lockFileNames.join(', '),
|
|
// error is written to stdout
|
|
stderr: err.stdout ?? err.message,
|
|
},
|
|
},
|
|
];
|
|
}
|
|
}
|