mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-31 17:51:49 +00:00
4b4d14ec00
* feat(manager): pass extracted constraints to updateArtifacts `extractedConstraints` were collected during extraction but only ever read by `fetch.ts` for the lookup. At artifact time every manager had to derive the same tool constraints a second time, and when the updated package file no longer carried the constraint there was nothing to fall back to. `generateBranchConfig()` now merges the `extractedConstraints` of all upgrades of a branch onto the branch config, which reaches `updateArtifacts()` through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares the field and documents what it contains. The new `resolveToolConstraint()` helper implements the ladder once: user `constraints` > an optional artifact-time derivation > the extracted value. The derivation is ranked above the extracted value on purpose: it reads the package files as the branch changed them, so poetry (python is an updatable dependency there), composer, pipenv (`pipenv` can be a dev package) and pep621 (`requires-python` is an updatable dependency) would otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and composer are migrated to the helper and keep their derivation. Behaviour change: these managers now use the extract-time constraint as a last resort instead of running unconstrained, for example on lock file maintenance where pipenv deletes `Pipfile.lock` before deriving. `execute-post-upgrade-commands.ts` is unaffected: it reads `upgrade.constraints` per upgrade, and the extracted values are kept in a separate field rather than folded into `constraints`, so post-upgrade task tool constraints still come from user config only. Not migrated, because their constraints are never extracted, so the fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`), pep621 uv (`required-version`) and npm's node ladder, whose last step already reads `package.json` engines. * refactor(manager): resolve tool constraints through resolveToolConstraint() Every manager now obtains the constraint of a tool it runs through `resolveToolConstraint()` instead of reading `config.constraints` itself, so the precedence "user config, then a value derived from the updated files, then the constraints collected during extraction" applies everywhere. The helper treats an empty string as not set at every step and accepts the `PostUpdateConfig` shape, whose `constraints` may be `null`. Behaviour changes that go beyond the new fallback to extracted constraints: - `mix` applies its hardcoded erlang default only after the extracted constraint, so an erlang version collected at extraction can win over it. - `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm constraint; `generateHelmEnvs()` takes that value instead of the config. - `npm` (yarn): an upgrade of yarn without a new value now consults the user constraint before deriving one from package.json or the lock file. - The "Using <tool> constraint from config" debug lines in bundler, composer, copier and pip-compile are gone, as the helper is the only reader of the config now. Helpers that read the config synchronously became async: bundler `getBundlerConstraint()`, copier `getPythonVersionConstraint()` and `getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and `getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and `getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer `getPhpConstraint()` is removed. Each converted manager has a test showing the extracted constraint reaching the executed tool, and, where a derive callback exists, that the derived value still wins over it. * refactor(linters): add prefer-resolve-tool-constraint rule Reports member reads and destructuring of `constraints` and `extractedConstraints` from a manager config in `lib/modules/manager/**`, so that tool constraints are resolved through `resolveToolConstraint()` in `lib/modules/manager/util.ts` only. Writes and the same properties on package files, which extraction has to populate, are not reported. The helper itself and spec files are exempt in `.oxlintrc.json`. * refactor(manager): inline thin resolveToolConstraint wrappers Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint / getUvVersionConstraint helpers, which only forwarded to resolveToolConstraint(). Callers now call it directly. * docs(development): note lock file maintenance in tool constraints section * refactor(manager): address review on tool constraint resolution composer only runs extractConstraints() when a user constraint is missing, via Lazy. UpdateArtifactsConfig no longer re-declares constraints and extractedConstraints, which ToolConstraintsConfig already provides.
231 lines
7.3 KiB
TypeScript
231 lines
7.3 KiB
TypeScript
import { isString, isTruthy } from '@sindresorhus/is';
|
|
import pMap from 'p-map';
|
|
import { quote } from 'shlex';
|
|
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { coerceArray } from '../../../util/array.ts';
|
|
import { exec } from '../../../util/exec/index.ts';
|
|
import type { ExecOptions, ToolConstraint } from '../../../util/exec/types.ts';
|
|
import {
|
|
getParentDir,
|
|
getSiblingFileName,
|
|
readLocalFile,
|
|
writeLocalFile,
|
|
} from '../../../util/fs/index.ts';
|
|
import { getRepoStatus } from '../../../util/git/index.ts';
|
|
import * as hostRules from '../../../util/host-rules.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import * as yaml from '../../../util/yaml.ts';
|
|
import { DockerDatasource } from '../../datasource/docker/index.ts';
|
|
import { HelmDatasource } from '../../datasource/helm/index.ts';
|
|
import type { UpdateArtifact, UpdateArtifactsResult } from '../types.ts';
|
|
import { resolveToolConstraint } from '../util.ts';
|
|
import { generateHelmEnvs, generateLoginCmd } from './common.ts';
|
|
import { isOCIRegistry, removeOCIPrefix } from './oci.ts';
|
|
import type { ChartDefinition, Repository, RepositoryRule } from './types.ts';
|
|
import {
|
|
aliasRecordToRepositories,
|
|
getRepositories,
|
|
isFileInDir,
|
|
} from './utils.ts';
|
|
|
|
async function helmCommands(
|
|
execOptions: ExecOptions,
|
|
manifestPath: string,
|
|
repositories: Repository[],
|
|
): Promise<void> {
|
|
const cmd: string[] = [];
|
|
// get OCI registries and detect host rules
|
|
const registries: RepositoryRule[] = repositories
|
|
.filter(isOCIRegistry)
|
|
.map((value) => {
|
|
return {
|
|
...value,
|
|
repository: removeOCIPrefix(value.repository),
|
|
hostRule: hostRules.find({
|
|
url: value.repository.replace('oci://', 'https://'), //TODO we need to replace this, as oci:// will not be accepted as protocol
|
|
hostType: DockerDatasource.id,
|
|
}),
|
|
};
|
|
});
|
|
|
|
// if credentials for the registry have been found, log into it
|
|
await pMap(registries, async (value) => {
|
|
const loginCmd = await generateLoginCmd(value);
|
|
if (loginCmd) {
|
|
cmd.push(loginCmd);
|
|
}
|
|
});
|
|
|
|
// find classic Chart repositories and fitting host rules
|
|
const classicRepositories: RepositoryRule[] = repositories
|
|
.filter((repository) => !isOCIRegistry(repository))
|
|
.map((value) => {
|
|
return {
|
|
...value,
|
|
hostRule: hostRules.find({
|
|
url: value.repository,
|
|
hostType: HelmDatasource.id,
|
|
}),
|
|
};
|
|
});
|
|
|
|
// add helm repos if an alias or credentials for the url are defined
|
|
classicRepositories.forEach((value) => {
|
|
const { username, password } = value.hostRule;
|
|
const parameters = [`${quote(value.repository)}`, `--force-update`];
|
|
const isPrivateRepo = username && password;
|
|
if (isPrivateRepo) {
|
|
parameters.push(`--username ${quote(username)}`);
|
|
parameters.push(`--password ${quote(password)}`);
|
|
}
|
|
|
|
cmd.push(`helm repo add ${quote(value.name)} ${parameters.join(' ')}`);
|
|
});
|
|
|
|
cmd.push(`helm dependency update ${quote(getParentDir(manifestPath))}`);
|
|
|
|
await exec(cmd, execOptions);
|
|
}
|
|
|
|
export async function updateArtifacts({
|
|
packageFileName,
|
|
updatedDeps,
|
|
newPackageFileContent,
|
|
config,
|
|
}: UpdateArtifact): Promise<UpdateArtifactsResult[] | null> {
|
|
logger.debug(`helmv3.updateArtifacts(${packageFileName})`);
|
|
|
|
const { isLockFileMaintenance } = config;
|
|
const isUpdateOptionAddChartArchives = config.postUpdateOptions?.includes(
|
|
'helmUpdateSubChartArchives',
|
|
);
|
|
|
|
if (
|
|
!isLockFileMaintenance &&
|
|
(updatedDeps === undefined || updatedDeps.length < 1)
|
|
) {
|
|
logger.debug('No updated helmv3 deps - returning null');
|
|
return null;
|
|
}
|
|
|
|
const lockFileName = getSiblingFileName(packageFileName, 'Chart.lock');
|
|
const existingLockFileContent = await readLocalFile(lockFileName, 'utf8');
|
|
if (!existingLockFileContent && !isUpdateOptionAddChartArchives) {
|
|
logger.debug('No Chart.lock found');
|
|
return null;
|
|
}
|
|
try {
|
|
// get repositories and registries defined in the package file
|
|
// TODO: use schema (#9610)
|
|
const packages = yaml.parseSingleYaml<ChartDefinition>(
|
|
newPackageFileContent,
|
|
);
|
|
const locks = existingLockFileContent
|
|
? yaml.parseSingleYaml<ChartDefinition>(existingLockFileContent)
|
|
: { dependencies: [] };
|
|
|
|
const chartDefinitions: ChartDefinition[] = [];
|
|
// prioritize registryAlias naming for Helm repositories
|
|
if (config.registryAliases) {
|
|
chartDefinitions.push({
|
|
dependencies: aliasRecordToRepositories(config.registryAliases),
|
|
});
|
|
}
|
|
chartDefinitions.push(packages, locks);
|
|
|
|
const repositories = getRepositories(chartDefinitions);
|
|
|
|
await writeLocalFile(packageFileName, newPackageFileContent);
|
|
logger.debug('Updating Helm artifacts');
|
|
const helmToolConstraint: ToolConstraint = {
|
|
toolName: 'helm',
|
|
constraint: await resolveToolConstraint(config, 'helm'),
|
|
};
|
|
|
|
const execOptions: ExecOptions = {
|
|
docker: {},
|
|
extraEnv: generateHelmEnvs(),
|
|
toolConstraints: [helmToolConstraint],
|
|
};
|
|
await helmCommands(execOptions, packageFileName, repositories);
|
|
logger.debug('Returning updated Helm artifacts');
|
|
|
|
const fileChanges: UpdateArtifactsResult[] = [];
|
|
|
|
if (isTruthy(existingLockFileContent)) {
|
|
const newHelmLockContent = await readLocalFile(lockFileName, 'utf8');
|
|
const isLockFileChanged =
|
|
!isString(newHelmLockContent) ||
|
|
isHelmLockChanged(existingLockFileContent, newHelmLockContent);
|
|
if (isLockFileChanged) {
|
|
fileChanges.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: lockFileName,
|
|
contents: newHelmLockContent,
|
|
},
|
|
});
|
|
} else {
|
|
logger.debug('Chart.lock is unchanged');
|
|
}
|
|
}
|
|
|
|
// add modified helm chart archives to artifacts
|
|
if (isTruthy(isUpdateOptionAddChartArchives)) {
|
|
const chartsPath = getSiblingFileName(packageFileName, 'charts');
|
|
const status = await getRepoStatus();
|
|
const chartsAddition = coerceArray(status.not_added);
|
|
const chartsDeletion = coerceArray(status.deleted);
|
|
|
|
for (const file of chartsAddition) {
|
|
// only add artifacts in the chart sub path
|
|
if (!isFileInDir(chartsPath, file)) {
|
|
continue;
|
|
}
|
|
fileChanges.push({
|
|
file: {
|
|
type: 'addition',
|
|
path: file,
|
|
contents: await readLocalFile(file),
|
|
},
|
|
});
|
|
}
|
|
|
|
for (const file of chartsDeletion) {
|
|
// only add artifacts in the chart sub path
|
|
if (!isFileInDir(chartsPath, file)) {
|
|
continue;
|
|
}
|
|
fileChanges.push({
|
|
file: {
|
|
type: 'deletion',
|
|
path: file,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
|
|
return fileChanges.length > 0 ? fileChanges : null;
|
|
} catch (err) {
|
|
// istanbul ignore if
|
|
if (err.message === TEMPORARY_ERROR) {
|
|
throw err;
|
|
}
|
|
logger.debug({ err }, 'Failed to update Helm lock file');
|
|
return [
|
|
{
|
|
artifactError: {
|
|
fileName: lockFileName,
|
|
stderr: err.message,
|
|
},
|
|
},
|
|
];
|
|
}
|
|
}
|
|
|
|
function isHelmLockChanged(oldContent: string, newContent: string): boolean {
|
|
const regex = regEx(/^generated: ".+"$/m);
|
|
return newContent.replace(regex, '') !== oldContent.replace(regex, '');
|
|
}
|