mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
Sebastian Poxhofer
16ef1715e9
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules Flag ad-hoc type checks that have @sindresorhus/is equivalents: - .filter(Boolean) -> .filter(isTruthy) - typeof x === 'string' -> isString(x) - x === null || x === undefined -> isNullOrUndefined(x) (and negation) The typeof x === 'object' shape lives in a separate suggestion-only rule (renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject() are not drop-in equivalents: null, arrays and functions behave differently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: fix renovate/prefer-is-helpers violations Replace ad-hoc type checks with @sindresorhus/is helpers across lib/: - 13x .filter(Boolean) -> .filter(isTruthy) - 36x typeof x ==/!== 'string' -> isString(x) / !isString(x) - 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation) Promote renovate/prefer-is-helpers to error now that the codebase is clean. renovate/prefer-is-object stays at warn: its 15 remaining sites guard parsed YAML/JSON or unknown values where isObject()/isPlainObject() are not provably equivalent (null/array/function semantics). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: enforce renovate/prefer-is-object at error level Resolve the 15 remaining warnings and raise the rule from warn to error: - Migrate 10 sites to isObject() where the guarded value provably cannot be a function (parsed YAML/JSON, typed exec command arguments, or test-controlled fixtures): helm-values, woodpecker, bun, pre-commit managers, exec utils, file package cache, and the github http spec. In the bun manager this also fixes a latent crash where a null `workspaces` value would throw on the `in` operator. - Keep 5 sites as reasoned oxlint-disable comments where excluding functions is load-bearing: the byte-exact fingerprint canonicalizer (2), the circularity walker, the zod result guard, and the generic hasKey helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
44 lines
1.2 KiB
TypeScript
44 lines
1.2 KiB
TypeScript
import { isObject, isString } from '@sindresorhus/is';
|
|
import { hasKey } from '../../../util/object.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import type { HelmDockerImageDependency } from './types.ts';
|
|
|
|
const parentKeyRe = regEx(/image$/i);
|
|
|
|
/**
|
|
* Type guard to determine whether a given partial Helm values.yaml object potentially
|
|
* defines a Helm Docker dependency.
|
|
*
|
|
* There is no exact standard of how Docker dependencies are defined in Helm
|
|
* values.yaml files (as of February 26th 2021), this function defines a
|
|
* heuristic based on the most commonly used format in the Helm charts:
|
|
*
|
|
* image:
|
|
* repository: 'something'
|
|
* tag: v1.0.0
|
|
* image:
|
|
* repository: 'something'
|
|
* version: v1.0.0
|
|
* renovateImage:
|
|
* repository: 'something'
|
|
* tag: v1.0.0
|
|
*/
|
|
export function matchesHelmValuesDockerHeuristic(
|
|
parentKey: string,
|
|
data: unknown,
|
|
): data is HelmDockerImageDependency {
|
|
return !!(
|
|
parentKeyRe.test(parentKey) &&
|
|
isObject(data) &&
|
|
hasKey('repository', data) &&
|
|
(hasKey('tag', data) || hasKey('version', data))
|
|
);
|
|
}
|
|
|
|
export function matchesHelmValuesInlineImage(
|
|
parentKey: string,
|
|
data: unknown,
|
|
): data is string {
|
|
return !!(parentKeyRe.test(parentKey) && data && isString(data));
|
|
}
|