Files
renovate/lib/modules/manager/composer/artifacts.ts
Michael Kriese 55a7341be2 test(manager): close long-tail branch coverage gaps (#45954)
* test(manager): close azure-pipelines, bundler and cocoapods gaps

Adds a pipeline whose step task is not versioned, so nothing is
extracted, and a gem lock line carrying no version, which is skipped.

Marks four guards that cannot be false: `extractContainer()` always
returns a dep, `getLockFilePath()` always returns a path, and the
cocoapods dep name, spec name and git account all derive from values
their enclosing check already proved present.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): close cargo, composer and cpanfile gaps

Adds a composer repository map that disables something other than
packagist, which is dropped rather than recorded.

Marks five guards: the cargo warning only fires for a crate dep and its
retry only runs when a dep was already current, a gitlab rule without a
token never passes the auth check, and both cpanfile handlers run only
once their match produced a value.

Two implicit elses stay counted, in the cargo version resolver and the
composer repository mapper, since a coverage-ignore hint does not attach
to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): close deps-edn, docker-compose and dockerfile gaps

Adds three extractions: a deps.edn alias whose value is not a map, a
compose extension carrying no image, and a dockerfile escape directive
naming a character other than a backtick, which leaves the default in
place.

Marks the deps-edn repository name check, since object keys are always
strings, and notes the repository spec chain, where a coverage-ignore
hint does not attach to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager/flux): close the flux coverage gaps

Adds two GitRepository resources whose url is ssh rather than http, one
pinned to a tag and one to a commit. Neither yields a source url, since
only http urls can be turned into one.

Marks the Kustomization image guard: the schema rejects an image without
a name, so `extractImage()` cannot return null there.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): mark github-actions, gitlabci and glasskube guards

None of these six needs a test. A parsed action ref is either a docker
or a repository ref, `getDep()` always returns a dep for a job container
and a service, and the remaining three need a listed file that cannot be
read, a listed file that yields no deps, or a manifest whose
repositories match no name.

The glasskube resource kind chain stays counted, since a coverage-ignore
hint does not attach to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): mark gomod and gradle-wrapper guards

Four guards that need setups no test provides: a removed dep that is not
added back, a go.mod the replace massaging leaves unchanged, and a
daemon-jvm file carrying no toolchain version. A parsed go directive
always yields a version.

The additional-dependency count chain stays counted, since a
coverage-ignore hint does not attach to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

---------

Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io>
2026-09-15 07:10:10 +00:00

292 lines
8.6 KiB
TypeScript

import { isEmptyObject, isString } from '@sindresorhus/is';
import { quote } from 'shlex';
import { z } from 'zod/v4';
import {
SYSTEM_INSUFFICIENT_DISK_SPACE,
TEMPORARY_ERROR,
} from '../../../constants/error-messages.ts';
import { logger } from '../../../logger/index.ts';
import { coerceArray } from '../../../util/array.ts';
import {
findGithubToken,
takePersonalAccessTokenIfPossible,
} from '../../../util/check-token.ts';
import { exec } from '../../../util/exec/index.ts';
import type {
CommandWithOptions,
ExecOptions,
ToolConstraint,
} from '../../../util/exec/types.ts';
import {
deleteLocalFile,
ensureCacheDir,
ensureLocalDir,
getSiblingFileName,
localPathExists,
readLocalFile,
writeLocalFile,
} from '../../../util/fs/index.ts';
import { getRepoStatus } from '../../../util/git/index.ts';
import * as hostRules from '../../../util/host-rules.ts';
import { Lazy } from '../../../util/lazy.ts';
import { coerceObject } from '../../../util/object.ts';
import { regEx } from '../../../util/regex.ts';
import { Json } from '../../../util/schema-utils/index.ts';
import { coerceString } from '../../../util/string.ts';
import { GitTagsDatasource } from '../../datasource/git-tags/index.ts';
import { PackagistDatasource } from '../../datasource/packagist/index.ts';
import type { UpdateArtifact, UpdateArtifactsResult } from '../types.ts';
import { resolveToolConstraint } from '../util.ts';
import { Lockfile, PackageFile } from './schema.ts';
import type { AuthJson } from './types.ts';
import {
extractConstraints,
getComposerArguments,
getComposerUpdateArguments,
isArtifactAuthEnabled,
requireComposerDependencyInstallation,
} from './utils.ts';
function getAuthJson(): string | null {
const authJson: AuthJson = {};
const githubHostRule = hostRules.find({
hostType: 'github',
url: 'https://api.github.com/',
});
const gitTagsHostRule = hostRules.find({
hostType: GitTagsDatasource.id,
url: 'https://github.com',
});
const selectedGithubToken = takePersonalAccessTokenIfPossible(
isArtifactAuthEnabled(githubHostRule)
? findGithubToken(githubHostRule)
: undefined,
isArtifactAuthEnabled(gitTagsHostRule)
? findGithubToken(gitTagsHostRule)
: undefined,
);
if (selectedGithubToken) {
authJson['github-oauth'] = {
'github.com': selectedGithubToken,
};
}
for (const gitlabHostRule of hostRules.findAll({ hostType: 'gitlab' })) {
if (!isArtifactAuthEnabled(gitlabHostRule)) {
continue;
}
// v8 ignore else -- a rule without a token does not pass the check above
if (gitlabHostRule?.token) {
const host = coerceString(gitlabHostRule.resolvedHost, 'gitlab.com');
authJson['gitlab-token'] = coerceObject(authJson['gitlab-token']);
authJson['gitlab-token'][host] = gitlabHostRule.token;
// https://getcomposer.org/doc/articles/authentication-for-private-packages.md#gitlab-token
authJson['gitlab-domains'] = [
host,
...coerceArray(authJson['gitlab-domains']),
];
}
}
for (const packagistHostRule of hostRules.findAll({
hostType: PackagistDatasource.id,
})) {
if (!isArtifactAuthEnabled(packagistHostRule)) {
continue;
}
const { resolvedHost, username, password, token } = packagistHostRule;
if (resolvedHost && username && password) {
authJson['http-basic'] = coerceObject(authJson['http-basic']);
authJson['http-basic'][resolvedHost] = { username, password };
} else if (resolvedHost && token) {
authJson.bearer = coerceObject(authJson.bearer);
authJson.bearer[resolvedHost] = token;
}
}
return isEmptyObject(authJson) ? null : JSON.stringify(authJson);
}
export async function updateArtifacts({
packageFileName,
updatedDeps,
newPackageFileContent,
config,
}: UpdateArtifact): Promise<UpdateArtifactsResult[] | null> {
logger.debug(`composer.updateArtifacts(${packageFileName})`);
const file = Json.pipe(PackageFile).parse(newPackageFileContent);
const lockFileName = packageFileName.replace(regEx(/\.json$/), '.lock');
const lockfile = await z
.string()
.transform((f) => readLocalFile(f, 'utf8'))
.pipe(Json)
.pipe(Lockfile)
.nullable()
.catch(null)
.parseAsync(lockFileName);
if (!lockfile) {
logger.debug('Composer: unable to read lockfile');
return null;
}
const vendorDir = getSiblingFileName(packageFileName, 'vendor');
const commitVendorFiles = await localPathExists(vendorDir);
await ensureLocalDir(vendorDir);
try {
await writeLocalFile(packageFileName, newPackageFileContent);
// `extractConstraints()` re-reads the updated package file, so its values win
// over what extraction saw on the base branch. It only runs when a user
// constraint is missing for at least one of the tools.
const fileConstraints = new Lazy(() => extractConstraints(file, lockfile));
const composerToolConstraint: ToolConstraint = {
toolName: 'composer',
constraint: await resolveToolConstraint(
config,
'composer',
() => fileConstraints.getValue().composer,
),
};
const phpToolConstraint: ToolConstraint = {
toolName: 'php',
constraint: await resolveToolConstraint(
config,
'php',
() => fileConstraints.getValue().php,
),
};
const execOptions: ExecOptions = {
cwdFile: packageFileName,
extraEnv: {
COMPOSER_CACHE_DIR: await ensureCacheDir('composer'),
COMPOSER_AUTH: getAuthJson(),
},
toolConstraints: [phpToolConstraint, composerToolConstraint],
docker: {},
};
const commands: (string | CommandWithOptions)[] = [];
// Determine whether install is required before update
if (requireComposerDependencyInstallation(lockfile)) {
const preCmd = 'composer';
const preArgs = `install${getComposerArguments(config, composerToolConstraint)}`;
logger.trace({ preCmd, preArgs }, 'composer pre-update command');
commands.push('git stash -- composer.json');
commands.push(`${preCmd} ${preArgs}`);
commands.push({ command: ['git', 'stash', 'pop'], ignoreFailure: true });
}
if (config.isLockFileMaintenance) {
logger.debug(
`Removing ${lockFileName} first due to lock file maintenance upgrade`,
);
await deleteLocalFile(lockFileName);
}
const cmd = 'composer';
let args: string;
if (config.isLockFileMaintenance) {
args = 'update';
} else {
args =
(
'update ' +
updatedDeps
.map((dep) =>
dep.newVersion
? quote(`${dep.depName}:${dep.newVersion}`)
: quote(dep.depName!),
)
.filter(isString)
.map((dep) => quote(dep))
.join(' ')
).trim() +
(config.postUpdateOptions?.includes('composerWithAll')
? ' --with-all-dependencies'
: ' --with-dependencies');
}
args += getComposerUpdateArguments(config, composerToolConstraint);
logger.trace({ cmd, args }, 'composer command');
commands.push(`${cmd} ${args}`);
await exec(commands, execOptions);
const status = await getRepoStatus();
if (!status.modified.includes(lockFileName)) {
return null;
}
logger.debug('Returning updated composer.lock');
const res: UpdateArtifactsResult[] = [
{
file: {
type: 'addition',
path: lockFileName,
contents: await readLocalFile(lockFileName),
},
},
];
if (!commitVendorFiles) {
return res;
}
logger.debug(`Committing vendor files in ${vendorDir}`);
for (const f of [...status.modified, ...status.not_added]) {
if (f.startsWith(vendorDir)) {
res.push({
file: {
type: 'addition',
path: f,
contents: await readLocalFile(f),
},
});
}
}
for (const f of status.deleted) {
res.push({
file: {
type: 'deletion',
path: f,
},
});
}
return res;
} catch (err) {
// istanbul ignore if
if (err.message === TEMPORARY_ERROR) {
throw err;
}
if (
err.message?.includes(
'Your requirements could not be resolved to an installable set of packages.',
)
) {
logger.info('Composer requirements cannot be resolved');
} else if (err.message?.includes('write error (disk full?)')) {
throw new Error(SYSTEM_INSUFFICIENT_DISK_SPACE);
} else {
logger.debug({ err }, 'Failed to generate composer.lock');
}
return [
{
artifactError: {
fileName: lockFileName,
stderr: err.message,
},
},
];
}
}