Files
Michael Kriese 55a7341be2 test(manager): close long-tail branch coverage gaps (#45954)
* test(manager): close azure-pipelines, bundler and cocoapods gaps

Adds a pipeline whose step task is not versioned, so nothing is
extracted, and a gem lock line carrying no version, which is skipped.

Marks four guards that cannot be false: `extractContainer()` always
returns a dep, `getLockFilePath()` always returns a path, and the
cocoapods dep name, spec name and git account all derive from values
their enclosing check already proved present.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): close cargo, composer and cpanfile gaps

Adds a composer repository map that disables something other than
packagist, which is dropped rather than recorded.

Marks five guards: the cargo warning only fires for a crate dep and its
retry only runs when a dep was already current, a gitlab rule without a
token never passes the auth check, and both cpanfile handlers run only
once their match produced a value.

Two implicit elses stay counted, in the cargo version resolver and the
composer repository mapper, since a coverage-ignore hint does not attach
to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): close deps-edn, docker-compose and dockerfile gaps

Adds three extractions: a deps.edn alias whose value is not a map, a
compose extension carrying no image, and a dockerfile escape directive
naming a character other than a backtick, which leaves the default in
place.

Marks the deps-edn repository name check, since object keys are always
strings, and notes the repository spec chain, where a coverage-ignore
hint does not attach to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager/flux): close the flux coverage gaps

Adds two GitRepository resources whose url is ssh rather than http, one
pinned to a tag and one to a commit. Neither yields a source url, since
only http urls can be turned into one.

Marks the Kustomization image guard: the schema rejects an image without
a name, so `extractImage()` cannot return null there.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): mark github-actions, gitlabci and glasskube guards

None of these six needs a test. A parsed action ref is either a docker
or a repository ref, `getDep()` always returns a dep for a job container
and a service, and the remaining three need a listed file that cannot be
read, a listed file that yields no deps, or a manifest whose
repositories match no name.

The glasskube resource kind chain stays counted, since a coverage-ignore
hint does not attach to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

* test(manager): mark gomod and gradle-wrapper guards

Four guards that need setups no test provides: a removed dep that is not
added back, a go.mod the replace massaging leaves unchanged, and a
daemon-jvm file carrying no toolchain version. A parsed go directive
always yields a version.

The additional-dependency count chain stays counted, since a
coverage-ignore hint does not attach to an `else if`.

Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io>

---------

Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io>
2026-09-15 07:10:10 +00:00

100 lines
3.0 KiB
TypeScript

import { logger } from '../../../logger/index.ts';
import {
getSiblingFileName,
localPathExists,
readLocalFile,
} from '../../../util/fs/index.ts';
import { regEx } from '../../../util/regex.ts';
import type { UpdateArtifact } from '../types.ts';
import { resolveToolConstraint } from '../util.ts';
export const delimiters = ['"', "'"];
export function extractRubyVersion(txt: string): string | null {
const rubyMatch = regEx(/^ruby\s+(?<version>"[^"]+"|'[^']+')\s*$/gm).exec(
txt,
);
if (!rubyMatch?.groups) {
return null;
}
const quotedVersion = rubyMatch.groups.version;
return quotedVersion.substring(1, quotedVersion.length - 1);
}
async function getRubyConstraintFromFiles(
packageFileName: string,
newPackageFileContent: string,
): Promise<string | null> {
const rubyMatch = extractRubyVersion(newPackageFileContent);
if (rubyMatch) {
logger.debug('Using ruby version from gemfile');
return rubyMatch;
}
for (const file of ['.ruby-version', '.tool-versions']) {
const rubyVersion = (
await readLocalFile(getSiblingFileName(packageFileName, file), 'utf8')
)?.match(regEx(/^(?:ruby(?:-|\s+))?(?<version>\d[\d.]*)/m))?.groups
?.version;
if (rubyVersion) {
logger.debug(`Using ruby version specified in ${file}`);
return rubyVersion;
}
}
const lockFile = await getLockFilePath(packageFileName);
// v8 ignore else -- `getLockFilePath()` always returns a path
if (lockFile) {
const rubyVersion = (await readLocalFile(lockFile, 'utf8'))?.match(
regEx(/^ {3}ruby (?<version>\d[\d.]*)(?:[a-z]|\s|$)/m),
)?.groups?.version;
if (rubyVersion) {
logger.debug(`Using ruby version specified in lock file`);
return rubyVersion;
}
}
return null;
}
export async function getRubyConstraint(
updateArtifact: UpdateArtifact,
): Promise<string | undefined> {
const { packageFileName, config, newPackageFileContent } = updateArtifact;
return await resolveToolConstraint(config, 'ruby', () =>
getRubyConstraintFromFiles(packageFileName, newPackageFileContent),
);
}
function getBundlerConstraintFromLockFile(
existingLockFileContent: string,
): string | null {
const bundledWith = regEx(/\nBUNDLED WITH\n\s+(?<version>.*?)(?:\n|$)/).exec(
existingLockFileContent,
);
if (bundledWith) {
logger.debug('Using bundler version specified in lockfile');
return bundledWith.groups!.version;
}
return null;
}
export async function getBundlerConstraint(
updateArtifact: Pick<UpdateArtifact, 'config'>,
existingLockFileContent: string,
): Promise<string | undefined> {
const { config } = updateArtifact;
return await resolveToolConstraint(config, 'bundler', () =>
getBundlerConstraintFromLockFile(existingLockFileContent),
);
}
export async function getLockFilePath(
packageFilePath: string,
): Promise<string> {
const lockFilePath = (await localPathExists(`${packageFilePath}.lock`))
? `${packageFilePath}.lock`
: `Gemfile.lock`;
logger.debug(`Lockfile for ${packageFilePath} found in ${lockFilePath}`);
return lockFilePath;
}