Files
renovate/lib/modules/manager/bun/artifacts.spec.ts
Sebastian Poxhofer 4b4d14ec00 feat(manager): pass extracted constraints to updateArtifacts (#45826)
* feat(manager): pass extracted constraints to updateArtifacts

`extractedConstraints` were collected during extraction but only ever read
by `fetch.ts` for the lookup. At artifact time every manager had to derive
the same tool constraints a second time, and when the updated package file
no longer carried the constraint there was nothing to fall back to.

`generateBranchConfig()` now merges the `extractedConstraints` of all
upgrades of a branch onto the branch config, which reaches `updateArtifacts()`
through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares
the field and documents what it contains.

The new `resolveToolConstraint()` helper implements the ladder once:
user `constraints` > an optional artifact-time derivation > the extracted
value. The derivation is ranked above the extracted value on purpose: it
reads the package files as the branch changed them, so poetry (python is an
updatable dependency there), composer, pipenv (`pipenv` can be a dev
package) and pep621 (`requires-python` is an updatable dependency) would
otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and
composer are migrated to the helper and keep their derivation.

Behaviour change: these managers now use the extract-time constraint as a
last resort instead of running unconstrained, for example on lock file
maintenance where pipenv deletes `Pipfile.lock` before deriving.

`execute-post-upgrade-commands.ts` is unaffected: it reads
`upgrade.constraints` per upgrade, and the extracted values are kept in a
separate field rather than folded into `constraints`, so post-upgrade task
tool constraints still come from user config only.

Not migrated, because their constraints are never extracted, so the
fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`),
pep621 uv (`required-version`) and npm's node ladder, whose last step
already reads `package.json` engines.

* refactor(manager): resolve tool constraints through resolveToolConstraint()

Every manager now obtains the constraint of a tool it runs through
`resolveToolConstraint()` instead of reading `config.constraints` itself, so
the precedence "user config, then a value derived from the updated files, then
the constraints collected during extraction" applies everywhere. The helper
treats an empty string as not set at every step and accepts the
`PostUpdateConfig` shape, whose `constraints` may be `null`.

Behaviour changes that go beyond the new fallback to extracted constraints:

- `mix` applies its hardcoded erlang default only after the extracted
  constraint, so an erlang version collected at extraction can win over it.
- `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm
  constraint; `generateHelmEnvs()` takes that value instead of the config.
- `npm` (yarn): an upgrade of yarn without a new value now consults the user
  constraint before deriving one from package.json or the lock file.
- The "Using <tool> constraint from config" debug lines in bundler, composer,
  copier and pip-compile are gone, as the helper is the only reader of the
  config now.

Helpers that read the config synchronously became async: bundler
`getBundlerConstraint()`, copier `getPythonVersionConstraint()` and
`getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and
`getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and
`getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer
`getPhpConstraint()` is removed.

Each converted manager has a test showing the extracted constraint reaching
the executed tool, and, where a derive callback exists, that the derived value
still wins over it.

* refactor(linters): add prefer-resolve-tool-constraint rule

Reports member reads and destructuring of `constraints` and
`extractedConstraints` from a manager config in `lib/modules/manager/**`, so
that tool constraints are resolved through `resolveToolConstraint()` in
`lib/modules/manager/util.ts` only. Writes and the same properties on package
files, which extraction has to populate, are not reported. The helper itself
and spec files are exempt in `.oxlintrc.json`.

* refactor(manager): inline thin resolveToolConstraint wrappers

Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint /
getUvVersionConstraint helpers, which only forwarded to
resolveToolConstraint(). Callers now call it directly.

* docs(development): note lock file maintenance in tool constraints section

* refactor(manager): address review on tool constraint resolution

composer only runs extractConstraints() when a user constraint is missing,
via Lazy. UpdateArtifactsConfig no longer re-declares constraints and
extractedConstraints, which ToolConstraintsConfig already provides.
2026-09-14 11:09:07 +00:00

423 lines
14 KiB
TypeScript

import { fs } from '~test/util.ts';
import { GlobalConfig } from '../../../config/global.ts';
import type {
InternalGlobalConfigOptions,
RepoGlobalConfig,
} from '../../../config/types.ts';
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
import { ExecError } from '../../../util/exec/exec-error.ts';
import { exec as _exec } from '../../../util/exec/index.ts';
import type { UpdateArtifact } from '../types.ts';
import { updateArtifacts } from './artifacts.ts';
vi.mock('../../../util/exec/index.ts');
vi.mock('../../../util/fs/index.ts');
const exec = vi.mocked(_exec);
const globalConfig: RepoGlobalConfig & InternalGlobalConfigOptions = {
localDir: '',
binarySource: 'global',
};
describe('modules/manager/bun/artifacts', () => {
describe('updateArtifacts()', () => {
let updateArtifact: UpdateArtifact;
beforeEach(() => {
GlobalConfig.set(globalConfig);
updateArtifact = {
config: {},
newPackageFileContent: '',
packageFileName: '',
updatedDeps: [],
};
});
it('skips if no updatedDeps and no lockFileMaintenance', async () => {
await expect(updateArtifacts(updateArtifact)).resolves.toBeNull();
});
it('skips if no lock file in config', async () => {
updateArtifact.updatedDeps = [{}];
await expect(updateArtifacts(updateArtifact)).resolves.toBeNull();
});
describe('when using .lockb lockfile format', () => {
it('skips if cannot read lock file', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lockb'] },
];
await expect(updateArtifacts(updateArtifact)).resolves.toBeNull();
});
it('returns null if lock content unchanged', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lockb'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toBeNull();
});
it('returns updated lock content', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lockb'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
// npmrc
fs.readLocalFile.mockResolvedValueOnce('# dummy');
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{
file: {
path: 'bun.lockb',
type: 'addition',
contents: newLock,
},
},
]);
});
it('updates lock file when workspace package is updated', async () => {
updateArtifact.packageFileName = 'packages/workspace-a/package.json';
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lockb'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
fs.readLocalFile.mockResolvedValueOnce('# dummy');
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
const result = await updateArtifacts(updateArtifact);
expect(result).toEqual([
{
file: {
path: 'bun.lockb',
type: 'addition',
contents: newLock,
},
},
]);
expect(exec).toHaveBeenCalledWith('bun install --ignore-scripts', {
cwdFile: 'bun.lockb',
docker: {},
toolConstraints: [
{
toolName: 'bun',
},
],
});
});
it('supports lockFileMaintenance', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lockb'] },
];
updateArtifact.config.isLockFileMaintenance = true;
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
// npmrc
fs.readLocalFile.mockResolvedValueOnce('# dummy');
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{
file: {
path: 'bun.lockb',
type: 'addition',
contents: newLock,
},
},
]);
});
it('supports lockFileMaintenance (without updated deps)', async () => {
updateArtifact.config.lockFiles = ['bun.lockb'];
updateArtifact.config.isLockFileMaintenance = true;
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
// npmrc
fs.readLocalFile.mockResolvedValueOnce('# dummy');
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{
file: {
path: 'bun.lockb',
type: 'addition',
contents: newLock,
},
},
]);
});
it('handles temporary error', async () => {
const execError = new ExecError(TEMPORARY_ERROR, {
cmd: '',
stdout: '',
stderr: '',
options: {},
});
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lockb'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
exec.mockRejectedValueOnce(execError);
await expect(updateArtifacts(updateArtifact)).rejects.toThrow(
TEMPORARY_ERROR,
);
});
it('handles full error', async () => {
const execError = new ExecError('nope', {
cmd: '',
stdout: '',
stderr: '',
options: {},
});
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lockb'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
exec.mockRejectedValueOnce(execError);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{ artifactError: { fileName: 'bun.lockb', stderr: 'nope' } },
]);
});
});
describe('when using .lock lockfile format', () => {
it('skips if cannot read lock file', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lock'] },
];
await expect(updateArtifacts(updateArtifact)).resolves.toBeNull();
});
it('returns null if lock content unchanged', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lock'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toBeNull();
});
it('returns updated lock content', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lock'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
// npmrc
fs.readLocalFile.mockResolvedValueOnce('# dummy');
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{
file: {
path: 'bun.lock',
type: 'addition',
contents: newLock,
},
},
]);
});
it('supports lockFileMaintenance', async () => {
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lock'] },
];
updateArtifact.config.isLockFileMaintenance = true;
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
// npmrc
fs.readLocalFile.mockResolvedValueOnce('# dummy');
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{
file: {
path: 'bun.lock',
type: 'addition',
contents: newLock,
},
},
]);
});
it('supports lockFileMaintenance (without updated deps)', async () => {
updateArtifact.config.lockFiles = ['bun.lock'];
updateArtifact.config.isLockFileMaintenance = true;
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
// npmrc
fs.readLocalFile.mockResolvedValueOnce('# dummy');
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{
file: {
path: 'bun.lock',
type: 'addition',
contents: newLock,
},
},
]);
});
it('handles temporary error', async () => {
const execError = new ExecError(TEMPORARY_ERROR, {
cmd: '',
stdout: '',
stderr: '',
options: {},
});
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lock'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
exec.mockRejectedValueOnce(execError);
await expect(updateArtifacts(updateArtifact)).rejects.toThrow(
TEMPORARY_ERROR,
);
});
it('handles full error', async () => {
const execError = new ExecError('nope', {
cmd: '',
stdout: '',
stderr: '',
options: {},
});
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lock'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
exec.mockRejectedValueOnce(execError);
await expect(updateArtifacts(updateArtifact)).resolves.toEqual([
{ artifactError: { fileName: 'bun.lock', stderr: 'nope' } },
]);
});
});
it('falls back to the extracted bun constraint', async () => {
updateArtifact.config = { extractedConstraints: { bun: '1.1.0' } };
updateArtifact.updatedDeps = [
{ manager: 'bun', lockFiles: ['bun.lock'] },
];
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
await updateArtifacts(updateArtifact);
expect(exec).toHaveBeenCalledWith(
'bun install --ignore-scripts',
expect.objectContaining({
toolConstraints: [{ toolName: 'bun', constraint: '1.1.0' }],
}),
);
});
});
describe('bun command execution', () => {
it('check install options with configs', async () => {
const lockfileFormats = ['bun.lockb', 'bun.lock'];
const testCases = [
{
allowScripts: undefined,
ignoreScripts: undefined,
expectedCmd: 'bun install --ignore-scripts',
},
{
allowScripts: false,
ignoreScripts: undefined,
expectedCmd: 'bun install --ignore-scripts',
},
{
allowScripts: true,
ignoreScripts: undefined,
expectedCmd: 'bun install',
},
{
allowScripts: undefined,
ignoreScripts: true,
expectedCmd: 'bun install --ignore-scripts',
},
{
allowScripts: undefined,
ignoreScripts: false,
expectedCmd: 'bun install --ignore-scripts',
},
{
allowScripts: false,
ignoreScripts: true,
expectedCmd: 'bun install --ignore-scripts',
},
{
allowScripts: false,
ignoreScripts: false,
expectedCmd: 'bun install --ignore-scripts',
},
{
allowScripts: true,
ignoreScripts: true,
expectedCmd: 'bun install --ignore-scripts',
},
{
allowScripts: true,
ignoreScripts: false,
expectedCmd: 'bun install',
},
];
for (const lockFile of lockfileFormats) {
for (const testCase of testCases) {
GlobalConfig.set({
...globalConfig,
allowScripts: testCase.allowScripts,
});
const updateArtifact: UpdateArtifact = {
config: { ignoreScripts: testCase.ignoreScripts },
newPackageFileContent: '',
packageFileName: '',
updatedDeps: [{ manager: 'bun', lockFiles: [lockFile] }],
};
const oldLock = Buffer.from('old');
fs.readLocalFile.mockResolvedValueOnce(oldLock as never);
const newLock = Buffer.from('new');
fs.readLocalFile.mockResolvedValueOnce(newLock as never);
await updateArtifacts(updateArtifact);
expect(exec).toHaveBeenCalledExactlyOnceWith(testCase.expectedCmd, {
cwdFile: lockFile,
docker: {},
toolConstraints: [
{
toolName: 'bun',
},
],
});
exec.mockClear();
GlobalConfig.reset();
}
}
});
});
});