Files
renovate/lib/modules/manager/apm/artifacts.spec.ts
Sebastian Poxhofer 4b4d14ec00 feat(manager): pass extracted constraints to updateArtifacts (#45826)
* feat(manager): pass extracted constraints to updateArtifacts

`extractedConstraints` were collected during extraction but only ever read
by `fetch.ts` for the lookup. At artifact time every manager had to derive
the same tool constraints a second time, and when the updated package file
no longer carried the constraint there was nothing to fall back to.

`generateBranchConfig()` now merges the `extractedConstraints` of all
upgrades of a branch onto the branch config, which reaches `updateArtifacts()`
through `patchConfigForArtifactsUpdate()`. `UpdateArtifactsConfig` declares
the field and documents what it contains.

The new `resolveToolConstraint()` helper implements the ladder once:
user `constraints` > an optional artifact-time derivation > the extracted
value. The derivation is ranked above the extracted value on purpose: it
reads the package files as the branch changed them, so poetry (python is an
updatable dependency there), composer, pipenv (`pipenv` can be a dev
package) and pep621 (`requires-python` is an updatable dependency) would
otherwise regress to a stale constraint. pipenv, pep621 uv/pdm, poetry and
composer are migrated to the helper and keep their derivation.

Behaviour change: these managers now use the extract-time constraint as a
last resort instead of running unconstrained, for example on lock file
maintenance where pipenv deletes `Pipfile.lock` before deriving.

`execute-post-upgrade-commands.ts` is unaffected: it reads
`upgrade.constraints` per upgrade, and the extracted values are kept in a
separate field rather than folded into `constraints`, so post-upgrade task
tool constraints still come from user config only.

Not migrated, because their constraints are never extracted, so the
fallback would be dead code: bundler (`ruby`/`bundler`), pixi (`pixi`),
pep621 uv (`required-version`) and npm's node ladder, whose last step
already reads `package.json` engines.

* refactor(manager): resolve tool constraints through resolveToolConstraint()

Every manager now obtains the constraint of a tool it runs through
`resolveToolConstraint()` instead of reading `config.constraints` itself, so
the precedence "user config, then a value derived from the updated files, then
the constraints collected during extraction" applies everywhere. The helper
treats an empty string as not set at every step and accepts the
`PostUpdateConfig` shape, whose `constraints` may be `null`.

Behaviour changes that go beyond the new fallback to extracted constraints:

- `mix` applies its hardcoded erlang default only after the extracted
  constraint, so an erlang version collected at extraction can win over it.
- `kustomize` decides `HELM_EXPERIMENTAL_OCI` from the fully resolved helm
  constraint; `generateHelmEnvs()` takes that value instead of the config.
- `npm` (yarn): an upgrade of yarn without a new value now consults the user
  constraint before deriving one from package.json or the lock file.
- The "Using <tool> constraint from config" debug lines in bundler, composer,
  copier and pip-compile are gone, as the helper is the only reader of the
  config now.

Helpers that read the config synchronously became async: bundler
`getBundlerConstraint()`, copier `getPythonVersionConstraint()` and
`getCopierVersionConstraint()`, pip-compile `get*VersionConstraint()` and
`getToolVersionConstraint()`, gomod `deriveGoToolchainConstraints()` and
`getUpdateImportPathCmds()`, mise `getMiseLockToolConstraints()`. composer
`getPhpConstraint()` is removed.

Each converted manager has a test showing the extracted constraint reaching
the executed tool, and, where a derive callback exists, that the derived value
still wins over it.

* refactor(linters): add prefer-resolve-tool-constraint rule

Reports member reads and destructuring of `constraints` and
`extractedConstraints` from a manager config in `lib/modules/manager/**`, so
that tool constraints are resolved through `resolveToolConstraint()` in
`lib/modules/manager/util.ts` only. Writes and the same properties on package
files, which extraction has to populate, are not reported. The helper itself
and spec files are exempt in `.oxlintrc.json`.

* refactor(manager): inline thin resolveToolConstraint wrappers

Drop copier/utils.ts and the pip-compile getPipToolsVersionConstraint /
getUvVersionConstraint helpers, which only forwarded to
resolveToolConstraint(). Callers now call it directly.

* docs(development): note lock file maintenance in tool constraints section

* refactor(manager): address review on tool constraint resolution

composer only runs extractConstraints() when a user constraint is missing,
via Lazy. UpdateArtifactsConfig no longer re-declares constraints and
extractedConstraints, which ToolConstraintsConfig already provides.
2026-09-14 11:09:07 +00:00

319 lines
11 KiB
TypeScript

import upath from 'upath';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { mockDeep } from 'vitest-mock-extended';
import { envMock, mockExecAll } from '~test/exec-util.ts';
import { env, fs, git, partial } from '~test/util.ts';
import { GlobalConfig } from '../../../config/global.ts';
import type {
InternalGlobalConfigOptions,
RepoGlobalConfig,
} from '../../../config/types.ts';
import { TEMPORARY_ERROR } from '../../../constants/error-messages.ts';
import * as docker from '../../../util/exec/docker/index.ts';
import type { StatusResult } from '../../../util/git/types.ts';
import * as _datasource from '../../datasource/index.ts';
import type { UpdateArtifactsConfig } from '../types.ts';
import { updateArtifacts } from './index.ts';
vi.mock('../../../util/exec/env.ts');
vi.mock('../../../util/fs/index.ts');
vi.mock('../../datasource/index.ts', () => mockDeep());
process.env.CONTAINERBASE = 'true';
const datasource = vi.mocked(_datasource);
const adminConfig: RepoGlobalConfig & InternalGlobalConfigOptions = {
localDir: upath.join('/tmp/github/some/repo'),
cacheDir: upath.join('/tmp/cache'),
containerbaseDir: upath.join('/tmp/cache/containerbase'),
dockerSidecarImage: 'ghcr.io/renovatebot/base-image',
binarySource: 'global',
};
const config: UpdateArtifactsConfig = {};
/** A `getRepoStatus` result with only the fields the manager reads. */
function repoStatus(status: Partial<StatusResult> = {}): StatusResult {
return partial<StatusResult>({
modified: [],
not_added: [],
deleted: [],
...status,
});
}
describe('modules/manager/apm/artifacts', () => {
describe('updateArtifacts', () => {
beforeEach(() => {
env.getChildProcessEnv.mockReturnValue(envMock.basic);
GlobalConfig.set(adminConfig);
docker.resetPrefetchedImages();
git.getRepoStatus.mockResolvedValue(repoStatus());
});
it('returns null if no updated deps and no lock file maintenance', async () => {
const execSnapshots = mockExecAll();
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [],
newPackageFileContent: '',
config,
}),
).resolves.toBeNull();
expect(execSnapshots).toEqual([]);
});
it('returns null if no lock file found', async () => {
const execSnapshots = mockExecAll();
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: '',
config,
}),
).resolves.toBeNull();
expect(execSnapshots).toEqual([]);
});
it('returns null if nothing changed after install', async () => {
const execSnapshots = mockExecAll();
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Current apm.lock.yaml');
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: 'new',
config,
}),
).resolves.toBeNull();
expect(execSnapshots).toMatchObject([{ cmd: 'apm install' }]);
});
it('returns the updated lockfile', async () => {
const execSnapshots = mockExecAll();
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Old apm.lock.yaml');
git.getRepoStatus.mockResolvedValueOnce(
repoStatus({ modified: ['apm.lock.yaml'] }),
);
fs.readLocalFile.mockResolvedValueOnce('New apm.lock.yaml');
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: 'new',
config,
}),
).resolves.toEqual([
{
file: {
type: 'addition',
path: 'apm.lock.yaml',
contents: 'New apm.lock.yaml',
},
},
]);
expect(execSnapshots).toMatchObject([{ cmd: 'apm install' }]);
});
it('returns regenerated harness files alongside the lockfile', async () => {
const execSnapshots = mockExecAll();
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Old apm.lock.yaml');
// `apm install` on a `targets: [claude, copilot]` manifest rewrites the
// lockfile and the deployed harness files, and removes a stale one.
git.getRepoStatus.mockResolvedValueOnce(
repoStatus({
modified: [
'apm.yml',
'apm.lock.yaml',
'.github/copilot-instructions.md',
],
not_added: ['.claude/commands/review.md'],
deleted: ['.claude/commands/old.md'],
}),
);
fs.readLocalFile.mockResolvedValueOnce('New apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('# copilot');
fs.readLocalFile.mockResolvedValueOnce('# review');
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: 'new',
config,
}),
).resolves.toEqual([
{
file: {
type: 'addition',
path: 'apm.lock.yaml',
contents: 'New apm.lock.yaml',
},
},
{
file: {
type: 'addition',
path: '.github/copilot-instructions.md',
contents: '# copilot',
},
},
{
file: {
type: 'addition',
path: '.claude/commands/review.md',
contents: '# review',
},
},
{
file: { type: 'deletion', path: '.claude/commands/old.md' },
},
]);
expect(execSnapshots).toMatchObject([{ cmd: 'apm install' }]);
});
it('deletes lock file on lockFileMaintenance', async () => {
const execSnapshots = mockExecAll();
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Old apm.lock.yaml');
git.getRepoStatus.mockResolvedValueOnce(
repoStatus({ modified: ['apm.lock.yaml'] }),
);
fs.readLocalFile.mockResolvedValueOnce('New apm.lock.yaml');
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [],
newPackageFileContent: 'new',
config: { ...config, isLockFileMaintenance: true },
}),
).resolves.toEqual([
{
file: {
type: 'addition',
path: 'apm.lock.yaml',
contents: 'New apm.lock.yaml',
},
},
]);
expect(fs.deleteLocalFile).toHaveBeenCalledWith('apm.lock.yaml');
expect(execSnapshots).toMatchObject([{ cmd: 'apm install' }]);
});
it('supports docker mode with tool constraint', async () => {
GlobalConfig.set({ ...adminConfig, binarySource: 'docker' });
const execSnapshots = mockExecAll();
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Old apm.lock.yaml');
git.getRepoStatus.mockResolvedValueOnce(
repoStatus({ modified: ['apm.lock.yaml'] }),
);
fs.readLocalFile.mockResolvedValueOnce('New apm.lock.yaml');
datasource.getPkgReleases.mockResolvedValueOnce({
releases: [{ version: '0.1.0' }, { version: '0.2.0' }],
});
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: 'new',
config: { ...config, constraints: { apm: '0.2.0' } },
}),
).resolves.toEqual([
{
file: {
type: 'addition',
path: 'apm.lock.yaml',
contents: 'New apm.lock.yaml',
},
},
]);
expect(execSnapshots).toMatchObject([
{ cmd: 'docker pull ghcr.io/renovatebot/base-image' },
{ cmd: 'docker ps --filter name=renovate_sidecar -aq' },
{
cmd:
'docker run --rm --name=renovate_sidecar --label=renovate_child ' +
'-v "/tmp/github/some/repo":"/tmp/github/some/repo" ' +
'-v "/tmp/cache":"/tmp/cache" ' +
'-e CI ' +
'-e CONTAINERBASE_CACHE_DIR ' +
'-w "/tmp/github/some/repo" ' +
'ghcr.io/renovatebot/base-image ' +
"bash -l -c '" +
'install-tool apm 0.2.0 ' +
'&& ' +
'apm install' +
"'",
},
]);
});
it('falls back to the extracted apm constraint', async () => {
GlobalConfig.set({ ...adminConfig, binarySource: 'install' });
const execSnapshots = mockExecAll();
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Old apm.lock.yaml');
git.getRepoStatus.mockResolvedValueOnce(
repoStatus({ modified: ['apm.lock.yaml'] }),
);
fs.readLocalFile.mockResolvedValueOnce('New apm.lock.yaml');
datasource.getPkgReleases.mockResolvedValueOnce({
releases: [{ version: '0.1.0' }, { version: '0.2.0' }],
});
await updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: 'new',
config: { ...config, extractedConstraints: { apm: '0.2.0' } },
});
expect(execSnapshots).toMatchObject([
{ cmd: 'install-tool apm 0.2.0' },
{ cmd: 'apm install' },
]);
});
it('rethrows TEMPORARY_ERROR', async () => {
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Old apm.lock.yaml');
fs.writeLocalFile.mockRejectedValueOnce(new Error(TEMPORARY_ERROR));
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: 'new',
config,
}),
).rejects.toThrow(TEMPORARY_ERROR);
});
it('returns artifactError on failure', async () => {
fs.getSiblingFileName.mockReturnValueOnce('apm.lock.yaml');
fs.readLocalFile.mockResolvedValueOnce('Old apm.lock.yaml');
fs.writeLocalFile.mockRejectedValueOnce(new Error('write failed'));
await expect(
updateArtifacts({
packageFileName: 'apm.yml',
updatedDeps: [{ depName: 'owner/repo' }],
newPackageFileContent: 'new',
config,
}),
).resolves.toEqual([
{
artifactError: {
fileName: 'apm.lock.yaml',
stderr: 'Error: write failed',
},
},
]);
});
});
});