mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
Michael Kriese
3a723b7891
* test(versioning/aws-machine-image): cover the empty version guard `_parse()` returns null for a falsy version before it tries the AMI id regex, and no test passed one. Checking that an empty string is not valid closes the only branch the module was missing. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(datasource/buildpacks-registry): cover a response without a homepage `latest.homepage` is optional in the registry response, but every test supplied one, so the release result was never built without it. A buildpack whose latest entry carries no homepage now checks that the releases still come back and no source url is derived. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(datasource): cover optional-field branches in four datasources Each of these datasources builds its release result by attaching fields only when the registry supplies them, and the "not supplied" path was never exercised: - cdnjs: a library with neither homepage nor repository - cpan: a search result where no release is marked latest, so no tag - dart: a latest release carrying no pubspec - ruby-version: a release table row whose first column is not a version Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(datasource): cover missing-metadata branches in hex and pypi Two more datasources only attached fields when the registry supplied them, and the absent case was untested: a hex package with neither an html_url nor a github link in its meta, and a pypi response carrying no releases at all. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(datasource): cover galaxy and repology fallbacks, mark unreachable guards Adds a galaxy role with empty github fields, so no source url is derived, and a repology lookup where the api fallback after a 403 finds no matching package. Marks four guards that are not worth a test: cpan and dart both check a variable that is only null when the request threw, and `handleGenericErrors()` always rethrows; conan's registry url is always supplied by the datasource layer; and repology's resolver either returns a body or throws. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(datasource): cover pod CDN branches, mark the sbt listing guards Adds two pod lookups: an empty CDN body, and a CDN index that lists no matching pod. Marks the guards whose tests would need multi-level directory listing fixtures: both sbt datasources walk nested index pages, and pod's github helper checks a body that an empty json response never produces because parsing throws first. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(datasource): cover maven metadata without a latest tag Adds maven metadata carrying a release but no latest, so respectLatest is left alone. Marks the three deb guards, which would each need a crafted package index: a block missing a required key, a repeated package in the final block, and two component indexes whose meta agrees. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(datasource): cover npmrc registry fallback, mark cache-bound guards Adds a resolveRegistryUrl lookup for a package no npmrc rule matches. Marks the guards whose tests would need a primed cache or a specific blob shape: nuget's services index, deno's release cache, the docker hub cache window, docker's manifest and config handling, go's pseudo-version fallback, and both rubygems cache layers. Three implicit elses are left counted: a coverage-ignore hint does not attach to an `else if`, so the registry strategy chain, the npmrc reset and docker's digest-header branch carry a plain note instead. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> * fix(datasource/repology): pass the mock body as a string `ResponseMock.body` is typed as a string, and every other call in the spec passes `'[]'`. The new api fallback test passed an array literal, which tsc rejected. Co-Authored-By: Claude Opus 5 <michael.kriese+claude-code@mend.io> --------- Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io>
Rubygems datasource
Datasource query order depends on the registry.
Querying rubygems.org
Rubygems rate limits are easy to hit, so we need to be careful with the queries. This is implemented with two-level cache:
-
First, we query
https://rubygems.org/versionsendpoint for current versions for all packages.Either full or delta sync is performed, depending on the cache state.
All the data of this layer is stored in-memory as the mapping
packageName → version[].stateDiagram-v2 [*] --> Empty state "Empty" as Empty Empty --> FullSync: getPkgReleases() state "Synced" as Synced Synced --> DeltaSync state "Unsupported" as Unsupported Unsupported --> [*] state "Full sync" as FullSync : GET /versions (~20Mb) state full_sync_result <<choice>> FullSync --> full_sync_result: Response full_sync_result --> Synced: (1) Status 200 full_sync_result --> Unsupported: (2) Status 404 full_sync_result --> Empty: (3) Status other than 200 or 404\n Clear cache and throw ExternalHostError state "Delta sync" as DeltaSync: GET /versions with "Range" header state delta_sync_result <<choice>> DeltaSync --> delta_sync_result: Successful response delta_sync_result --> Synced: (1) Status other than 206\nFull data is received, extract and replace old cache\n (as if it is the full sync) delta_sync_result --> FullSync: (2) The head of response doesn't match\n the tail of the previously fetched data delta_sync_result --> Synced: (3) The head of response matches\n the tail of the previously fetched data state delta_sync_error <<choice>> DeltaSync --> delta_sync_error: Error response delta_sync_error --> FullSync: (1) Status 416 should not happen\nbut moves to full sync delta_sync_error --> Unsupported: (2) Status 404 delta_sync_error --> Empty: (3) Status other than 404 or 416 -
Then, more data is obtained from
https://rubygems.org/api/v1/versions/<package>.jsonandhttps://rubygems.org/api/v1/gems/<package>.json.From the previous layer, the cache key is formed from the
packageName, and the list of versions is additionally hashed and stored to ensure consistency, so that we reach these API endpoints only when the key has expired or when the list of versions has changed.The data for this cache layer is being persisted in the longer-term package cache.
Querying rubygems.pkg.github.com or gitlab.com
These particular registries are queried using obsolete API
/api/v1/dependencies
Other registries
- Fetch from
/api/v1/versions/<package>.json - Fallback to
/info/<package>, if above fails - Fallback to the obsolete
/api/v1/dependencies, if above fails