mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
16ef1715e9
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules Flag ad-hoc type checks that have @sindresorhus/is equivalents: - .filter(Boolean) -> .filter(isTruthy) - typeof x === 'string' -> isString(x) - x === null || x === undefined -> isNullOrUndefined(x) (and negation) The typeof x === 'object' shape lives in a separate suggestion-only rule (renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject() are not drop-in equivalents: null, arrays and functions behave differently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: fix renovate/prefer-is-helpers violations Replace ad-hoc type checks with @sindresorhus/is helpers across lib/: - 13x .filter(Boolean) -> .filter(isTruthy) - 36x typeof x ==/!== 'string' -> isString(x) / !isString(x) - 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation) Promote renovate/prefer-is-helpers to error now that the codebase is clean. renovate/prefer-is-object stays at warn: its 15 remaining sites guard parsed YAML/JSON or unknown values where isObject()/isPlainObject() are not provably equivalent (null/array/function semantics). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: enforce renovate/prefer-is-object at error level Resolve the 15 remaining warnings and raise the rule from warn to error: - Migrate 10 sites to isObject() where the guarded value provably cannot be a function (parsed YAML/JSON, typed exec command arguments, or test-controlled fixtures): helm-values, woodpecker, bun, pre-commit managers, exec utils, file package cache, and the github http spec. In the bun manager this also fixes a latent crash where a null `workspaces` value would throw on the `in` operator. - Keep 5 sites as reasoned oxlint-disable comments where excluding functions is load-bearing: the byte-exact fingerprint canonicalizer (2), the circularity walker, the zod result guard, and the generic hasKey helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
75 lines
2.1 KiB
TypeScript
75 lines
2.1 KiB
TypeScript
import { isNullOrUndefined } from '@sindresorhus/is';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import { parseUrl } from '../../../util/url.ts';
|
|
import { api as versioning } from '../../versioning/nuget/index.ts';
|
|
import type { ParsedRegistryUrl } from './types.ts';
|
|
|
|
const buildMetaRe = regEx(/\+.+$/g);
|
|
|
|
export function removeBuildMeta(version: string): string {
|
|
return version.replace(buildMetaRe, '');
|
|
}
|
|
|
|
const urlWhitespaceRe = regEx(/\s/g);
|
|
|
|
export function massageUrl(url: string | null | undefined): string | null {
|
|
if (isNullOrUndefined(url)) {
|
|
return null;
|
|
}
|
|
|
|
let resultUrl = url;
|
|
|
|
// During `dotnet pack` certain URLs are being URL decoded which may introduce whitespace
|
|
// and causes Markdown link generation problems.
|
|
resultUrl = resultUrl.replace(urlWhitespaceRe, '%20');
|
|
|
|
return resultUrl;
|
|
}
|
|
|
|
const protocolVersionRegExp = regEx(/#protocolVersion=(?<protocol>2|3)/);
|
|
|
|
export function parseRegistryUrl(registryUrl: string): ParsedRegistryUrl {
|
|
const parsedUrl = parseUrl(registryUrl);
|
|
if (!parsedUrl) {
|
|
logger.debug(
|
|
{ urL: registryUrl },
|
|
`nuget registry failure: can't parse ${registryUrl}`,
|
|
);
|
|
return { feedUrl: registryUrl, protocolVersion: null };
|
|
}
|
|
let protocolVersion = 2;
|
|
const protocolVersionMatch = protocolVersionRegExp.exec(
|
|
parsedUrl.hash,
|
|
)?.groups;
|
|
if (protocolVersionMatch) {
|
|
const { protocol } = protocolVersionMatch;
|
|
parsedUrl.hash = '';
|
|
protocolVersion = Number.parseInt(protocol, 10);
|
|
} else if (parsedUrl.pathname.endsWith('.json')) {
|
|
protocolVersion = 3;
|
|
}
|
|
|
|
const feedUrl = parsedUrl.href;
|
|
return { feedUrl, protocolVersion };
|
|
}
|
|
|
|
/**
|
|
* Compare two versions. Return:
|
|
* - `1` if `a > b` or `b` is invalid
|
|
* - `-1` if `a < b` or `a` is invalid
|
|
* - `0` if `a == b` or both `a` and `b` are invalid
|
|
*/
|
|
export function sortNugetVersions(a: string, b: string): number {
|
|
if (versioning.isValid(a)) {
|
|
if (versioning.isValid(b)) {
|
|
return versioning.sortVersions(a, b);
|
|
}
|
|
return 1;
|
|
}
|
|
if (versioning.isValid(b)) {
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|