Files
renovate/lib/logger/pretty-stdout.spec.ts
Sebastian Poxhofer fbedd41e82 test: replace env operation with vi.stubEnv() (#45490)
* test: replace manual process.env mutation with vi.stubEnv

Enable Vitest's `unstubEnvs` so env stubs are reverted automatically
before every test, and convert the manual `process.env.X = ...` /
`delete process.env.X` pairs in specs to `vi.stubEnv()`.

This removes the hand-written `afterEach` cleanup blocks and the
`const OLD_ENV = process.env` / `process.env = { ...OLD_ENV }`
save-restore dance, which silently leaked state between tests when a
test set a variable without a matching delete.

Left as-is (incompatible with `unstubEnvs`, which unstubs before each
test, not after):
- module top-level env writes (cocoapods, gomod, post-update, pip-compile
  and bundler artifacts specs)
- `beforeAll` env writes -- the two in `util/http` moved to `beforeEach`

* test: stop asserting on ambient environment variables

Three specs asserted on values that the surrounding environment can
override, so they only passed on a machine that happened not to set them:

- `util/exec/env`: `getChildProcessEnv()` forwards every entry of
  `basicEnvVars`, but the spec only seeded a subset. Any other forwarded
  variable that was set ambiently (e.g. a lowercase `http_proxy`) leaked
  into the `toEqual` assertion. Clear all of them first.
- `util/git/index`: `process.env.GIT_SSH_COMMAND` deliberately overrides
  the default that the two env-inheritance tests assert on. Clear it.
- `logger/pretty-stdout`: the colorized level strings are built at import
  time, so the `beforeEach` setting `FORCE_COLOR` could never affect them
  -- it was dead code, and the test silently assumed a terminal without
  colour support. Derive the expectation the same way the module does.

* test(datasource/nuget): use a throwaway cache dir for nupkg downloads

The `determine source URL from nupkg` tests do not mock the filesystem,
so they really wrote downloaded packages into a fixed `/tmp/cache` path.
That fails wherever the system tmpdir is not writable, and two checkouts
running the suite at once would share the same directory.

Use `tmp.dir({ unsafeCleanup: true })` and clean it up afterwards, which
is the pattern the other specs that touch disk already use.

* feat(lint): add renovate/prefer-stub-env rule

Enforces in specs what the migration to `vi.stubEnv` established:

- assigning to or deleting `process.env.X` inside `beforeEach`, `afterEach`,
  `it` or `test` is reported, with a fixer that rewrites it to `vi.stubEnv()`
- module scope, `describe` bodies and `beforeAll` / `afterAll` are left alone:
  `unstubEnvs` reverts stubs *before* each test, so a stub created there is
  gone by the time the first test runs, and those must keep assigning directly
- replacing the `process.env` object is reported everywhere and never fixed.
  `vi.stubEnv()` captures the original object when the worker starts, so after
  a reassignment its deletes silently target the old object

The rule found 28 further violations in specs the earlier sweep missed, since
that one was anchored on `delete process.env`. Twelve were auto-fixed; the
rest replaced `process.env` wholesale and are now `clearEnv()` from test/util.

`util/exec/index.spec.ts` opts out with a comment: it asserts on the whole
child env, and `vi.stubEnv()` cannot express that because it maps `PROD`,
`DEV` and `SSR` onto '' instead of deleting them.
2026-08-28 09:26:20 +00:00

223 lines
6.0 KiB
TypeScript

import * as util from 'node:util';
import { codeBlock } from 'common-tags';
import { partial } from '~test/util.ts';
import * as prettyStdout from './pretty-stdout.ts';
import type { BunyanRecord } from './types.ts';
describe('logger/pretty-stdout', () => {
describe('getMeta(rec)', () => {
it('returns empty string if null rec', () => {
expect(prettyStdout.getMeta(null as any)).toBeEmptyString();
});
it('returns empty string if empty rec', () => {
expect(prettyStdout.getMeta(partial<BunyanRecord>())).toBeEmptyString();
});
it('returns empty string if no meta fields', () => {
const rec = partial<BunyanRecord>({
foo: 'bar',
});
expect(prettyStdout.getMeta(rec)).toBeEmptyString();
});
it('supports single meta', () => {
const rec = partial<BunyanRecord>({
foo: 'bar',
repository: 'a/b',
});
expect(prettyStdout.getMeta(rec)).toEqual(
util.styleText('gray', ' (repository=a/b)'),
);
});
it('supports multi meta', () => {
const rec = partial<BunyanRecord>({
foo: 'bar',
branch: 'c',
repository: 'a/b',
module: 'test',
});
expect(prettyStdout.getMeta(rec)).toEqual(
util.styleText('gray', ' (repository=a/b, branch=c) [test]'),
);
});
it('returns plain text when colorize is false', () => {
const rec = partial<BunyanRecord>({
foo: 'bar',
repository: 'a/b',
module: 'test',
});
expect(prettyStdout.getMeta(rec, false)).toBe(' (repository=a/b) [test]');
});
it.each([
{ field: 'repository' },
{ field: 'baseBranch' },
{ field: 'packageFile' },
{ field: 'depType' },
{ field: 'dependency' },
{ field: 'branch' },
])('ignores a non-string value for the $field meta field', ({ field }) => {
const rec = partial<BunyanRecord>({
[field]: { count: 1 },
});
expect(prettyStdout.getMeta(rec)).toBeEmptyString();
});
});
describe('getDetails(rec)', () => {
it('returns empty string if null rec', () => {
expect(prettyStdout.getDetails(null as any)).toBeEmptyString();
});
it('returns empty string if empty rec', () => {
expect(
prettyStdout.getDetails(partial<BunyanRecord>()),
).toBeEmptyString();
});
it('returns empty string if all are meta fields', () => {
const rec = partial<BunyanRecord>({
branch: 'bar',
v: 0,
});
expect(prettyStdout.getDetails(rec)).toBeEmptyString();
});
it.each([
{ field: 'repository' },
{ field: 'baseBranch' },
{ field: 'packageFile' },
{ field: 'depType' },
{ field: 'dependency' },
{ field: 'branch' },
])(
'expands the $field meta field when its value is not a string',
({ field }) => {
const rec = partial<BunyanRecord>({
v: 0,
[field]: { count: 1 },
});
expect(prettyStdout.getDetails(rec)).toBe(
` "${field}": {"count": 1}\n`,
);
},
);
it('supports a config', () => {
const rec = partial<BunyanRecord>({
v: 0,
config: {
a: 'b',
d: ['e', 'f'],
},
});
expect(prettyStdout.getDetails(rec)).toBe(
` "config": {"a": "b", "d": ["e", "f"]}\n`,
);
});
it('formats err.stack as readable multi-line output', () => {
const rec = partial<BunyanRecord>({
v: 0,
err: {
message: 'something broke',
stack: 'Error: something broke\n at foo (file.js:1:1)',
},
});
expect(prettyStdout.getDetails(rec)).toBe(
`${prettyStdout.indent(
codeBlock`
"err": {"message": "something broke"}
Error: something broke
at foo (file.js:1:1)
`,
true,
)}\n`,
);
});
it('formats err.stack without other err fields', () => {
const rec = partial<BunyanRecord>({
v: 0,
err: {
stack: 'Error: oops\n at bar (file.js:2:2)',
},
});
expect(prettyStdout.getDetails(rec)).toBe(
`${prettyStdout.indent(
codeBlock`
Error: oops
at bar (file.js:2:2)
`,
true,
)}\n`,
);
});
});
describe('formatRecord(rec)', () => {
it('formats record', () => {
const rec: BunyanRecord = {
level: 10,
msg: 'test message',
v: 0,
config: {
a: 'b',
d: ['e', 'f'],
},
};
// The colorized level strings are built once, when the module is
// imported, so whether they carry ANSI codes depends on the colour
// support of the surrounding environment. Derive the expectation the
// same way instead of assuming an uncoloured terminal.
expect(prettyStdout.formatRecord(rec)).toEqual(
[
`${util.styleText('gray', 'TRACE')}: test message`,
` "config": {"a": "b", "d": ["e", "f"]}`,
``,
].join('\n'),
);
});
it('formats record without colors', () => {
const rec = partial<BunyanRecord>({
level: 10,
msg: 'test message',
v: 0,
config: {
a: 'b',
d: ['e', 'f'],
},
});
expect(prettyStdout.formatRecord(rec, false)).toEqual(
`${codeBlock`
TRACE: test message
"config": {"a": "b", "d": ["e", "f"]}
`}\n`,
);
});
});
describe('PrettyStdoutStream', () => {
it('writes formatted data to stdout', () => {
const stdoutSpy = vi
.spyOn(process.stdout, 'write')
.mockImplementation(() => true);
const stream = new prettyStdout.PrettyStdoutStream();
const rec: BunyanRecord = {
level: 10,
msg: 'test message',
v: 0,
};
stream.write(rec);
expect(stdoutSpy).toHaveBeenCalledOnce();
expect(stdoutSpy.mock.calls[0][0]).toContain('test message');
});
});
});