Files
renovate/lib/logger/bunyan.ts
Sebastian Poxhofer 16ef1715e9 refactor(linters): add rules for @sindresorhus/is helpers (#45229)
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules

Flag ad-hoc type checks that have @sindresorhus/is equivalents:
- .filter(Boolean) -> .filter(isTruthy)
- typeof x === 'string' -> isString(x)
- x === null || x === undefined -> isNullOrUndefined(x) (and negation)

The typeof x === 'object' shape lives in a separate suggestion-only rule
(renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject()
are not drop-in equivalents: null, arrays and functions behave differently.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: fix renovate/prefer-is-helpers violations

Replace ad-hoc type checks with @sindresorhus/is helpers across lib/:
- 13x .filter(Boolean) -> .filter(isTruthy)
- 36x typeof x ==/!== 'string' -> isString(x) / !isString(x)
- 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation)

Promote renovate/prefer-is-helpers to error now that the codebase is clean.
renovate/prefer-is-object stays at warn: its 15 remaining sites guard
parsed YAML/JSON or unknown values where isObject()/isPlainObject() are
not provably equivalent (null/array/function semantics).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: enforce renovate/prefer-is-object at error level

Resolve the 15 remaining warnings and raise the rule from warn to error:

- Migrate 10 sites to isObject() where the guarded value provably cannot
  be a function (parsed YAML/JSON, typed exec command arguments, or
  test-controlled fixtures): helm-values, woodpecker, bun, pre-commit
  managers, exec utils, file package cache, and the github http spec.
  In the bun manager this also fixes a latent crash where a null
  `workspaces` value would throw on the `in` operator.
- Keep 5 sites as reasoned oxlint-disable comments where excluding
  functions is load-bearing: the byte-exact fingerprint canonicalizer
  (2), the circularity walker, the zod result guard, and the generic
  hasKey helper.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-13 14:22:03 +00:00

157 lines
4.1 KiB
TypeScript

import { isString, isTruthy, isUndefined } from '@sindresorhus/is';
import fs from 'fs-extra';
import upath from 'upath';
import { bunyan } from '../expose.ts';
import cmdSerializer from './cmd-serializer.ts';
import configSerializer from './config-serializer.ts';
import errSerializer from './err-serializer.ts';
import { PrettyStdoutStream, formatRecord } from './pretty-stdout.ts';
import type { ProblemStream } from './problem-stream.ts';
import type {
BunyanLogLevel,
BunyanLogger,
BunyanRecord,
BunyanStream,
} from './types.ts';
import { getEnv } from './utils.ts';
import { withSanitizer } from './with-sanitizer.ts';
export function createDefaultStreams(
stdoutLevel: BunyanLogLevel,
problems: ProblemStream,
logFile: string | undefined,
): BunyanStream[] {
const stdout: BunyanStream = {
name: 'stdout',
level: stdoutLevel,
stream: process.stdout,
};
// v8 ignore else -- TODO: add test #40625
if (getEnv('LOG_FORMAT') !== 'json') {
const prettyStdOut = new PrettyStdoutStream();
stdout.stream = prettyStdOut;
stdout.type = 'raw';
}
const problemsStream: BunyanStream = {
name: 'problems',
level: 'warn',
stream: problems as any,
type: 'raw',
};
const logFileStream: BunyanStream | undefined = isString(logFile)
? createLogFileStream(logFile)
: undefined;
return [stdout, problemsStream, logFileStream].filter(isTruthy);
}
function createLogFileStream(logFile: string): BunyanStream {
// Ensure log file directory exists
const directoryName = upath.dirname(logFile);
fs.ensureDirSync(directoryName);
const logFileLevel = validateLogLevel(getEnv('LOG_FILE_LEVEL'), 'debug');
// Sync writes avoid data loss when process.exit() is called before async streams drain.
const fd = fs.openSync(logFile, 'a');
if (getEnv('LOG_FILE_FORMAT') === 'pretty') {
return {
name: 'logfile',
level: logFileLevel,
type: 'raw',
stream: {
writable: true,
write: (rec: unknown) => {
fs.writeSync(fd, formatRecord(rec as BunyanRecord, false));
},
},
};
}
return {
name: 'logfile',
level: logFileLevel,
stream: {
writable: true,
write: (data: string) => {
fs.writeSync(fd, data);
},
},
} as BunyanStream;
}
function serializedSanitizedLogger(streams: BunyanStream[]): BunyanLogger {
return bunyan().createLogger({
name: 'renovate',
serializers: {
body: configSerializer,
cmd: cmdSerializer,
config: configSerializer,
migratedConfig: configSerializer,
originalConfig: configSerializer,
presetConfig: configSerializer,
oldConfig: configSerializer,
newConfig: configSerializer,
err: errSerializer,
},
streams: streams.map(withSanitizer),
});
}
export function createLogger(
stdoutLevel: BunyanLogLevel,
problems: ProblemStream,
): BunyanLogger {
const defaultStreams = createDefaultStreams(
stdoutLevel,
problems,
getEnv('LOG_FILE'),
);
return serializedSanitizedLogger(defaultStreams);
}
/**
* A function that terminates execution if the log level that was entered is
* not a valid value for the Bunyan logger.
* @param logLevelToCheck
* @returns returns the logLevel when the logLevelToCheck is valid or the defaultLevel passed as argument when it is undefined. Else it stops execution.
*/
export function validateLogLevel(
logLevelToCheck: string | undefined,
defaultLevel: BunyanLogLevel,
): BunyanLogLevel {
const allowedValues: BunyanLogLevel[] = [
'trace',
'debug',
'info',
'warn',
'error',
'fatal',
];
if (
isUndefined(logLevelToCheck) ||
(isString(logLevelToCheck) &&
allowedValues.includes(logLevelToCheck as BunyanLogLevel))
) {
// log level is in the allowed values or its undefined
return (logLevelToCheck as BunyanLogLevel) ?? defaultLevel;
}
const logger = bunyan().createLogger({
name: 'renovate',
streams: [
{
level: 'fatal',
stream: process.stdout,
},
],
});
logger.fatal({ logLevel: logLevelToCheck }, 'Invalid log level');
process.exit(1);
}