mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 07:50:47 +00:00
d4614acc54
As part of recent changes to harden Host Rules, a test case was noticed to be missing - we assume that a preset string doesn't include something that looks like a host, but we didn't previously have a test to enforce this. This wasn't exploitable before our recent changes, but this test is here to ensure we have a test covering this existing functionality. Co-authored-by: Claude Fable 5 <jamie.tanna+claude-code@mend.io> Co-authored-by: Claude Opus 5 <jamie.tanna+claude-code@mend.io>
312 lines
8.8 KiB
TypeScript
312 lines
8.8 KiB
TypeScript
import { hostRules } from '~test/host-rules.ts';
|
|
import * as httpMock from '~test/http-mock.ts';
|
|
import { ExternalHostError } from '../../../types/errors/external-host-error.ts';
|
|
import { toBase64 } from '../../../util/string.ts';
|
|
import { PRESET_INVALID_JSON, PRESET_NOT_FOUND } from '../util.ts';
|
|
import * as github from './index.ts';
|
|
|
|
const githubApiHost = github.Endpoint;
|
|
const basePath = '/repos/some/repo/contents';
|
|
|
|
describe('config/presets/github/index', () => {
|
|
beforeEach(() => {
|
|
hostRules.add({ token: 'abc' });
|
|
});
|
|
|
|
describe('fetchJSONFile()', () => {
|
|
it('returns JSON', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/some-filename.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"from":"api"}'),
|
|
});
|
|
|
|
const res = await github.fetchJSONFile(
|
|
'some/repo',
|
|
'some-filename.json',
|
|
githubApiHost,
|
|
undefined,
|
|
);
|
|
expect(res).toEqual({ from: 'api' });
|
|
});
|
|
|
|
it('fetches from the endpoint host even for a hostile repo string', async () => {
|
|
// the repo part of a preset string has no host component: whatever it contains only ever becomes a path on the configured endpoint (`..` segments are normalized within it)
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get('/repos/evil.example.com/x/contents/default.json')
|
|
.reply(200, {
|
|
content: toBase64('{"from":"api"}'),
|
|
});
|
|
|
|
const res = await github.fetchJSONFile(
|
|
'some/repo/../../evil.example.com/x',
|
|
'default.json',
|
|
githubApiHost,
|
|
undefined,
|
|
);
|
|
|
|
expect(res).toEqual({ from: 'api' });
|
|
});
|
|
|
|
it('throws external host error', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/some-filename.json`)
|
|
.reply(404, {});
|
|
|
|
hostRules.add({ abortOnError: true });
|
|
|
|
await expect(
|
|
github.fetchJSONFile(
|
|
'some/repo',
|
|
'some-filename.json',
|
|
githubApiHost,
|
|
undefined,
|
|
),
|
|
).rejects.toThrow(ExternalHostError);
|
|
});
|
|
});
|
|
|
|
describe('getPreset()', () => {
|
|
it('tries default then renovate', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/default.json`)
|
|
.reply(404, {})
|
|
.get(`${basePath}/renovate.json`)
|
|
.reply(200, {});
|
|
|
|
await expect(github.getPreset({ repo: 'some/repo' })).rejects.toThrow(
|
|
'The first argument must be of type string or an instance of Buffer,',
|
|
);
|
|
});
|
|
|
|
it('throws if invalid content', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/default.json`)
|
|
.reply(200, { content: toBase64('invalid') });
|
|
|
|
await expect(github.getPreset({ repo: 'some/repo' })).rejects.toThrow(
|
|
PRESET_INVALID_JSON,
|
|
);
|
|
});
|
|
|
|
it('throws if fails to parse', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/default.json`)
|
|
.reply(200, {
|
|
content: toBase64('not json'),
|
|
});
|
|
|
|
await expect(github.getPreset({ repo: 'some/repo' })).rejects.toThrow(
|
|
PRESET_INVALID_JSON,
|
|
);
|
|
});
|
|
|
|
it('should return default.json', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/default.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"foo":"bar"}'),
|
|
});
|
|
|
|
const content = await github.getPreset({ repo: 'some/repo' });
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should query preset within the file', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/somefile.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"somename":{"foo":"bar"}}'),
|
|
});
|
|
const content = await github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'somefile/somename',
|
|
});
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should query preset within the file when .json extension provided', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/somefile.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"foo":"bar"}'),
|
|
});
|
|
const content = await github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'somefile.json',
|
|
});
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should query preset within the file when .json5 extension provided', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/somefile.json5`)
|
|
.reply(200, {
|
|
content: toBase64('{foo:"bar"}'),
|
|
});
|
|
const content = await github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'somefile.json5',
|
|
});
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should query preset within the file when .jsonc extension provided', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/somefile.jsonc`)
|
|
.reply(200, {
|
|
content: toBase64('{"foo":/* nothing to see here */"bar"}'),
|
|
});
|
|
const content = await github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'somefile.jsonc',
|
|
});
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should query subpreset', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/somefile.json`)
|
|
.reply(200, {
|
|
content: Buffer.from(
|
|
'{"somename":{"somesubname":{"foo":"bar"}}}',
|
|
).toString('base64'),
|
|
});
|
|
|
|
const content = await github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'somefile/somename/somesubname',
|
|
});
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should return custom.json', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/custom.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"foo":"bar"}'),
|
|
});
|
|
const content = await github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'custom',
|
|
});
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should query custom paths', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/path/custom.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"foo":"bar"}'),
|
|
});
|
|
const content = await github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'custom',
|
|
presetPath: 'path',
|
|
});
|
|
expect(content).toEqual({ foo: 'bar' });
|
|
});
|
|
|
|
it('should throws not-found', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/somefile.json`)
|
|
.reply(200, {
|
|
content: toBase64('{}'),
|
|
});
|
|
await expect(
|
|
github.getPreset({
|
|
repo: 'some/repo',
|
|
presetName: 'somefile/somename/somesubname',
|
|
}),
|
|
).rejects.toThrow(PRESET_NOT_FOUND);
|
|
});
|
|
});
|
|
|
|
describe('getPresetFromEndpoint()', () => {
|
|
it('uses default endpoint', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/default.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"from":"api"}'),
|
|
});
|
|
await expect(
|
|
github.getPresetFromEndpoint('some/repo', 'default', undefined),
|
|
).resolves.toEqual({ from: 'api' });
|
|
});
|
|
|
|
it('uses custom endpoint', async () => {
|
|
httpMock
|
|
.scope('https://api.github.example.org')
|
|
.get(`${basePath}/default.json`)
|
|
.reply(200, {
|
|
content: toBase64('{"from":"api"}'),
|
|
});
|
|
await expect(
|
|
github
|
|
.getPresetFromEndpoint(
|
|
'some/repo',
|
|
'default',
|
|
undefined,
|
|
'https://api.github.example.org',
|
|
undefined,
|
|
)
|
|
.catch(() => ({ from: 'api' })),
|
|
).resolves.toEqual({ from: 'api' });
|
|
});
|
|
|
|
it('uses default endpoint with a tag', async () => {
|
|
httpMock
|
|
.scope(githubApiHost)
|
|
.get(`${basePath}/default.json?ref=someTag`)
|
|
.reply(200, {
|
|
content: toBase64('{"from":"api"}'),
|
|
});
|
|
await expect(
|
|
github.getPresetFromEndpoint(
|
|
'some/repo',
|
|
'default',
|
|
undefined,
|
|
githubApiHost,
|
|
'someTag',
|
|
),
|
|
).resolves.toEqual({ from: 'api' });
|
|
});
|
|
|
|
it('uses custom endpoint with a tag', async () => {
|
|
httpMock
|
|
.scope('https://api.github.example.org')
|
|
.get(`${basePath}/default.json?ref=someTag`)
|
|
.reply(200, {
|
|
content: toBase64('{"from":"api"}'),
|
|
});
|
|
await expect(
|
|
github
|
|
.getPresetFromEndpoint(
|
|
'some/repo',
|
|
'default',
|
|
undefined,
|
|
'https://api.github.example.org',
|
|
'someTag',
|
|
)
|
|
.catch(() => ({ from: 'api' })),
|
|
).resolves.toEqual({ from: 'api' });
|
|
});
|
|
});
|
|
});
|