mirror of
https://github.com/renovatebot/renovate.git
synced 2026-10-27 15:58:48 +00:00
Sebastian Poxhofer
e0cec3dc95
feat(lint): add `types-location` rule and enable it for `lib/modules`
Reviewers consistently ask for exported types to be moved into a
colocated `types.ts`. Add a `renovate/types-location` oxlint rule that
reports `export interface` / `export type` declarations outside such a
file, and turn it on across `lib/modules`.
Re-exports (`export type { X }`, `export type *`), file-local types, and
values (enums, classes, functions) are left alone. `schema.ts` files and
`schema/` directories are excluded via config, matching how
`zod-schema-location` is configured — inferred types belong next to the
schema they are derived from.
Relocating the 87 existing violations means:
- new `types.ts` files for the modules that had none
- `terragrunt/common.ts` folded into its `types.ts`, as it held nothing
else
- `RangeBound` in `versioning/gradle/compare.ts` un-exported, since only
a file-local interface referenced it
- `bazel-module/parser/fragments.ts` split from its inferred types, which
now live in `parser/types.ts` and infer through a namespace import so
each schema keeps its merged name
50 lines
1.3 KiB
TypeScript
50 lines
1.3 KiB
TypeScript
import { regEx } from '../../../util/regex.ts';
|
|
import { GenericVersioningApi } from '../generic.ts';
|
|
import type { GenericVersion, VersioningApi } from '../types.ts';
|
|
|
|
export const id = 'azure-rest-api';
|
|
export const displayName = 'azure-rest-api';
|
|
|
|
export const urls = [
|
|
'[Microsoft Azure API versioning guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#api-versioning)',
|
|
];
|
|
|
|
export const supportsRanges = false;
|
|
|
|
const AZURE_REST_API_VERSION_REGEX = regEx(
|
|
/^(?<year>\d{4})-(?<month>\d{2})-(?<day>\d{2})(?<prerelease>-[a-z]+)?$/,
|
|
);
|
|
|
|
class AzureRestApiVersioningApi extends GenericVersioningApi {
|
|
protected _parse(version: string): GenericVersion | null {
|
|
if (!version) {
|
|
return null;
|
|
}
|
|
|
|
const matchGroups = AZURE_REST_API_VERSION_REGEX.exec(version)?.groups;
|
|
|
|
if (!matchGroups) {
|
|
return null;
|
|
}
|
|
|
|
const { year, month, day, prerelease } = matchGroups;
|
|
|
|
return {
|
|
release: [parseInt(`${year}${month}${day}`, 10), 0, 0],
|
|
prerelease,
|
|
};
|
|
}
|
|
|
|
protected override _compare(_version: string, _other: string): number {
|
|
if (_version === _other) {
|
|
return 0;
|
|
}
|
|
|
|
return _version > _other ? 1 : -1;
|
|
}
|
|
}
|
|
|
|
export const api: VersioningApi = new AzureRestApiVersioningApi();
|
|
|
|
export default api;
|