mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 02:00:10 +00:00
1ea8602aaa
* test(manager): cover twelve else-if branches The trailing `else if` of a chain leaves v8 counting an implicit else that no coverage-ignore hint can suppress. Fourteen of those were marked as structurally unreachable, but only two of them actually are -- each of these twelve has an input that takes it: - `bazel`: an archive url whose file name is only a suffix, which strips to an empty value, so neither value nor digest is set - `cargo`: a `[package]` section with no `version` at all - `composer`: an inline `package` repository, which the discriminated union does carry, contrary to the comment that claimed otherwise - `deps-edn`: an `:mvn/repos` entry whose spec is a plain string - `gomod`: an update where only the `go` directive changed, leaving no additional dependencies to count - `helmfile`: a release with an empty chart name, which is neither a local path nor an oci ref and yields an empty repo name - `nuget`: a lock file that is gone after the restore - `swift`: a comma where `from` expects a colon, and where `from:` expects a version -- both are labels the state machine searches for and then ignores - `terraform`: a module source too short to be a registry module - `tflint-plugin`: a quoted attribute that is neither version nor source - `travis`: a matrix `node_js` that is a number The stale comments go with them. Three more in `swift` were already wrong before this change: the branches they described were covered. Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io> * refactor(manager): collapse two exhaustive else-if chains `glasskube` and `gradle` were the only two of the fourteen trailing `else if` branches that really are unreachable, and both are provable from a type rather than from a reading of the surrounding code: - `glasskube` parses resources with a schema that admits exactly `Package`, `ClusterPackage` and `PackageRepository`, and filters anything else out - `gradle`'s `ContentDescriptorSpec.mode` is `'include' | 'exclude'` Turning the final `else if` into a plain `else` drops the phantom branch v8 was counting. With these, the manager tree reaches 100% branch coverage. The glasskube check is inverted so that the single-literal discriminant narrows for the compiler. Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io> * test(manager/travis): inline the numeric node_js fixture The three-line fixture went into `__fixtures__` only because every other fixture in this spec is loaded through `Fixtures.get`. A reader of the test should be able to see the input without opening a second file, so write it inline with `codeBlock`. Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io> --------- Co-authored-by: Claude Opus 5 <michael.kriese+claude-code@mend.io>
417 lines
12 KiB
TypeScript
417 lines
12 KiB
TypeScript
import { detectPlatform } from '../../../util/common.ts';
|
|
import { getHttpUrl } from '../../../util/git/url.ts';
|
|
import { regEx } from '../../../util/regex.ts';
|
|
import { parseUrl } from '../../../util/url.ts';
|
|
import { GitTagsDatasource } from '../../datasource/git-tags/index.ts';
|
|
import { GithubTagsDatasource } from '../../datasource/github-tags/index.ts';
|
|
import { GitlabTagsDatasource } from '../../datasource/gitlab-tags/index.ts';
|
|
import type { PackageDependency, PackageFileContent } from '../types.ts';
|
|
import type { MatchResult } from './types.ts';
|
|
|
|
const regExps = {
|
|
wildcard: regEx(/^.*?/),
|
|
space: regEx(/(?:\s+|\/\/[^\n]*|\/\*.*\*\/)+/s),
|
|
depsKeyword: regEx(/dependencies/),
|
|
colon: regEx(/:/),
|
|
beginSection: regEx(/\[/),
|
|
endSection: regEx(/],?/),
|
|
package: regEx(/\s*.\s*package\s*\(\s*/),
|
|
urlKey: regEx(/url/),
|
|
stringLiteral: regEx(/"[^"]+"/),
|
|
comma: regEx(/,/),
|
|
from: regEx(/from/),
|
|
rangeOp: regEx(/\.\.[.<]/),
|
|
exactVersion: regEx(/\.\s*exact\s*\(\s*/),
|
|
exactVersionLabel: regEx(/\s*exact:/),
|
|
traitsLabel: regEx(/\s*traits\s*:/),
|
|
// This pattern consumes any `traits` content until the next package declaration,
|
|
// as the traits syntax can be quite complex and does not need to be parsed in detail for package extraction.
|
|
traitsConsumeToNextPackage: regEx(/.*\.\s*package\s*\(\s*/),
|
|
};
|
|
|
|
const WILDCARD = 'wildcard';
|
|
const SPACE = 'space';
|
|
const DEPS = 'depsKeyword';
|
|
const COLON = 'colon';
|
|
const BEGIN_SECTION = 'beginSection';
|
|
const END_SECTION = 'endSection';
|
|
const PACKAGE = 'package';
|
|
const URL_KEY = 'urlKey';
|
|
const STRING_LITERAL = 'stringLiteral';
|
|
const COMMA = 'comma';
|
|
const FROM = 'from';
|
|
const RANGE_OP = 'rangeOp';
|
|
const EXACT_VERSION = 'exactVersion';
|
|
const EXACT_VERSION_LABEL = 'exactVersionLabel';
|
|
const TRAITS_LABEL = 'traitsLabel';
|
|
const TRAITS_CONSUME_TO_NEXT_PACKAGE = 'traitsConsumeToNextPackage';
|
|
|
|
const searchLabels = {
|
|
wildcard: WILDCARD,
|
|
space: SPACE,
|
|
depsKeyword: DEPS,
|
|
colon: COLON,
|
|
beginSection: BEGIN_SECTION,
|
|
endSection: END_SECTION,
|
|
package: PACKAGE,
|
|
urlKey: URL_KEY,
|
|
stringLiteral: STRING_LITERAL,
|
|
comma: COMMA,
|
|
from: FROM,
|
|
rangeOp: RANGE_OP,
|
|
exactVersion: EXACT_VERSION,
|
|
exactVersionLabel: EXACT_VERSION_LABEL,
|
|
traitsLabel: TRAITS_LABEL,
|
|
traitsConsumeToNextPackage: TRAITS_CONSUME_TO_NEXT_PACKAGE,
|
|
};
|
|
|
|
function searchKeysForState(state: string | null): (keyof typeof regExps)[] {
|
|
switch (state) {
|
|
case 'dependencies':
|
|
return [SPACE, COLON, WILDCARD];
|
|
case 'dependencies:':
|
|
return [SPACE, BEGIN_SECTION, WILDCARD];
|
|
case 'dependencies: [':
|
|
return [SPACE, PACKAGE, COMMA, TRAITS_LABEL, END_SECTION];
|
|
case '.package(':
|
|
return [SPACE, URL_KEY, PACKAGE, END_SECTION];
|
|
case '.package(url':
|
|
return [SPACE, COLON, PACKAGE, END_SECTION];
|
|
case '.package(url:':
|
|
return [SPACE, STRING_LITERAL, PACKAGE, END_SECTION];
|
|
case '.package(url: [depName]':
|
|
return [SPACE, COMMA, PACKAGE, END_SECTION];
|
|
case '.package(url: [depName],':
|
|
return [
|
|
SPACE,
|
|
FROM,
|
|
STRING_LITERAL,
|
|
RANGE_OP,
|
|
EXACT_VERSION,
|
|
EXACT_VERSION_LABEL,
|
|
PACKAGE,
|
|
END_SECTION,
|
|
];
|
|
case '.package(url: [depName], .exact(':
|
|
return [SPACE, STRING_LITERAL, PACKAGE, COMMA, TRAITS_LABEL, END_SECTION];
|
|
case '.package(url: [depName], exact:':
|
|
return [SPACE, STRING_LITERAL, PACKAGE, COMMA, TRAITS_LABEL, END_SECTION];
|
|
case '.package(url: [depName], from':
|
|
return [SPACE, COLON, PACKAGE, COMMA, TRAITS_LABEL, END_SECTION];
|
|
case '.package(url: [depName], from:':
|
|
return [SPACE, STRING_LITERAL, PACKAGE, COMMA, TRAITS_LABEL, END_SECTION];
|
|
case '.package(url: [depName], [value]':
|
|
return [SPACE, RANGE_OP, PACKAGE, COMMA, TRAITS_LABEL, END_SECTION];
|
|
case '.package(url: [depName], [rangeFrom][rangeOp]':
|
|
return [SPACE, STRING_LITERAL, PACKAGE, COMMA, TRAITS_LABEL, END_SECTION];
|
|
case 'traits:':
|
|
return [SPACE, TRAITS_CONSUME_TO_NEXT_PACKAGE];
|
|
default:
|
|
return [DEPS];
|
|
}
|
|
}
|
|
function getMatch(str: string, state: string | null): MatchResult | null {
|
|
const keys = searchKeysForState(state);
|
|
let result: MatchResult | null = null;
|
|
for (const key of keys) {
|
|
const regex = regExps[key];
|
|
const label = searchLabels[key];
|
|
const match = regex.exec(str);
|
|
if (match) {
|
|
const idx = match.index;
|
|
const substr = match[0];
|
|
const len = substr.length;
|
|
if (idx === 0) {
|
|
return { idx, len, label, substr };
|
|
}
|
|
if (!result || idx < result.idx) {
|
|
result = { idx, len, label, substr };
|
|
}
|
|
}
|
|
}
|
|
return result;
|
|
}
|
|
|
|
function parseDependencyUrl(
|
|
url: string | null,
|
|
): { depName: string; datasource: string; registryUrls?: string[] } | null {
|
|
// istanbul ignore if
|
|
if (!url) {
|
|
return null;
|
|
}
|
|
|
|
let normalizedUrl: string;
|
|
try {
|
|
normalizedUrl = getHttpUrl(url);
|
|
} catch {
|
|
return null;
|
|
}
|
|
|
|
const parsedUrl = parseUrl(normalizedUrl);
|
|
// v8 ignore if -- getHttpUrl always returns a parseable URL
|
|
if (!parsedUrl) {
|
|
return null;
|
|
}
|
|
const { host, pathname, protocol } = parsedUrl;
|
|
const platform = detectPlatform(normalizedUrl);
|
|
if (platform === 'github' || platform === 'gitlab') {
|
|
const depName = pathname
|
|
.replace(regEx(/^\//), '')
|
|
.replace(regEx(/\.git$/), '')
|
|
.replace(regEx(/\/$/), '');
|
|
const datasource =
|
|
platform === 'github' ? GithubTagsDatasource.id : GitlabTagsDatasource.id;
|
|
|
|
const isGitHubPublic = host === 'github.com';
|
|
const isGitLabPublic = host === 'gitlab.com';
|
|
|
|
if (!isGitHubPublic && !isGitLabPublic) {
|
|
const baseUrl = `${protocol}//${host}`;
|
|
return { depName, datasource, registryUrls: [baseUrl] };
|
|
}
|
|
|
|
return { depName, datasource };
|
|
}
|
|
return { depName: url, datasource: GitTagsDatasource.id };
|
|
}
|
|
|
|
export function extractPackageFile(content: string): PackageFileContent | null {
|
|
if (!content) {
|
|
return null;
|
|
}
|
|
|
|
const deps: PackageDependency[] = [];
|
|
const result: PackageFileContent = {
|
|
deps,
|
|
};
|
|
|
|
let restStr = content;
|
|
let state: string | null = null;
|
|
let match = getMatch(restStr, state);
|
|
|
|
let packageName: string | null = null;
|
|
let currentValue: string | null = null;
|
|
|
|
function yieldDep(): void {
|
|
// istanbul ignore if
|
|
if (!packageName) {
|
|
return;
|
|
}
|
|
const parsedUrl = parseDependencyUrl(packageName);
|
|
if (parsedUrl && currentValue) {
|
|
const { depName, datasource, registryUrls } = parsedUrl;
|
|
|
|
const dep: PackageDependency = {
|
|
datasource,
|
|
depName,
|
|
currentValue,
|
|
...(registryUrls?.length && { registryUrls }),
|
|
};
|
|
|
|
deps.push(dep);
|
|
}
|
|
packageName = null;
|
|
currentValue = null;
|
|
}
|
|
|
|
while (match) {
|
|
const { idx, len, label, substr } = match;
|
|
|
|
switch (state) {
|
|
case null:
|
|
if (deps.length) {
|
|
break;
|
|
}
|
|
// v8 ignore else -- this state is only re-entered at a deps boundary
|
|
if (label === DEPS) {
|
|
state = 'dependencies';
|
|
}
|
|
break;
|
|
case 'dependencies':
|
|
if (label === COLON) {
|
|
state = 'dependencies:';
|
|
} else if (label !== SPACE) {
|
|
state = null;
|
|
}
|
|
break;
|
|
case 'dependencies:':
|
|
if (label === BEGIN_SECTION) {
|
|
state = 'dependencies: [';
|
|
} else if (label !== SPACE) {
|
|
state = null;
|
|
}
|
|
break;
|
|
case 'dependencies: [':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
} else if (label === TRAITS_LABEL) {
|
|
state = 'traits:';
|
|
}
|
|
break;
|
|
case '.package(':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === URL_KEY) {
|
|
state = '.package(url';
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
}
|
|
break;
|
|
case '.package(url':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === COLON) {
|
|
state = '.package(url:';
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url:':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === STRING_LITERAL) {
|
|
packageName = substr
|
|
.replace(regEx(/^"/), '')
|
|
.replace(regEx(/"$/), '');
|
|
state = '.package(url: [depName]';
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName]':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === COMMA) {
|
|
state = '.package(url: [depName],';
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName],':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === FROM) {
|
|
currentValue = substr;
|
|
state = '.package(url: [depName], from';
|
|
} else if (label === STRING_LITERAL) {
|
|
currentValue = substr;
|
|
state = '.package(url: [depName], [value]';
|
|
} else if (label === RANGE_OP) {
|
|
currentValue = substr;
|
|
state = '.package(url: [depName], [rangeFrom][rangeOp]';
|
|
} else if (label === EXACT_VERSION) {
|
|
state = '.package(url: [depName], .exact(';
|
|
} else if (label === EXACT_VERSION_LABEL) {
|
|
state = '.package(url: [depName], exact:';
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName], .exact(':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === STRING_LITERAL) {
|
|
currentValue = substr.slice(1, substr.length - 1);
|
|
yieldDep();
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName], exact:':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === STRING_LITERAL) {
|
|
currentValue = substr.slice(1, substr.length - 1);
|
|
yieldDep();
|
|
state = 'dependencies: [';
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName], from':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === COLON) {
|
|
currentValue += substr;
|
|
state = '.package(url: [depName], from:';
|
|
} else if (label === SPACE) {
|
|
currentValue += substr;
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName], from:':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === STRING_LITERAL) {
|
|
currentValue += substr;
|
|
yieldDep();
|
|
state = 'dependencies: [';
|
|
} else if (label === SPACE) {
|
|
currentValue += substr;
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName], [value]':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === RANGE_OP) {
|
|
currentValue += substr;
|
|
state = '.package(url: [depName], [rangeFrom][rangeOp]';
|
|
} else if (label === SPACE) {
|
|
currentValue += substr;
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case '.package(url: [depName], [rangeFrom][rangeOp]':
|
|
if (label === END_SECTION) {
|
|
yieldDep();
|
|
state = null;
|
|
} else if (label === STRING_LITERAL) {
|
|
currentValue += substr;
|
|
state = 'dependencies: [';
|
|
} else if (label === SPACE) {
|
|
currentValue += substr;
|
|
} else if (label === PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
case 'traits:':
|
|
if (label === TRAITS_CONSUME_TO_NEXT_PACKAGE) {
|
|
yieldDep();
|
|
state = '.package(';
|
|
}
|
|
break;
|
|
}
|
|
restStr = restStr.slice(idx + len);
|
|
match = getMatch(restStr, state);
|
|
}
|
|
return deps.length ? result : null;
|
|
}
|