mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 18:19:51 +00:00
0d9888a4f2
* feat(datasource): add GraalVM version datasource with support for JDK and JRE releases * feat(datasource): add GraalVM version datasource with support for JDK and JRE releases * feat(datasource): add GraalVM version datasource with support for JDK and JRE releases * feat(datasource): add GraalVM version datasource with support for JDK and JRE releases * feat(datasource): add GraalVM version datasource with support for JDK and JRE releases * add coverage * fix * fix * fix * code cov * code cov * code cov * refactor(datasource): integrate GraalVM into java-version datasource Merges graalvm-version datasource into java-version as a unified multi-vendor Java distribution datasource. Implements vendor-based modular architecture with routing layer for Adoptium (Eclipse Temurin) and Oracle GraalVM. Architecture: - Vendor-specific handlers (adoptium.ts, graalvm.ts) with routing in index.ts - Vendor-aware system detection with different arch/os mappings per vendor - Custom registry support for GraalVM's mise-java API - Adoptium remains the default registry for backwards compatibility Package names: - New explicit: adoptium-jdk, adoptium-jre, oracle-graalvm-jdk, oracle-graalvm-jre - Legacy (map to Adoptium): java, java-jdk, java-jre Changes: - Created adoptium.ts and graalvm.ts vendor handlers - Enhanced common.ts with vendor detection and vendor-specific system mappings - Updated index.ts with routing layer and custom registry support - Merged test suites with comprehensive coverage for both vendors - Updated mise manager integration to use JavaVersionDatasource - Removed graalvm-version datasource directory All 65 datasource tests and 93 mise manager tests passing. * fix * test(datasource): add coverage for non-HttpError paths in java-version * fix(datasource): remove dead code and add coverage for java-version Remove unreachable HttpError handling from _getReleases catch block since both getAdoptiumReleases and getGraalvmReleases handle HttpError internally. Add test for the graalvmRegistryUrl fallback when registryUrl is undefined. * fix(datasource): address review comments for GraalVM datasource - Remove unused 'datasource-graalvm-version' cache namespace - Convert MiseJavaRelease interface to Zod schema and derive type from it - Use http.getJson() with the Zod schema in getGraalvmReleases instead of getJsonUnchecked, letting the schema handle invalid/empty responses - Update getGraalvmReleases test mock to use getJson * docs: remove unused datasource-graalvm-version from cacheTtlOverride docs * fix(datasource): preserve Adoptium config typing * fix(datasource): harden GraalVM release parsing * fix(datasource): address GraalVM review feedback * test: cover GraalVM mise package mapping * test(datasource): cover default GraalVM registry fallback * test(datasource): cover legacy registry resolution * test(datasource): type legacy datasource mocks * fix(datasource): harden GraalVM defaults and responses * refactor(datasource): use function-only registry accessors * test(datasource): cover registry accessor functions * test: restore coverage exclusions * chore: retrigger CI checks
186 lines
5.6 KiB
TypeScript
186 lines
5.6 KiB
TypeScript
import { Readable } from 'node:stream';
|
|
import type {
|
|
GetObjectCommandOutput,
|
|
S3ClientConfig,
|
|
} from '@aws-sdk/client-s3';
|
|
import { GetObjectCommand } from '@aws-sdk/client-s3';
|
|
import { logger } from '../../../logger/index.ts';
|
|
import { ExternalHostError } from '../../../types/errors/external-host-error.ts';
|
|
import { withCache } from '../../../util/cache/package/with-cache.ts';
|
|
import * as hostRules from '../../../util/host-rules.ts';
|
|
import type { S3UrlParts } from '../../../util/s3.ts';
|
|
import { getS3Client, parseS3Url } from '../../../util/s3.ts';
|
|
import { streamToString } from '../../../util/streams.ts';
|
|
import { ensureTrailingSlash } from '../../../util/url.ts';
|
|
import { parseSingleYaml } from '../../../util/yaml.ts';
|
|
import * as helmVersioning from '../../versioning/helm/index.ts';
|
|
import { Datasource } from '../datasource.ts';
|
|
import type { GetReleasesConfig, ReleaseResult } from '../types.ts';
|
|
import { HelmRepository } from './schema.ts';
|
|
|
|
export class HelmDatasource extends Datasource {
|
|
static readonly id = 'helm';
|
|
|
|
constructor() {
|
|
super(HelmDatasource.id);
|
|
}
|
|
|
|
override getDefaultRegistryUrls(_packageName: string): string[] {
|
|
return ['https://charts.helm.sh/stable'];
|
|
}
|
|
|
|
override readonly defaultConfig = {
|
|
commitMessageTopic: 'Helm release {{depName}}',
|
|
};
|
|
|
|
override readonly defaultVersioning = helmVersioning.id;
|
|
|
|
override readonly releaseTimestampSupport = true;
|
|
override readonly releaseTimestampNote =
|
|
'The release timstamp is determined from the `created` field in the results.';
|
|
override readonly sourceUrlSupport = 'package';
|
|
override readonly sourceUrlNote =
|
|
'The source URL is determined from the `home` field or the `sources` field in the results.';
|
|
|
|
private async _getRepositoryData(
|
|
helmRepository: string,
|
|
): Promise<HelmRepository> {
|
|
const baseUrl = ensureTrailingSlash(helmRepository);
|
|
const indexUrl = `${baseUrl}index.yaml`;
|
|
|
|
const s3Url = parseS3Url(indexUrl);
|
|
if (s3Url) {
|
|
return await getS3RepositoryData(s3Url, indexUrl);
|
|
}
|
|
|
|
const { val, err } = await this.http
|
|
.getYamlSafe('index.yaml', { baseUrl }, HelmRepository)
|
|
.unwrap();
|
|
|
|
if (err) {
|
|
this.handleGenericErrors(err);
|
|
}
|
|
|
|
return val;
|
|
}
|
|
|
|
getRepositoryData(helmRepository: string): Promise<HelmRepository> {
|
|
return withCache(
|
|
{
|
|
namespace: `datasource-${HelmDatasource.id}`,
|
|
key: `repository-data:${helmRepository}`,
|
|
},
|
|
() => this._getRepositoryData(helmRepository),
|
|
);
|
|
}
|
|
|
|
async getReleases({
|
|
packageName,
|
|
registryUrl: helmRepository,
|
|
}: GetReleasesConfig): Promise<ReleaseResult | null> {
|
|
/* v8 ignore next -- should never happen */
|
|
if (!helmRepository) {
|
|
return null;
|
|
}
|
|
|
|
const repositoryData = await this.getRepositoryData(helmRepository);
|
|
const releases = repositoryData[packageName];
|
|
if (!releases) {
|
|
logger.debug(
|
|
{ dependency: packageName },
|
|
`Entry ${packageName} doesn't exist in index.yaml from ${helmRepository}`,
|
|
);
|
|
return null;
|
|
}
|
|
return releases;
|
|
}
|
|
}
|
|
|
|
async function getS3RepositoryData(
|
|
s3Url: S3UrlParts,
|
|
indexUrl: string,
|
|
): Promise<HelmRepository> {
|
|
const client = getS3Client(undefined, undefined, getS3Credentials(indexUrl));
|
|
|
|
let res: GetObjectCommandOutput;
|
|
try {
|
|
res = await client.send(new GetObjectCommand(s3Url));
|
|
} catch (err) {
|
|
throw classifyS3Error(err, indexUrl);
|
|
}
|
|
|
|
if (res.DeleteMarker) {
|
|
logger.debug(
|
|
{ indexUrl },
|
|
'Helm S3 lookup error: DeleteMarker encountered',
|
|
);
|
|
throw new Error(`No index.yaml found at ${indexUrl}`);
|
|
}
|
|
|
|
if (!(res.Body instanceof Readable)) {
|
|
logger.debug({ indexUrl }, 'Helm S3 lookup error: unsupported Body type');
|
|
throw new Error(`Unsupported S3 response body for ${indexUrl}`);
|
|
}
|
|
|
|
return parseSingleYaml(await streamToString(res.Body), {
|
|
customSchema: HelmRepository,
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Only a missing object means "this chart repository has no releases", so that
|
|
* error is rethrown as-is and the lookup resolves to `null`.
|
|
* Everything else becomes an `ExternalHostError` to abort the run, otherwise a
|
|
* transient S3 failure looks like a deleted chart and closes open PRs.
|
|
*/
|
|
function classifyS3Error(
|
|
// `name` holds the S3 error code, `message` holds server-supplied prose
|
|
err: Error & { $metadata?: { httpStatusCode?: number } },
|
|
indexUrl: string,
|
|
): Error {
|
|
if (err.name === 'NotFound' || err.name === 'NoSuchKey') {
|
|
logger.debug({ indexUrl }, 'Helm S3 lookup error: object not found');
|
|
return err;
|
|
}
|
|
|
|
if (
|
|
err.name === 'CredentialsProviderError' ||
|
|
err.$metadata?.httpStatusCode === 403
|
|
) {
|
|
logger.debug(
|
|
{ indexUrl, err },
|
|
'Helm S3 lookup error: credentials error, check "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY" variables or the matching `hostRules` entry',
|
|
);
|
|
} else if (err.message === 'Region is missing') {
|
|
// Thrown client-side by the SDK region resolver, so this string is stable
|
|
logger.debug(
|
|
{ indexUrl },
|
|
'Helm S3 lookup error: missing region, check "AWS_REGION" variable',
|
|
);
|
|
} else {
|
|
logger.debug({ indexUrl, err }, 'Helm S3 lookup error: unknown error');
|
|
}
|
|
|
|
return new ExternalHostError(err, HelmDatasource.id);
|
|
}
|
|
|
|
function getS3Credentials(
|
|
indexUrl: string,
|
|
): S3ClientConfig['credentials'] | undefined {
|
|
const { username, password, token } = hostRules.find({
|
|
hostType: HelmDatasource.id,
|
|
url: indexUrl,
|
|
});
|
|
|
|
// Fall back to the default AWS credential provider chain
|
|
if (!username || !password) {
|
|
return undefined;
|
|
}
|
|
|
|
return {
|
|
accessKeyId: username,
|
|
secretAccessKey: password,
|
|
sessionToken: token,
|
|
};
|
|
}
|