mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 10:09:50 +00:00
fbedd41e82
* test: replace manual process.env mutation with vi.stubEnv
Enable Vitest's `unstubEnvs` so env stubs are reverted automatically
before every test, and convert the manual `process.env.X = ...` /
`delete process.env.X` pairs in specs to `vi.stubEnv()`.
This removes the hand-written `afterEach` cleanup blocks and the
`const OLD_ENV = process.env` / `process.env = { ...OLD_ENV }`
save-restore dance, which silently leaked state between tests when a
test set a variable without a matching delete.
Left as-is (incompatible with `unstubEnvs`, which unstubs before each
test, not after):
- module top-level env writes (cocoapods, gomod, post-update, pip-compile
and bundler artifacts specs)
- `beforeAll` env writes -- the two in `util/http` moved to `beforeEach`
* test: stop asserting on ambient environment variables
Three specs asserted on values that the surrounding environment can
override, so they only passed on a machine that happened not to set them:
- `util/exec/env`: `getChildProcessEnv()` forwards every entry of
`basicEnvVars`, but the spec only seeded a subset. Any other forwarded
variable that was set ambiently (e.g. a lowercase `http_proxy`) leaked
into the `toEqual` assertion. Clear all of them first.
- `util/git/index`: `process.env.GIT_SSH_COMMAND` deliberately overrides
the default that the two env-inheritance tests assert on. Clear it.
- `logger/pretty-stdout`: the colorized level strings are built at import
time, so the `beforeEach` setting `FORCE_COLOR` could never affect them
-- it was dead code, and the test silently assumed a terminal without
colour support. Derive the expectation the same way the module does.
* test(datasource/nuget): use a throwaway cache dir for nupkg downloads
The `determine source URL from nupkg` tests do not mock the filesystem,
so they really wrote downloaded packages into a fixed `/tmp/cache` path.
That fails wherever the system tmpdir is not writable, and two checkouts
running the suite at once would share the same directory.
Use `tmp.dir({ unsafeCleanup: true })` and clean it up afterwards, which
is the pattern the other specs that touch disk already use.
* feat(lint): add renovate/prefer-stub-env rule
Enforces in specs what the migration to `vi.stubEnv` established:
- assigning to or deleting `process.env.X` inside `beforeEach`, `afterEach`,
`it` or `test` is reported, with a fixer that rewrites it to `vi.stubEnv()`
- module scope, `describe` bodies and `beforeAll` / `afterAll` are left alone:
`unstubEnvs` reverts stubs *before* each test, so a stub created there is
gone by the time the first test runs, and those must keep assigning directly
- replacing the `process.env` object is reported everywhere and never fixed.
`vi.stubEnv()` captures the original object when the worker starts, so after
a reassignment its deletes silently target the old object
The rule found 28 further violations in specs the earlier sweep missed, since
that one was anchored on `delete process.env`. Twelve were auto-fixed; the
rest replaced `process.env` wholesale and are now `clearEnv()` from test/util.
`util/exec/index.spec.ts` opts out with a comment: it asserts on the whole
child env, and `vi.stubEnv()` cannot express that because it maps `PROD`,
`DEV` and `SSR` onto '' instead of deleting them.
111 lines
4.3 KiB
TypeScript
111 lines
4.3 KiB
TypeScript
import { RuleTester } from 'oxlint/plugins-dev';
|
|
import rule from './prefer-stub-env.ts';
|
|
|
|
RuleTester.describe = describe;
|
|
RuleTester.it = it;
|
|
|
|
const ruleTester = new RuleTester({
|
|
languageOptions: { parserOptions: { lang: 'ts' } },
|
|
});
|
|
|
|
ruleTester.run('prefer-stub-env', rule, {
|
|
valid: [
|
|
// module scope: a stub here is reverted before the first test runs
|
|
`process.env.CONTAINERBASE = 'true';`,
|
|
`delete process.env.NPM_CONFIG_CACHE;`,
|
|
// `beforeAll` / `afterAll` / `describe` bodies run once, same problem
|
|
`beforeAll(() => { process.env.FOO = 'bar'; });`,
|
|
`afterAll(() => { delete process.env.FOO; });`,
|
|
`describe('suite', () => { process.env.FOO = 'bar'; });`,
|
|
// reading is always fine
|
|
`it('works', () => { expect(process.env.FOO).toBe('bar'); });`,
|
|
`beforeEach(() => { const old = process.env.FOO; });`,
|
|
// already migrated
|
|
`beforeEach(() => { vi.stubEnv('FOO', 'bar'); });`,
|
|
// a different object that merely looks similar
|
|
`beforeEach(() => { other.env.FOO = 'bar'; });`,
|
|
`beforeEach(() => { process.other.FOO = 'bar'; });`,
|
|
// deleting something that is not a `process.env` member
|
|
`beforeEach(() => { delete foo.bar; });`,
|
|
],
|
|
invalid: [
|
|
{
|
|
code: `beforeEach(() => { process.env.FOO = 'bar'; });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
output: `beforeEach(() => { vi.stubEnv('FOO', 'bar'); });`,
|
|
},
|
|
{
|
|
code: `afterEach(() => { delete process.env.FOO; });`,
|
|
errors: [{ messageId: 'preferStubEnvDelete' }],
|
|
output: `afterEach(() => { vi.stubEnv('FOO', undefined); });`,
|
|
},
|
|
{
|
|
code: `it('works', () => { process.env.FOO = 'bar'; });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
output: `it('works', () => { vi.stubEnv('FOO', 'bar'); });`,
|
|
},
|
|
{
|
|
code: `test('works', () => { delete process.env.FOO; });`,
|
|
errors: [{ messageId: 'preferStubEnvDelete' }],
|
|
output: `test('works', () => { vi.stubEnv('FOO', undefined); });`,
|
|
},
|
|
// the innermost suite function decides
|
|
{
|
|
code: `describe('suite', () => { beforeEach(() => { process.env.FOO = 'bar'; }); });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
output: `describe('suite', () => { beforeEach(() => { vi.stubEnv('FOO', 'bar'); }); });`,
|
|
},
|
|
// `it.only` / `it.each(...)` are recognised as test contexts
|
|
{
|
|
code: `it.only('works', () => { process.env.FOO = 'bar'; });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
output: `it.only('works', () => { vi.stubEnv('FOO', 'bar'); });`,
|
|
},
|
|
{
|
|
code: `it.each([1])('works', () => { delete process.env.FOO; });`,
|
|
errors: [{ messageId: 'preferStubEnvDelete' }],
|
|
output: `it.each([1])('works', () => { vi.stubEnv('FOO', undefined); });`,
|
|
},
|
|
// computed access keeps the key expression verbatim
|
|
{
|
|
code: `beforeEach(() => { process.env['FOO'] = 'bar'; });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
output: `beforeEach(() => { vi.stubEnv('FOO', 'bar'); });`,
|
|
},
|
|
{
|
|
code: `beforeEach(() => { envVars.forEach((key) => { delete process.env[key]; }); });`,
|
|
errors: [{ messageId: 'preferStubEnvDelete' }],
|
|
output: `beforeEach(() => { envVars.forEach((key) => { vi.stubEnv(key, undefined); }); });`,
|
|
},
|
|
// the assigned value is carried over verbatim
|
|
{
|
|
code: `beforeEach(() => { process.env.FOO = upath.join(dir, 'x'); });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
output: `beforeEach(() => { vi.stubEnv('FOO', upath.join(dir, 'x')); });`,
|
|
},
|
|
// compound assignment has no direct stub equivalent, so it is not fixed
|
|
{
|
|
code: `beforeEach(() => { process.env.PATH += ':/x'; });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
},
|
|
// used as an expression rather than a statement, so it is not fixed
|
|
{
|
|
code: `it('works', () => { const v = (process.env.FOO = 'bar'); });`,
|
|
errors: [{ messageId: 'preferStubEnv' }],
|
|
},
|
|
// replacing the whole object is reported anywhere, and never fixed
|
|
{
|
|
code: `const OLD_ENV = process.env; beforeEach(() => { process.env = { ...OLD_ENV }; });`,
|
|
errors: [{ messageId: 'noProcessEnvReassign' }],
|
|
},
|
|
{
|
|
code: `beforeAll(() => { process.env = {}; });`,
|
|
errors: [{ messageId: 'noProcessEnvReassign' }],
|
|
},
|
|
{
|
|
code: `process.env = {};`,
|
|
errors: [{ messageId: 'noProcessEnvReassign' }],
|
|
},
|
|
],
|
|
});
|