mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 18:19:51 +00:00
Sebastian Poxhofer
97327c3d28
* refactor(linters): add prefer-coerce-array rule Refs #45217 `x ?? []` and `coerceArray(x)` say the same thing, but only the second one is searchable and consistent. The rule flags a `??` whose default is a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])` still passes. Applying it across `lib/` surfaced three spots the helper cannot cover, which keep `?? []` with a disable comment or a narrower fix: - `package-files.ts` destructures a tuple, which `coerceArray()` widens - `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array - `mise/upgradeable-tooling.ts` declares a `Record` return, so its `?? []` fallback was wrong to begin with and becomes `coerceObject()` * refactor(platform/github): hoist the GHE version header lookup `Object.entries(...).find()` returns a tuple, and defaulting it with `?? []` only to destructure the second element reads as an array default when it is not one. Name the found entry instead, which drops the `?? []` rather than routing a tuple through `coerceArray()`.
54 lines
1.5 KiB
TypeScript
54 lines
1.5 KiB
TypeScript
import { RuleTester } from 'oxlint/plugins-dev';
|
|
import rule from './prefer-coerce-array.ts';
|
|
|
|
RuleTester.describe = describe;
|
|
RuleTester.it = it;
|
|
|
|
const ruleTester = new RuleTester({
|
|
languageOptions: { parserOptions: { lang: 'ts' } },
|
|
});
|
|
|
|
ruleTester.run('prefer-coerce-array', rule, {
|
|
valid: [
|
|
// already using the helper
|
|
`const a = coerceArray(x);`,
|
|
// non-empty default
|
|
`const a = x ?? [1];`,
|
|
// asserted default is not a bare array literal
|
|
`const a = x ?? ([] as string[]);`,
|
|
// object default belongs to `prefer-coerce-object`
|
|
`const a = x ?? {};`,
|
|
// other logical operators
|
|
`const a = x || [];`,
|
|
`const a = x && [];`,
|
|
// assignment rather than a logical expression
|
|
`x ??= [];`,
|
|
// destructuring and parameter defaults have no helper form
|
|
`const { a = [] } = obj;`,
|
|
`function f(a = []) {}`,
|
|
// empty array unrelated to a nullish default
|
|
`const a = [];`,
|
|
],
|
|
invalid: [
|
|
{
|
|
code: `const a = x ?? [];`,
|
|
errors: [{ messageId: 'preferCoerceArray' }],
|
|
},
|
|
// optional chaining operand
|
|
{
|
|
code: `const a = x?.y ?? [];`,
|
|
errors: [{ messageId: 'preferCoerceArray' }],
|
|
},
|
|
// call expression operand
|
|
{
|
|
code: `for (const f of getFiles() ?? []) {}`,
|
|
errors: [{ messageId: 'preferCoerceArray' }],
|
|
},
|
|
// chained nullish defaults report once, on the outer expression
|
|
{
|
|
code: `const a = x ?? y ?? [];`,
|
|
errors: [{ messageId: 'preferCoerceArray' }],
|
|
},
|
|
],
|
|
});
|