mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-08 04:53:36 +00:00
Sebastian Poxhofer
58771bb183
* refactor(oxlint): enable func-style Enable the built-in func-style rule as ["warn", "declaration"] so that named functions are written as function declarations instead of arrow or function expressions assigned to variables, matching the convention in docs/development/best-practices.md (Functions section). Inline arrow callbacks are unaffected; prefer-arrow-callback continues to cover the callback direction. Severity is "warn" instead of "error" as a fallback: a repo-wide run found 196 pre-existing violations (70 in spec files, 126 in production code), exceeding the 80-violation fix threshold for this change, so no violations were fixed here. Follow-up work can convert the offenders (largest clusters: lib/modules/versioning/ruby, lib/util/cache/package, lib/modules/versioning/maven, lib/modules/versioning/gradle) and then raise the rule to "error". Note oxlint 1.72 also supports an allowTypeAnnotation option if typed consts should remain arrows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * ci(linter): enforce func-style at error * refactor(func-style): convert const-arrow functions to declarations in with-cache spec and ruby versioning * refactor(func-style): convert const-arrow functions to declarations in maven/gradle modules * refactor(func-style): convert const-arrow functions to declarations in remaining versioning modules * refactor(func-style): convert const-arrow functions to declarations in platform modules Discriminated-union closures (ensureCommentRemoval byTopic/byContent helpers in github, gitlab, bitbucket, bitbucket-server) needed the narrowed field passed explicitly as a parameter, since function declarations are hoisted and lose the outer if-narrowing that inline arrow-function closures previously relied on. * refactor(func-style): convert const-arrow functions to declarations across util/manager/datasource modules One case (logger/renovate-logger.ts logOnceFn) is kept as an arrow function with a documented oxlint-disable: it is stored on this.logger.once[level] and relies on lexically-bound this, which a hoisted function declaration would not preserve. * refactor(func-style): convert remaining const-arrow test helpers to declarations get-updated.spec.ts: hoisted expectPipCompilePackageAndLockFile to module scope (it only closes over the module-level pipCompile mock) and added a documented oxlint-disable for vitest/expect-expect on its caller test, since oxlint's expect-expect check does not trace assertions through an externally-defined helper function. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
78 lines
2.2 KiB
TypeScript
78 lines
2.2 KiB
TypeScript
import { DateTime, Settings } from 'luxon';
|
|
import type { Timestamp } from '../../../../util/timestamp.ts';
|
|
import * as packageCache from '../../../cache/package/index.ts';
|
|
import { clone } from '../../../clone.ts';
|
|
import type {
|
|
GithubDatasourceItem,
|
|
GithubGraphqlCacheRecord,
|
|
} from '../types.ts';
|
|
import { GithubGraphqlPackageCacheStrategy } from './package-cache-strategy.ts';
|
|
|
|
function isoTs(t: string) {
|
|
return `${t.replace(' ', 'T')}:00.000Z` as Timestamp;
|
|
}
|
|
|
|
function mockTime(input: string): void {
|
|
const now = DateTime.fromISO(isoTs(input)).valueOf();
|
|
Settings.now = () => now;
|
|
}
|
|
|
|
type CacheRecord = GithubGraphqlCacheRecord<GithubDatasourceItem>;
|
|
|
|
describe('util/github/graphql/cache-strategies/package-cache-strategy', () => {
|
|
const cacheGet = vi.spyOn(packageCache, 'get');
|
|
const cacheSet = vi.spyOn(packageCache, 'set');
|
|
|
|
it('reconciles old cache record with new items', async () => {
|
|
const item1 = { version: '1', releaseTimestamp: isoTs('2020-01-01 10:00') };
|
|
const item2 = { version: '2', releaseTimestamp: isoTs('2020-01-01 11:00') };
|
|
const item3 = { version: '3', releaseTimestamp: isoTs('2020-01-01 12:00') };
|
|
|
|
const oldItems = {
|
|
'1': item1,
|
|
'2': item2,
|
|
'3': item3,
|
|
};
|
|
const cacheRecord: CacheRecord = {
|
|
items: oldItems,
|
|
createdAt: isoTs('2022-10-15 12:00'),
|
|
};
|
|
cacheGet.mockResolvedValueOnce(clone(cacheRecord));
|
|
|
|
const now = '2022-10-30 12:00';
|
|
mockTime(now);
|
|
|
|
const newItem = {
|
|
version: '4',
|
|
releaseTimestamp: isoTs('2022-10-15 18:00'),
|
|
};
|
|
const page = [newItem, item3, item2, item1];
|
|
|
|
const strategy = new GithubGraphqlPackageCacheStrategy(
|
|
'_test-namespace',
|
|
'bar',
|
|
);
|
|
const isPaginationDone = await strategy.reconcile(page);
|
|
const res = await strategy.finalizeAndReturn();
|
|
|
|
expect(res).toEqual([item1, item2, item3, newItem]);
|
|
expect(isPaginationDone).toBe(true);
|
|
expect(cacheSet.mock.calls).toEqual([
|
|
[
|
|
'_test-namespace',
|
|
'bar',
|
|
{
|
|
items: {
|
|
'1': item1,
|
|
'2': item2,
|
|
'3': item3,
|
|
'4': newItem,
|
|
},
|
|
createdAt: isoTs('2022-10-15 12:00'),
|
|
},
|
|
15 * 24 * 60,
|
|
],
|
|
]);
|
|
});
|
|
});
|