Files
renovate/lib/util/cache/package/legacy.ts
Sebastian Poxhofer 16ef1715e9 refactor(linters): add rules for @sindresorhus/is helpers (#45229)
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules

Flag ad-hoc type checks that have @sindresorhus/is equivalents:
- .filter(Boolean) -> .filter(isTruthy)
- typeof x === 'string' -> isString(x)
- x === null || x === undefined -> isNullOrUndefined(x) (and negation)

The typeof x === 'object' shape lives in a separate suggestion-only rule
(renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject()
are not drop-in equivalents: null, arrays and functions behave differently.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: fix renovate/prefer-is-helpers violations

Replace ad-hoc type checks with @sindresorhus/is helpers across lib/:
- 13x .filter(Boolean) -> .filter(isTruthy)
- 36x typeof x ==/!== 'string' -> isString(x) / !isString(x)
- 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation)

Promote renovate/prefer-is-helpers to error now that the codebase is clean.
renovate/prefer-is-object stays at warn: its 15 remaining sites guard
parsed YAML/JSON or unknown values where isObject()/isPlainObject() are
not provably equivalent (null/array/function semantics).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: enforce renovate/prefer-is-object at error level

Resolve the 15 remaining warnings and raise the rule from warn to error:

- Migrate 10 sites to isObject() where the guarded value provably cannot
  be a function (parsed YAML/JSON, typed exec command arguments, or
  test-controlled fixtures): helm-values, woodpecker, bun, pre-commit
  managers, exec utils, file package cache, and the github http spec.
  In the bun manager this also fixes a latent crash where a null
  `workspaces` value would throw on the `in` operator.
- Keep 5 sites as reasoned oxlint-disable comments where excluding
  functions is load-bearing: the byte-exact fingerprint canonicalizer
  (2), the circularity walker, the zod result guard, and the generic
  hasKey helper.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-13 14:22:03 +00:00

49 lines
1.3 KiB
TypeScript

import { isString } from '@sindresorhus/is';
import { DateTime } from 'luxon';
import { decompressFromBase64, decompressFromBuffer } from '../../compress.ts';
// TODO: Delete this decode-only support, legacy.spec.ts, and the single call
// site in impl/base.ts once pre-envelope entries have expired.
export interface LegacyEntry {
value: unknown;
expiry: DateTime | undefined;
}
interface LegacyJsonEntry {
value: unknown;
expiry: unknown;
}
export async function decodeLegacyEntry(data: Buffer): Promise<LegacyEntry> {
if (data[0] === 0x7b) {
return await decodeLegacyJsonEntry(data);
}
return await decodeLegacySqliteEntry(data);
}
async function decodeLegacyJsonEntry(data: Buffer): Promise<LegacyEntry> {
const cached = JSON.parse(data.toString('utf8')) as LegacyJsonEntry;
if (!isString(cached.value) || !isString(cached.expiry)) {
throw new Error('Invalid legacy JSON package cache entry');
}
const json = await decompressFromBase64(cached.value);
return {
value: JSON.parse(json),
expiry: DateTime.fromISO(cached.expiry),
};
}
async function decodeLegacySqliteEntry(data: Buffer): Promise<LegacyEntry> {
const json = await decompressFromBuffer(data);
return {
value: JSON.parse(json),
expiry: undefined,
};
}