Files
Sebastian Poxhofer a1971afa78 fix(linters): add linting rule to enforce usage of our regEx utility (#44690)
* ci(linter): add renovate/require-regex-util rule

Adds a custom oxlint rule that flags raw RegExp usage in lib/
production code: any `new RegExp(...)` call and any regex literal
that is not the direct first argument of `regEx(...)`. The regEx()
helper from lib/util/regex.ts uses the RE2 engine for ReDoS-safe
matching and caches compiled patterns. lib/util/regex.ts itself is
exempt.

The rule is disabled for **/*.spec.ts, test/**, and tools/** via
config overrides, because vitest APIs such as expect.stringMatching
need bare RegExp instances (a past commit reverted regEx() there).

Severity is set to "warn" instead of "error": the repo currently has
197 pre-existing violations (above the agreed mechanical-fix
threshold of 80), and a number of them are deliberately
RE2-incompatible patterns (lookahead/lookbehind/named backreferences,
see TODO #12872/#12875 markers in e.g. lib/modules/versioning/rez/
pattern.ts and lib/modules/manager/dockerfile/extract.ts) that need
per-site judgment before they can be wrapped in regEx() or suppressed
with a justified disable comment. No violation fixes are included in
this commit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* ci(linter): enforce renovate/require-regex-util at error

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: use regEx() for regex literals and RegExp construction in lib

Burn down all renovate/require-regex-util violations (197):

- wrap RE2-compatible regex literals and RegExp constructions in regEx()
- rewrite lookaround patterns where behavior is provably preserved:
  goproxy separator split, sbt-package link extraction, leiningen
  comment stripping and keyword search, npm GitHub owner validation
  (unit-count bound replaced by an explicit length check)
- keep native RegExp with disable comments where RE2 cannot be used:
  moo / good-enough-parser lexer patterns (moo rejects RE2 instances),
  MigrationsService propertyName (matched via isRegExp, which RE2
  instances fail), rez named backreferences and lookaheads, GitHub
  markdown link negative lookbehind, emoji astral-plane matching
- drop stale TODO #12875 comments for patterns current re2 handles

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor: reduce require-regex-util disable comments

Rewrite the github massage-markdown-links URL regex to capture an
optional `api.` prefix in a named group (skipped in code) instead of
relying on a negative lookbehind, so both the base and global variants
can use regEx()/RE2 and their two disable comments are removed. Add
spec cases for api-prefixed URLs that match the URL shape.

Consolidate the four related line disables in rez/pattern.ts (bound and
range patterns emulating Python conditional patterns via named
backreferences and lookaheads, which RE2 cannot express) into a single
block disable/enable pair, matching the treatment of the lexer files.

Disable comment count drops from 13 to 8.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(datasource/sbt-package): use named capture group in link regex

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(manager/cake): restore original multiLineComment regex spelling

The [^] -> [\\s\\S] rewrite was only needed for an RE2 wrap that was
later reverted; keep the diff minimal.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(datasource/go): skip empty GOPROXY segments

The switch from a lookahead split to a capture-group split (needed because
RE2 has no lookahead support) changed how empty GOPROXY segments parse:
`a|,b` yielded `{ url: ',', fallback: '|' }` before and
`{ url: '', fallback: ',' }` after. The comma fallback only continues on
404/410, so a failing proxy ahead of an empty segment silently stopped the
lookup instead of falling through to the remaining proxies.

Empty segments carry no url to query, so drop them.

* refactor(datasource/go): use isTruthy for empty segment filter

* fix(datasource/go): filter empty segments before mapping

Filtering after the map broke the contextual typing from the
GoproxyItem[] annotation, widening fallback to string.

* refactor(platform/github): use regEx() for merge queue query stripping

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-14 14:30:46 +00:00

173 lines
4.6 KiB
TypeScript

import { isString } from '@sindresorhus/is';
import type { SemVer } from 'semver';
import semver from 'semver';
import stable from 'semver-stable';
import { regEx } from '../../../util/regex.ts';
import { isBreaking as semverIsBreaking } from '../semver/index.ts';
import type { NewValueConfig, VersioningApi } from '../types.ts';
export const id = 'semver-coerced';
export const displayName = 'Coerced Semantic Versioning';
export const urls = ['[Semantic Versioning](https://semver.org/)'];
export const supportsRanges = false;
function isStable(version: string): boolean {
// matching a version with the semver prefix
// v1.2.3, 1.2.3, v1.2, 1.2, v1, 1
const regx = regEx(
/^v?(?<major>\d+)(?<minor>\.\d+)?(?<patch>\.\d+)?(?<others>.+)?/,
);
const m = regx.exec(version);
if (!m?.groups) {
return false;
}
const major = m.groups.major;
const newMinor = m.groups.minor ?? '.0';
const newPatch = m.groups.patch ?? '.0';
const others = m.groups.others ?? '';
const fixed = major + newMinor + newPatch + others;
return stable.is(fixed);
}
function sortVersions(a: string, b: string): number {
const aCoerced = semver.coerce(a);
const bCoerced = semver.coerce(b);
return aCoerced && bCoerced ? semver.compare(aCoerced, bCoerced) : 0;
}
function getMajor(a: string | SemVer): number | null {
const aCoerced = semver.coerce(a);
return aCoerced ? semver.major(aCoerced) : null;
}
function getMinor(a: string | SemVer): number | null {
const aCoerced = semver.coerce(a);
return aCoerced ? semver.minor(aCoerced) : null;
}
function getPatch(a: string | SemVer): number | null {
const aCoerced = semver.coerce(a);
return aCoerced ? semver.patch(aCoerced) : null;
}
function matches(version: string, range: string): boolean {
const coercedVersion = semver.coerce(version);
return coercedVersion ? semver.satisfies(coercedVersion, range) : false;
}
function equals(a: string, b: string): boolean {
const aCoerced = semver.coerce(a);
const bCoerced = semver.coerce(b);
return aCoerced && bCoerced ? semver.eq(aCoerced, bCoerced) : false;
}
function isValid(version: string): boolean {
return !!semver.valid(semver.coerce(version));
}
function getSatisfyingVersion(
versions: string[],
range: string,
): string | null {
const coercedVersions = versions
.map((version) =>
semver.valid(version) ? version : semver.coerce(version)?.version,
)
.filter(isString);
return semver.maxSatisfying(coercedVersions, range);
}
function minSatisfyingVersion(
versions: string[],
range: string,
): string | null {
const coercedVersions = versions
.map((version) => semver.coerce(version)?.version)
.filter(isString);
return semver.minSatisfying(coercedVersions, range);
}
function isLessThanRange(version: string, range: string): boolean {
const coercedVersion = semver.coerce(version);
return coercedVersion ? semver.ltr(coercedVersion, range) : false;
}
function isGreaterThan(version: string, other: string): boolean {
const coercedVersion = semver.coerce(version);
const coercedOther = semver.coerce(other);
if (!coercedVersion || !coercedOther) {
return false;
}
return semver.gt(coercedVersion, coercedOther);
}
const startsWithNumberRegex = regEx(`^\\d`);
function isSingleVersion(version: string): boolean {
// Since coercion accepts ranges as well as versions, we have to manually
// check that the version string starts with either 'v' or a digit.
if (!version.startsWith('v') && !startsWithNumberRegex.exec(version)) {
return false;
}
return !!semver.valid(semver.coerce(version));
}
// If this is left as an alias, inputs like "17.04.0" throw errors
export function isVersion(input: string): boolean {
return isValid(input);
}
export { getSatisfyingVersion, isVersion as isValid };
function getNewValue({
currentValue,
currentVersion,
newVersion,
}: NewValueConfig): string {
if (currentVersion === `v${currentValue}`) {
return newVersion.replace(regEx(/^v/), '');
}
return newVersion;
}
function isBreaking(version: string, current: string): boolean {
const coercedVersion = semver.coerce(version)?.toString();
const coercedCurrent = semver.coerce(current)?.toString();
return !!(
coercedVersion &&
coercedCurrent &&
semverIsBreaking(coercedVersion, coercedCurrent)
);
}
function isCompatible(version: string): boolean {
return isVersion(version);
}
export const api: VersioningApi = {
equals,
getMajor,
getMinor,
getPatch,
isBreaking,
isCompatible,
isGreaterThan,
isLessThanRange,
isSingleVersion,
isStable,
isValid,
isVersion,
matches,
getSatisfyingVersion,
minSatisfyingVersion,
getNewValue,
sortVersions,
};
export default api;