mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 10:09:50 +00:00
Sebastian Poxhofer
97327c3d28
* refactor(linters): add prefer-coerce-array rule Refs #45217 `x ?? []` and `coerceArray(x)` say the same thing, but only the second one is searchable and consistent. The rule flags a `??` whose default is a bare `[]` literal; a non-empty default or an asserted `([] as Foo[])` still passes. Applying it across `lib/` surfaced three spots the helper cannot cover, which keep `?? []` with a disable comment or a narrower fix: - `package-files.ts` destructures a tuple, which `coerceArray()` widens - `generate.spec.ts` defaults `matchAll()`, an iterator rather than an array - `mise/upgradeable-tooling.ts` declares a `Record` return, so its `?? []` fallback was wrong to begin with and becomes `coerceObject()` * refactor(platform/github): hoist the GHE version header lookup `Object.entries(...).find()` returns a tuple, and defaulting it with `?? []` only to destructure the second element reads as an array default when it is not one. Name the found entry instead, which drops the `?? []` rather than routing a tuple through `coerceArray()`.
27 lines
757 B
TypeScript
27 lines
757 B
TypeScript
import { coerceArray } from '../../../util/array.ts';
|
|
import type { Pr } from '../types.ts';
|
|
import type { PrState, PullRequest } from './schema.ts';
|
|
|
|
const PR_STATE_MAP: Record<PrState, string> = {
|
|
DRAFT: 'open',
|
|
OPEN: 'open',
|
|
REJECTED: 'closed',
|
|
MERGED: 'merged',
|
|
};
|
|
|
|
export function mapPrFromScmToRenovate(pr: PullRequest): Pr {
|
|
return {
|
|
sourceBranch: pr.source,
|
|
targetBranch: pr.target,
|
|
createdAt: pr.creationDate,
|
|
closedAt: pr.closeDate ?? undefined,
|
|
hasAssignees: !!pr.reviewer?.length,
|
|
labels: pr.labels,
|
|
number: parseInt(pr.id, 10),
|
|
reviewers: coerceArray(pr.reviewer?.map((review) => review.displayName)),
|
|
state: PR_STATE_MAP[pr.status],
|
|
title: pr.title,
|
|
isDraft: pr.status === 'DRAFT',
|
|
};
|
|
}
|