mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-02 18:43:40 +00:00
Sebastian Poxhofer
16ef1715e9
* feat(lint): add renovate/prefer-is-helpers and renovate/prefer-is-object rules Flag ad-hoc type checks that have @sindresorhus/is equivalents: - .filter(Boolean) -> .filter(isTruthy) - typeof x === 'string' -> isString(x) - x === null || x === undefined -> isNullOrUndefined(x) (and negation) The typeof x === 'object' shape lives in a separate suggestion-only rule (renovate/prefer-is-object, kept at warn) because isObject()/isPlainObject() are not drop-in equivalents: null, arrays and functions behave differently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: fix renovate/prefer-is-helpers violations Replace ad-hoc type checks with @sindresorhus/is helpers across lib/: - 13x .filter(Boolean) -> .filter(isTruthy) - 36x typeof x ==/!== 'string' -> isString(x) / !isString(x) - 6x x === null || x === undefined -> isNullOrUndefined(x) (and negation) Promote renovate/prefer-is-helpers to error now that the codebase is clean. renovate/prefer-is-object stays at warn: its 15 remaining sites guard parsed YAML/JSON or unknown values where isObject()/isPlainObject() are not provably equivalent (null/array/function semantics). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor: enforce renovate/prefer-is-object at error level Resolve the 15 remaining warnings and raise the rule from warn to error: - Migrate 10 sites to isObject() where the guarded value provably cannot be a function (parsed YAML/JSON, typed exec command arguments, or test-controlled fixtures): helm-values, woodpecker, bun, pre-commit managers, exec utils, file package cache, and the github http spec. In the bun manager this also fixes a latent crash where a null `workspaces` value would throw on the `in` operator. - Keep 5 sites as reasoned oxlint-disable comments where excluding functions is load-bearing: the byte-exact fingerprint canonicalizer (2), the circularity walker, the zod result guard, and the generic hasKey helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
31 lines
813 B
TypeScript
31 lines
813 B
TypeScript
import { isString } from '@sindresorhus/is';
|
|
import { z } from 'zod/v4';
|
|
import { Toml } from '../../../util/schema-utils/index.ts';
|
|
|
|
/**
|
|
* Known non-version sections in .prototools files.
|
|
* These are structured TOML tables, not version pins.
|
|
* @see https://moonrepo.dev/docs/proto/config
|
|
*/
|
|
export const nonVersionKeys = new Set([
|
|
'settings',
|
|
'plugins',
|
|
'tools',
|
|
'env',
|
|
'shell',
|
|
'backends',
|
|
]);
|
|
|
|
export const ProtoToolsFile = Toml.pipe(
|
|
z.record(z.string(), z.unknown()).transform((data) => {
|
|
const versions: Record<string, string> = {};
|
|
for (const [key, value] of Object.entries(data)) {
|
|
if (isString(value) && !nonVersionKeys.has(key)) {
|
|
versions[key] = value;
|
|
}
|
|
}
|
|
return { versions };
|
|
}),
|
|
);
|
|
export type ProtoToolsFile = z.infer<typeof ProtoToolsFile>;
|