Files
Sebastian Poxhofer 3412de84ce refactor(linters): enable oxlint rule prefer-named-capture-group (#44714)
* refactor(lint): enable oxlint prefer-named-capture-group at error

Numbered capture groups (m[1], $1) break silently when a regex is
edited and group order shifts. Named groups (?<name>...) make intent
explicit and accesses (m.groups.name) resilient to reordering.

This enables the built-in eslint rule prefer-named-capture-group,
surfacing 321 pre-existing unnamed-group violations across ~121
files to be burned down incrementally in follow-up commits.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(versioning): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations in
lib/modules/versioning/. Unused capture groups (only reachable via
.test() or whole-match) become non-capturing (?:...); groups whose
value is read become named (?<name>...), with accesses rewritten to
match.groups!.<name> (or destructured from .groups!) instead of
positional match[n]/$n so a future edit that reorders groups cannot
silently break the reader.

Two cases needed extra care to preserve behavior:
- semver/common.ts and poetry/patterns.ts split() on a regex whose
  capture group is relied upon by String.prototype.split to keep the
  separator in the output array; the group is kept capturing and
  named, not converted to non-capturing.
- hashicorp/convertor.ts's semverRegex is only ever embedded via
  .source into a named `(?<version>...)` group elsewhere and never
  matched directly, so its internal groups are safe to make
  non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(datasource): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/datasource/. Same treatment as the versioning module:
unused groups become non-capturing, used groups get names, and
positional match[n] reads move to match.groups!.<name>.

docker/ecr.ts and pypi/common.ts keep their positional destructuring
(`const [, region] = ...`, `!!m &&`) working unchanged since a named
capture group is still addressable by its numeric index in
JavaScript — only pypi/common.ts's access was rewritten to
m.groups!.owner for clarity since it read a single group directly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(platform): name capture groups for prefer-named-capture-group

Burns down all prefer-named-capture-group violations under
lib/modules/platform/. Uses the repo's established idiom of
`match.groups?.<name>` after an optional-chained exec()/match() (see
bitbucket/index.ts hostnameWithoutApiPrefix, gerrit/utils.ts
extractSourceBranch) and `$<name>` in String.replace replacement
strings. Unused groups (markdown/HTML massaging regexes matched only
to be stripped) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups in ansible-galaxy for prefer-named-capture-group

Burns down prefer-named-capture-group violations in
lib/modules/manager/ansible-galaxy/. newBlockRegEx and blockLineRegEx
dropped their unused outer wrapping group (only the inner key/value
groups were ever read) and named the key/value groups; nameMatchRegex's
remaining unused groups (protocol/user-info/port alternatives) become
non-capturing since only source/hostname/depName/version are read via
.groups. Accesses in collections.ts and roles.ts move from
lineMatch[2]/lineMatch[3] to lineMatch.groups!.key/value.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 1)

Burns down prefer-named-capture-group violations across the first
alphabetical slice of lib/modules/manager/ (ansible through mix).
Used groups get names with accesses rewritten to match.groups!.<name>
(or $<name> in replacement strings); groups whose value is never read
become non-capturing (?:...). Two String.split() call sites
(git-submodules/extract.ts, meteor/extract.ts) keep the established
"named group still readable positionally from the split() result
array" idiom instead of restructuring the destructuring.

bazel/rules/go.ts and buildpacks/extract.ts dockerRef verified
byte-for-byte equivalent before/after via a quick node script since
several nested groups collapsed to non-capturing at once.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(manager): name capture groups for prefer-named-capture-group (batch 2)

Burns down prefer-named-capture-group violations across the remaining
alphabetical slice of lib/modules/manager/ (npm through terragrunt).
Same treatment as batch 1: used groups get names with accesses moved
to match.groups!.<name> or $<name> replacement strings; unused groups
(wrapping alternations, quantifier repetition groups only consumed via
.test(), or values never read from a match) become non-capturing.

terraform/extractors/others/modules.ts and terragrunt/modules.ts share
near-identical URL-parsing regexes (github/bitbucket/git/azure-devops
ref matchers) — the same set of always-unused `depth=`/`&depth=`
query-string groups is converted to non-capturing in both files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(config): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/config/.
Used groups get names with replacement strings switched from $1/$2 to
$<name>; the unused separator group in schedule-migration.ts's
afterBeforeRegex becomes non-capturing. presets/parse.ts keeps
assigning through the already-declared `repo` variable rather than
array-destructuring the exec() result, matching this file's existing
style for the other named-group regexes just above it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(util): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations across lib/util/ and
lib/logger/. Same treatment as previous batches: named groups for
values that are read (via $<name> replacement strings, .groups!.<name>,
or destructured from .groups), non-capturing groups where nothing reads
the captured value (e.g. semantic.ts's angular-commit .test()-only
regex). www-authenticate.ts's tokenizer entries each get their own
named group but keep accessing the match generically via match[1],
since a positionally-indexed named group is still readable by index.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(workers): name capture groups for prefer-named-capture-group

Burns down prefer-named-capture-group violations in lib/workers/.
Used groups get names with $<name> replacement strings; unused
wrapper/alternation groups (e.g. semantic-commit-message.ts's optional
scope/issue wrappers, release-notes.ts's date-heading and
horizontal-rule matchers that are only probed with .search()/replaced
wholesale) become non-capturing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* refactor(test,tools): name capture groups for prefer-named-capture-group

Finishes the prefer-named-capture-group burndown: test/, tools/, and
vitest.config.mts. Groups whose value is read get names ($<name>
replacement strings or .groups.<name> access); groups only used via
.test()/.search() or that feed a .match(/…/g) call (whose return value
is the array of whole matches, not captured groups) become
non-capturing.

This is the last remaining slice of pre-existing violations, so the
rule (already enabled at error repo-wide) now passes with zero
findings across the whole codebase.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RxHFNsSworLcv23xXk9Hk

* fix prettier failure

* refactor(lint): use a named capture group in `v8-ignore-no-count`

New rule from main trips the newly enabled `prefer-named-capture-group` oxlint rule.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-03 09:54:40 +00:00

533 lines
15 KiB
TypeScript

import type { Stats } from 'node:fs';
import os from 'node:os';
import { isTruthy } from '@sindresorhus/is';
import { quote } from 'shlex';
import upath from 'upath';
import { GlobalConfig } from '../../../config/global.ts';
import { logger } from '../../../logger/index.ts';
import { withCache } from '../../../util/cache/package/with-cache.ts';
import { exec } from '../../../util/exec/index.ts';
import type { ExecOptions, ExtraEnv } from '../../../util/exec/types.ts';
import {
chmodLocalFile,
deleteLocalFile,
readLocalFile,
statLocalFile,
writeLocalFile,
} from '../../../util/fs/index.ts';
import { getRepoStatus } from '../../../util/git/index.ts';
import type { StatusResult } from '../../../util/git/types.ts';
import { hashStream } from '../../../util/hash.ts';
import { Http } from '../../../util/http/index.ts';
import { regEx } from '../../../util/regex.ts';
import mavenVersioning from '../../versioning/maven/index.ts';
import type {
PackageDependency,
UpdateArtifact,
UpdateArtifactsConfig,
UpdateArtifactsResult,
} from '../types.ts';
const http = new Http('maven-wrapper');
const DEFAULT_MAVEN_REPO_URL = 'https://repo.maven.apache.org/maven2';
function getChecksumFromUrl(url: string): Promise<string> {
return withCache(
{
namespace: 'url-sha256',
key: url,
ttlMinutes: 3 * 24 * 60, // 3 days
},
() => hashStream(http.stream(url), 'sha256'),
);
}
function getDistributionUrl(content: string): string | null {
const match = regEx(/^distributionUrl\s*=\s*(?<distributionUrl>.+)$/m).exec(
content,
);
return (
match?.groups?.distributionUrl?.replace(regEx(/\\:/g), ':').trim() ?? null
);
}
function getWrapperUrl(content: string): string | null {
const match = regEx(/^wrapperUrl\s*=\s*(?<wrapperUrl>.+)$/m).exec(content);
return match?.groups?.wrapperUrl?.replace(regEx(/\\:/g), ':').trim() ?? null;
}
function constructWrapperUrl(
version: string,
repoUrl: string = DEFAULT_MAVEN_REPO_URL,
): string {
return `${repoUrl}/org/apache/maven/wrapper/maven-wrapper/${version}/maven-wrapper-${version}.jar`;
}
function getWrapperVersion(content: string): string | null {
const match = regEx(/^wrapperVersion\s*=\s*(?<wrapperVersion>.+)$/m).exec(
content,
);
return match?.groups?.wrapperVersion?.trim() ?? null;
}
function getDistributionType(content: string): string | null {
const match = regEx(/^distributionType\s*=\s*(?<distributionType>.+)$/m).exec(
content,
);
return match?.groups?.distributionType?.trim() ?? null;
}
function getChecksumValue(content: string, key: string): string | null {
const match = regEx(`^${key}\\s*=\\s*(?<value>.+)$`, 'm').exec(content);
return match?.groups?.value?.trim() ?? null;
}
function addChecksumAfterLine(
content: string,
lineRegex: RegExp,
key: string,
value: string,
): string {
return content.replace(
regEx(lineRegex),
(lineMatch) => `${lineMatch}\n${key}=${value}`,
);
}
async function updateChecksums(
content: string,
updatedDeps: PackageDependency[],
addDistributionChecksum: boolean,
addWrapperChecksum: boolean,
originalContent: string,
): Promise<string> {
let updatedContent = content;
// Update or add distribution checksum
if (addDistributionChecksum) {
const existingChecksum = getChecksumValue(
updatedContent,
'distributionSha256Sum',
);
const fallbackChecksum = getChecksumValue(
originalContent,
'distributionSha256Sum',
);
const distUrl = getDistributionUrl(updatedContent);
if (distUrl) {
try {
const checksum = await getChecksumFromUrl(distUrl);
if (existingChecksum) {
updatedContent = updatedContent.replace(
regEx(/distributionSha256Sum=.*/),
`distributionSha256Sum=${checksum}`,
);
} else {
// Add checksum after distributionUrl
updatedContent = addChecksumAfterLine(
updatedContent,
regEx(/^(?:distributionUrl\s*=\s*.+)$/m),
'distributionSha256Sum',
checksum,
);
}
} catch (err) {
logger.warn(
{ err, url: distUrl },
'Failed to fetch distribution checksum',
);
if (!existingChecksum && fallbackChecksum) {
updatedContent = addChecksumAfterLine(
updatedContent,
regEx(/^(?:distributionUrl\s*=\s*.+)$/m),
'distributionSha256Sum',
fallbackChecksum,
);
}
}
}
}
// Update or add wrapper checksum
if (addWrapperChecksum) {
const existingChecksum = getChecksumValue(
updatedContent,
'wrapperSha256Sum',
);
const fallbackChecksum = getChecksumValue(
originalContent,
'wrapperSha256Sum',
);
let wrapperUrl = getWrapperUrl(updatedContent);
// If no wrapperUrl, try to construct from wrapperVersion
if (!wrapperUrl) {
const wrapperVersion = getWrapperVersion(updatedContent);
if (wrapperVersion) {
const customRepoUrl = getCustomMavenWrapperRepoUrl(updatedDeps);
wrapperUrl = constructWrapperUrl(
wrapperVersion,
customRepoUrl ?? DEFAULT_MAVEN_REPO_URL,
);
}
}
if (wrapperUrl) {
try {
const checksum = await getChecksumFromUrl(wrapperUrl);
if (existingChecksum) {
updatedContent = updatedContent.replace(
regEx(/wrapperSha256Sum=.*/),
`wrapperSha256Sum=${checksum}`,
);
} else {
// Add checksum after wrapperUrl or wrapperVersion
updatedContent = addChecksumAfterLine(
updatedContent,
regEx(/^(?:wrapperUrl\s*=\s*.+|wrapperVersion\s*=\s*.+)$/m),
'wrapperSha256Sum',
checksum,
);
}
} catch (err) {
logger.warn(
{ err, url: wrapperUrl },
'Failed to fetch wrapper checksum',
);
if (!existingChecksum && fallbackChecksum) {
updatedContent = addChecksumAfterLine(
updatedContent,
regEx(/^(?:wrapperUrl\s*=\s*.+|wrapperVersion\s*=\s*.+)$/m),
'wrapperSha256Sum',
fallbackChecksum,
);
}
}
}
}
return updatedContent;
}
interface MavenWrapperPaths {
wrapperExecutableFileName: string;
localProjectDir: string;
wrapperFullyQualifiedPath: string;
}
async function addIfUpdated(
status: StatusResult,
fileProjectPath: string,
): Promise<UpdateArtifactsResult | null> {
if (status.modified.includes(fileProjectPath)) {
return {
file: {
type: 'addition',
path: fileProjectPath,
contents: await readLocalFile(fileProjectPath),
},
};
}
return null;
}
export async function updateArtifacts({
packageFileName,
newPackageFileContent,
updatedDeps,
config,
}: UpdateArtifact): Promise<UpdateArtifactsResult[] | null> {
try {
logger.debug({ updatedDeps }, 'maven-wrapper.updateArtifacts()');
const hasMavenUpdate = updatedDeps.some((dep) => dep.depName === 'maven');
const hasWrapperUpdate = updatedDeps.some(
(dep) => dep.depName === 'maven-wrapper',
);
// Remember original content properties - we'll restore them after wrapper:wrapper
const hadDistributionChecksum = newPackageFileContent.includes(
'distributionSha256Sum=',
);
const hadWrapperChecksum =
newPackageFileContent.includes('wrapperSha256Sum=');
const originalDistributionType = getDistributionType(newPackageFileContent);
// Skip if no relevant updates
if (!hasWrapperUpdate && !(hasMavenUpdate && hadDistributionChecksum)) {
logger.debug(
'No Maven wrapper or distribution checksum updates - skipping Artifacts update',
);
return null;
}
// If wrapper is being updated, check if mvnw exists first
let cmd: string | null = null;
if (hasWrapperUpdate) {
cmd = await createWrapperCommand(
packageFileName,
originalDistributionType,
);
if (!cmd) {
logger.info('No mvnw found - skipping Artifacts update');
return null;
}
}
// Delete old maven-wrapper.jar if checksums exist and wrapper:wrapper will run
// This prevents checksum validation failure when wrapper:wrapper runs
if (hasWrapperUpdate && (hadWrapperChecksum || hadDistributionChecksum)) {
const jarPath = packageFileName.replace(
'maven-wrapper.properties',
'maven-wrapper.jar',
);
if (jarPath.endsWith('maven-wrapper.jar')) {
try {
await deleteLocalFile(jarPath);
logger.debug({ jarPath }, 'Deleted old maven-wrapper.jar');
} catch {
// File may not exist, ignore
}
}
}
// Strip checksum lines before running wrapper:wrapper to avoid validation failure
// (mvnw would try to validate NEW jar against OLD checksum)
let contentToWrite = newPackageFileContent;
if (hasWrapperUpdate && (hadWrapperChecksum || hadDistributionChecksum)) {
contentToWrite = contentToWrite
.replace(regEx(/^distributionSha256Sum=.*\n?/m), '')
.replace(regEx(/^wrapperSha256Sum=.*\n?/m), '');
}
// Write the properties file
await writeLocalFile(packageFileName, contentToWrite);
// Run wrapper:wrapper if the wrapper itself is being updated
if (hasWrapperUpdate && cmd) {
const extraEnv = getExtraEnvOptions(updatedDeps);
await executeWrapperCommand(cmd, config, packageFileName, extraEnv);
}
// Now update checksums AFTER wrapper:wrapper has run (if it ran)
// This ensures we compute checksums for the actual generated content
if (hadDistributionChecksum || hadWrapperChecksum) {
const currentContent = await readLocalFile(packageFileName, 'utf8');
if (currentContent) {
const contentWithChecksums = await updateChecksums(
currentContent,
updatedDeps,
hadDistributionChecksum,
hadWrapperChecksum,
newPackageFileContent,
);
await writeLocalFile(packageFileName, contentWithChecksums);
}
}
const status = await getRepoStatus();
const artifactFileNames = [
'.mvn/wrapper/maven-wrapper.properties',
'.mvn/wrapper/maven-wrapper.jar',
'.mvn/wrapper/MavenWrapperDownloader.java',
'mvnw',
'mvnw.cmd',
].map(
(filename) =>
packageFileName.replace('.mvn/wrapper/maven-wrapper.properties', '') +
filename,
);
const updateArtifactsResult = (
await getUpdatedArtifacts(status, artifactFileNames)
).filter(isTruthy);
logger.debug(
{ files: updateArtifactsResult.map((r) => r.file?.path) },
`Returning updated maven-wrapper files`,
);
return updateArtifactsResult;
} catch (err) {
logger.debug({ err }, 'Error setting new Maven Wrapper release value');
return [
{
artifactError: {
fileName: packageFileName,
stderr: err.message,
},
},
];
}
}
async function getUpdatedArtifacts(
status: StatusResult,
artifactFileNames: string[],
): Promise<UpdateArtifactsResult[]> {
const updatedResults: UpdateArtifactsResult[] = [];
for (const artifactFileName of artifactFileNames) {
const updatedResult = await addIfUpdated(status, artifactFileName);
if (updatedResult !== null) {
updatedResults.push(updatedResult);
}
}
return updatedResults;
}
/**
* Find compatible java version for maven.
* see https://maven.apache.org/developers/compatibility-plan.html
* @param mavenWrapperVersion current maven version
* @returns A Java semver range
*/
export function getJavaConstraint(
mavenWrapperVersion: string | null | undefined,
): string | null {
const major = mavenWrapperVersion
? mavenVersioning.getMajor(mavenWrapperVersion)
: null;
if (major && major >= 3) {
return '^17.0.0';
}
return '^8.0.0';
}
async function executeWrapperCommand(
cmd: string,
config: UpdateArtifactsConfig,
packageFileName: string,
extraEnv: ExtraEnv,
): Promise<void> {
logger.debug(`Updating maven wrapper: "${cmd}"`);
const { wrapperFullyQualifiedPath } = getMavenPaths(packageFileName);
const execOptions: ExecOptions = {
cwdFile: wrapperFullyQualifiedPath,
docker: {},
extraEnv,
toolConstraints: [
{
toolName: 'java',
constraint:
config.constraints?.java ?? getJavaConstraint(config.currentValue),
},
],
};
try {
await exec(cmd, execOptions);
} catch (err) {
logger.error({ err }, 'Error executing maven wrapper update command.');
throw err;
}
}
function getExtraEnvOptions(deps: PackageDependency[]): ExtraEnv {
const customMavenWrapperUrl = getCustomMavenWrapperRepoUrl(deps);
if (customMavenWrapperUrl) {
return { MVNW_REPOURL: customMavenWrapperUrl };
}
return {};
}
function getCustomMavenWrapperRepoUrl(
deps: PackageDependency[],
): string | null {
const replaceString = deps.find(
(dep) => dep.depName === 'maven-wrapper',
)?.replaceString;
if (!replaceString) {
return null;
}
const match = regEx(/^(?<repoUrl>.*?)\/org\/apache\/maven\/wrapper\//).exec(
replaceString,
);
if (!match) {
return null;
}
return match.groups!.repoUrl === DEFAULT_MAVEN_REPO_URL
? null
: match.groups!.repoUrl;
}
async function createWrapperCommand(
packageFileName: string,
distributionType: string | null,
): Promise<string | null> {
const {
wrapperExecutableFileName,
localProjectDir,
wrapperFullyQualifiedPath,
} = getMavenPaths(packageFileName);
// Use existing distributionType or default to 'script' to preserve JAR-based mode
// (prevents Maven 3.3.x from defaulting to only-script which doesn't support checksums)
const type = distributionType ?? 'script';
const args = `wrapper:wrapper -Dtype=${quote(type)}`;
return await prepareCommand(
wrapperExecutableFileName,
localProjectDir,
await statLocalFile(wrapperFullyQualifiedPath),
args,
);
}
function mavenWrapperFileName(): string {
if (
os.platform() === 'win32' &&
GlobalConfig.get('binarySource') !== 'docker'
) {
return 'mvnw.cmd';
}
return './mvnw';
}
function getMavenPaths(packageFileName: string): MavenWrapperPaths {
const wrapperExecutableFileName = mavenWrapperFileName();
const localProjectDir = upath.join(
upath.dirname(packageFileName),
packageFileName.includes('mvnw') ? '.' : '../../',
);
const wrapperFullyQualifiedPath = upath.join(
localProjectDir,
wrapperExecutableFileName,
);
return {
wrapperExecutableFileName,
localProjectDir,
wrapperFullyQualifiedPath,
};
}
async function prepareCommand(
fileName: string,
cwd: string | undefined,
pathFileStats: Stats | null,
args: string | null,
): Promise<string | null> {
/* v8 ignore next -- hard to test */
if (pathFileStats?.isFile() === true) {
// if the file is not executable by others
if (os.platform() !== 'win32' && (pathFileStats.mode & 0o1) === 0) {
// add the execution permission to the owner, group and others
logger.warn('Maven wrapper is missing the executable bit');
await chmodLocalFile(
// TODO: types (#22198)
upath.join(cwd!, fileName),
pathFileStats.mode | 0o111,
);
}
if (args === null) {
return fileName;
}
return `${fileName} ${args}`;
}
return null;
}