mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-02 10:33:39 +00:00
Sebastian Poxhofer
e0cec3dc95
feat(lint): add `types-location` rule and enable it for `lib/modules`
Reviewers consistently ask for exported types to be moved into a
colocated `types.ts`. Add a `renovate/types-location` oxlint rule that
reports `export interface` / `export type` declarations outside such a
file, and turn it on across `lib/modules`.
Re-exports (`export type { X }`, `export type *`), file-local types, and
values (enums, classes, functions) are left alone. `schema.ts` files and
`schema/` directories are excluded via config, matching how
`zod-schema-location` is configured — inferred types belong next to the
schema they are derived from.
Relocating the 87 existing violations means:
- new `types.ts` files for the modules that had none
- `terragrunt/common.ts` folded into its `types.ts`, as it held nothing
else
- `RangeBound` in `versioning/gradle/compare.ts` un-exported, since only
a file-local interface referenced it
- `bazel-module/parser/fragments.ts` split from its inferred types, which
now live in `parser/types.ts` and infer through a namespace import so
each schema keeps its merged name
98 lines
2.9 KiB
TypeScript
98 lines
2.9 KiB
TypeScript
import is from '@sindresorhus/is';
|
|
import semver from 'semver';
|
|
import { parseUrl } from '../../../../util/url.ts';
|
|
import { GithubReleasesDatasource } from '../../../datasource/github-releases/index.ts';
|
|
import { GithubTagsDatasource } from '../../../datasource/github-tags/index.ts';
|
|
import type { PackageDependency } from '../../types.ts';
|
|
import type {
|
|
GitHubManagerData,
|
|
GitHubUrlParsedResult,
|
|
GitHubUrlType,
|
|
} from '../types.ts';
|
|
import { HomebrewUrlHandler } from './base.ts';
|
|
|
|
export class GitHubUrlHandler extends HomebrewUrlHandler {
|
|
readonly type = 'github';
|
|
|
|
parseUrl(urlStr: string): GitHubUrlParsedResult | null {
|
|
if (!is.nonEmptyString(urlStr)) {
|
|
return null;
|
|
}
|
|
const url = parseUrl(urlStr);
|
|
if (url?.hostname !== 'github.com') {
|
|
return null;
|
|
}
|
|
let s = url.pathname.split('/');
|
|
s = s.filter((val) => val);
|
|
const ownerName = s[0];
|
|
const repoName = s[1];
|
|
let currentValue: string | undefined;
|
|
let urlType: GitHubUrlType | undefined;
|
|
|
|
if (s[2] === 'archive') {
|
|
urlType = 'archive';
|
|
// old archive url in form: [...]/archive/<tag>.tar.gz
|
|
currentValue = s[3];
|
|
if (currentValue === 'refs') {
|
|
// new archive url in form: [...]/archive/refs/tags/<tag>.tar.gz
|
|
currentValue = s[5];
|
|
}
|
|
const targz = currentValue.slice(
|
|
currentValue.length - 7,
|
|
currentValue.length,
|
|
);
|
|
if (targz === '.tar.gz') {
|
|
currentValue = currentValue.substring(0, currentValue.length - 7);
|
|
}
|
|
} else if (s[2] === 'releases' && s[3] === 'download') {
|
|
urlType = 'releases';
|
|
currentValue = s[4];
|
|
}
|
|
|
|
if (!currentValue || !urlType) {
|
|
return null;
|
|
}
|
|
|
|
return { type: 'github', currentValue, ownerName, repoName, urlType };
|
|
}
|
|
|
|
createDependency(
|
|
parsed: GitHubUrlParsedResult,
|
|
sha256: string | null,
|
|
url: string,
|
|
): PackageDependency<GitHubManagerData> {
|
|
return {
|
|
depName: `${parsed.ownerName}/${parsed.repoName}`,
|
|
currentValue: parsed.currentValue,
|
|
datasource:
|
|
parsed.urlType === 'releases'
|
|
? GithubReleasesDatasource.id
|
|
: GithubTagsDatasource.id,
|
|
managerData: {
|
|
type: 'github',
|
|
ownerName: parsed.ownerName,
|
|
repoName: parsed.repoName,
|
|
sha256,
|
|
url,
|
|
},
|
|
};
|
|
}
|
|
|
|
buildArchiveUrls(
|
|
managerData: GitHubManagerData,
|
|
newVersion: string,
|
|
): string[] | null {
|
|
const ownerName = managerData.ownerName;
|
|
const repoName = managerData.repoName;
|
|
|
|
// Use semver.coerce to get version without 'v' prefix for filename
|
|
const coercedVersion = semver.coerce(newVersion);
|
|
const versionForFilename = coercedVersion?.version ?? newVersion;
|
|
|
|
return [
|
|
`https://github.com/${ownerName}/${repoName}/releases/download/${newVersion}/${repoName}-${versionForFilename}.tar.gz`,
|
|
`https://github.com/${ownerName}/${repoName}/archive/refs/tags/${newVersion}.tar.gz`,
|
|
];
|
|
}
|
|
}
|