mirror of
https://github.com/renovatebot/renovate.git
synced 2026-11-01 02:00:10 +00:00
Sebastian Poxhofer
e0cec3dc95
feat(lint): add `types-location` rule and enable it for `lib/modules`
Reviewers consistently ask for exported types to be moved into a
colocated `types.ts`. Add a `renovate/types-location` oxlint rule that
reports `export interface` / `export type` declarations outside such a
file, and turn it on across `lib/modules`.
Re-exports (`export type { X }`, `export type *`), file-local types, and
values (enums, classes, functions) are left alone. `schema.ts` files and
`schema/` directories are excluded via config, matching how
`zod-schema-location` is configured — inferred types belong next to the
schema they are derived from.
Relocating the 87 existing violations means:
- new `types.ts` files for the modules that had none
- `terragrunt/common.ts` folded into its `types.ts`, as it held nothing
else
- `RangeBound` in `versioning/gradle/compare.ts` un-exported, since only
a file-local interface referenced it
- `bazel-module/parser/fragments.ts` split from its inferred types, which
now live in `parser/types.ts` and infer through a namespace import so
each schema keeps its merged name
58 lines
1.7 KiB
TypeScript
58 lines
1.7 KiB
TypeScript
import type { Category } from '../../../constants/index.ts';
|
|
import type { RangeStrategy } from '../../../types/index.ts';
|
|
import { HackageDatasource } from '../../datasource/hackage/index.ts';
|
|
import * as pvpVersioning from '../../versioning/pvp/index.ts';
|
|
import type {
|
|
PackageDependency,
|
|
PackageFileContent,
|
|
RangeConfig,
|
|
} from '../types.ts';
|
|
import { extractNamesAndRanges, findDepends } from './extract.ts';
|
|
import type { CabalDependency } from './types.ts';
|
|
|
|
export const defaultConfig = {
|
|
managerFilePatterns: ['/\\.cabal$/'],
|
|
pinDigests: false,
|
|
};
|
|
|
|
export const categories: Category[] = ['haskell'];
|
|
|
|
export const supportedDatasources = [HackageDatasource.id];
|
|
|
|
export function extractPackageFile(content: string): PackageFileContent {
|
|
const deps = [];
|
|
let current = content;
|
|
for (;;) {
|
|
const maybeContent = findDepends(current);
|
|
if (maybeContent === null) {
|
|
break;
|
|
}
|
|
const cabalDeps: CabalDependency[] = extractNamesAndRanges(
|
|
maybeContent.buildDependsContent,
|
|
);
|
|
for (const cabalDep of cabalDeps) {
|
|
const dep: PackageDependency = {
|
|
depName: cabalDep.packageName,
|
|
currentValue: cabalDep.currentValue,
|
|
datasource: HackageDatasource.id,
|
|
packageName: cabalDep.packageName,
|
|
versioning: pvpVersioning.id,
|
|
replaceString: cabalDep.replaceString.trim(),
|
|
autoReplaceStringTemplate: '{{{depName}}} {{{newValue}}}',
|
|
};
|
|
deps.push(dep);
|
|
}
|
|
current = current.slice(maybeContent.lengthProcessed);
|
|
}
|
|
return { deps };
|
|
}
|
|
|
|
export function getRangeStrategy({
|
|
rangeStrategy,
|
|
}: RangeConfig): RangeStrategy {
|
|
if (rangeStrategy === 'auto') {
|
|
return 'widen';
|
|
}
|
|
return rangeStrategy!;
|
|
}
|